shenoudab/active_device

Mobile Device Detector

active_device's Issues

Palm Pre not detected

Palm Pre user agent (http://user-agent-string.info/list-of-ua/browser-detail?browser=Palm%20Pre%20web%20browser) seems to go unnoticed as a mobile device.

I guess you're checking for "/Palm/", but checking for "/Pre/" would recognize Palm Pre devices.

Helper methods don't work

I get undefined local variable or method `device_brand' after including ActiveDevise. The is_mobile_browser? method works, but the helpers to give the device brand and model don't work.

Opera Mini Simulator not being detected as mobile device

This is the simulator page http://www.opera.com/mini/demo/

It's sending the user agent string "Opera/9.80 (J2ME/MIDP; Opera Mini/5.0.16875/958; U; en) Presto/2.4.15"

Considering it includes "Opera Mini", "Presto" and "J2ME" this seems like it should be considered mobile?

iPad detection

This needs to support iPad.

Chrome OS is showing up as Safari

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US) AppleWebKit/532.0 (KHTML, like Gecko) Chrome/3.0.195.38 Safari/532.0

calling agent_name with a browser with this URL returns Safari when it is Chrome

JSON request from mobile device

On my mobile device I'm using JavaScript to fetch some data from a backend server.
The JSON request's format is :json (a.k.a "application/json"). But your :set_mobile_format before_filter ignores this and sets the format to :mobile (a.k.a. "text/html").

This causes a 406 Not Acceptable error in the controller response, when a JSON request comes in with format "JSON" (a.k.a "application/json") but the response comes in format "text/html".

respond_to do |format|
  format.json do
    # never gets called because format is set to :mobile by set_mobile_format filter
  end
end

Any way to add additional skip_before_filter test?
Or maybe only apply your test if the incoming request format is :html
Or let me specify a list of formats for which the set_mobile_format method should be called.

W3C validator detected as mobile by is_mobile_browser?

http://validator.w3.org

Android OS detection?

I've checked http://github.com/shenoudab/active_device/blob/master/lib/active_device/os.rb but I can't see any Android OS detection values. Is Android OS detection supported?