sheriftalaat/aws-sg-analyzer

Python script to analyze and extract all Security Groups information

aws-sg-analyzer's Issues

Ugly fix| Reporting generation SG rules (Security Groups) value 'None'

@SherifTalaat

Awesome tool to perform quick inspection of SG, rules , ports , useful for my Pen-testing on microservices on AWS 2024 and Segmentation Test PCI-DSS requirements v4 (deeper manually inspection on SG rules) , we found some bug during the generation of reports and we have fixed (ugly fix) , please could we take into account for coming releases ? below quick details:

Error seems trough the line 242 when values are 'None' on SG name? , my suggestions below :

Kali Linux Box 
$ python3 --version 
Python 3.11.7
$ python3 aws_sg_analyzer.py

Code line 242:

AWS-SG-Analyzer/aws_sg_analyzer.py

Line 242 in 3a28968

SrcDstEndpoint = 'sg:' + sgName

My ugly fix below:

[../snip]

       elif 'ReferencedGroupInfo' in rule:
            SrcDstEndpoint = rule['ReferencedGroupInfo']['GroupId']
            sgName = get_security_group_name_by_id(sgList, SrcDstEndpoint)
            # 22.FEB.24 | Ugly fix Alex H. aka @_alt3kx_  | Error: TypeError: can only concatenate str (not "NoneType") to str
            if sgName is not None:
                SrcDstEndpoint = 'sg:' + sgName
            else: 
                print(bColors.BrightYellow + "SG Name is None")

After fix got all the reports clearly SG rules according to my regions audited :-)

Regards
/alt3kx