shhossain/facedb

A face database for large scale face recognition

facedb's Issues

Dependency Handling and Initialization

I noticed in db.py, there are conditional imports that are controlled by global variables and locks which may lead to race conditions. This may happen as threads enter locked sections and do not have the information on whether the necessary module is already imported by another unless it is reflected by the globals. If the checking of these globals is for some reason bypassed, two threads may end up importing the same module twice, leading to unnecessary operations. This could be avoided by importing these modules at the start of the program and global variables should not be modified unless the modification is handled through a thread-safe mechanism such as thread-local storage.

The variable PINECONE_ENVIRONMENT is is deprecated.

The currently version of pinecone used only PINECONE_API_KEY to connect.
The key PINECONE_ENVIRONMENT is deprecated.

Ex:

pc = Pinecone(api_key='YOUR_API_KEY')

Multiple images per person

Hello,
As far as I understand the package does not allow adding multiple images of the same person, the update function just replaces the embeeding.
Do you consider adding this feature? Or can you give me some suggestions/pitfalls to avoid/direction how should I implement it?

Create a proper documentation for the package

Error: python setup.py egg_info did not run successfully (Ubuntu)

Got this error when trying to install from pip with venv, but works fine if I run locally

Collecting facedb
  Using cached FaceDB-0.0.11.tar.gz (22 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error
  
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-jxm2tbc8/facedb_264dbc4cde644c5fa4b895d2e1cc1f9c/setup.py", line 13, in <module>
          with open("requirements.txt") as f:
      FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt'
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

OS: Ubuntu 22.04.3 LTS x86_64
Python Version: 3.10.12

how to upload embeddings from local .npz file to the faceDB

Hi, can you please let me know how I can upsert my local embeddings (saved to .npz file) generated from my own embedding model to the vector database, i tried but i cannot find a way to do it, Thanks in advance!