shin8484/popupwindow

PopupWindow is a simple Popup using another UIWindow in Swift

popupwindow's Issues

iOS 9 support

please add iOS 9 support!

Can't use with Cocoapods

When performing pod install the error appears:

[!] CocoaPods could not find compatible versions for pod "PopupWindow":
In Podfile:
PopupWindow

Specs satisfying the PopupWindow dependency were found, but they required a higher minimum deployment target.

Which version should I use?

BasePopupViewController missing from Pod download

Hi,

When I try and use the info from the sample app, I noticed that your pod file contains "BasePopupViewController" but this isn't there when I download the latest pod file

Problem running the demo project

I get the error No such module 'PopupWindow' when I try to run the demo project on Xcode 9.3.

Fatal Error

There is a fatal error in PopupViewContainable.swift using Xcode 11.3:
PopupViewContainable.swift:12:5: error: 'weak' cannot be applied to a property declaration in a protocol
weak var containerView: UIView! { get }

The error can be fixed by removing the "weak" in the var declaration. I'm not sure if a property needs to be declared as "weak" instead.

Unidentified view on top of popup view if rendered after camera image picker dismissal

I tried showing login screen popup provided in the demo after a the dismissal of camera imagepicker view. It shows 2 unidentified views on top of the popup view causing to obstruct interaction with the popup view. This happens only if i tried to show the popup after camera view dismissal

Device: iPhone XS
iOS: 13.5.1

func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
    let imagePickerVC = UIImagePickerController()
    imagePickerVC.delegate = self
    magePickerVC.sourceType = .camera
    imagePickerVC.videoMaximumDuration = 10
    imagePickerVC.mediaTypes = [String(kUTTypeMovie), String(kUTTypeImage)]
    present(imagePickerVC, animated: true)
}

func imagePickerController(_ picker: UIImagePickerController, didFinishPickingMediaWithInfo info: [UIImagePickerController.InfoKey : Any]) {
    dismiss(animated: true) {
        PopupWindowManager.shared.changeKeyWindow(rootViewController: LoginPopupViewController())
    }
}

why not push to CocoaPods/Specs

Why not push to CocoaPods/Specs? It is version 0.1.0 in CocoaPods/Specs.

Top toast not ready for iPhone X

You probably know this but I'll let this here anyway.

I checked because I fought with this already and didn't like my aproach which involves calculating frames... bleah