shiroechi/boorudex

C# library to access booru public API.

Hi there 👋

I'm dotnet developer especially C# and currently live in Indonesia.

boorudex's Issues

HELP WANTED!

Template for e621.net

• Implement all GET method
  it's easy to do, but there's a rate limit for request.
• Can manage the limit rate (2 request/second)
  It can handle if there's many request at once. My idea is using queue, but I think it again it not efficient. Other template don't have this rate limit thing for request GET method.
  this what I don't know to handle it.

Null HttpClient

BooruDex/Booru/Booru.cs

Lines 258 to 260 in c89b2ff

	using (var request = new HttpRequestMessage(HttpMethod.Get, url))
	using (var response = await this._HttpClient.SendAsync(request, HttpCompletionOption.ResponseHeadersRead))
	using (var stream = await response.Content.ReadAsStreamAsync())

BooruDex/Booru/Booru.cs

Lines 309 to 311 in c89b2ff

	using (var request = new HttpRequestMessage(HttpMethod.Get, url))
	using (var response = await this._HttpClient.SendAsync(request, HttpCompletionOption.ResponseHeadersRead))
	using (var stream = await response.Content.ReadAsStreamAsync())

When creating client with null HttpClient it not called the lazy option.

Sometimes error when parsing JSON from danbooru

error in random post

Danbooru template

The template can be used for:

• https://danbooru.donmai.us/
• http://safebooru.donmai.us/

Gelbooru and Gelbooru02 template

The template can be used for:
Gelbooru02 doesn't have tag API but Gelbooru has

• http://gelbooru.com/
• https://safebooru.org/

Moebooru template

The template can be used for:

• https://yande.re/
• http://lolibooru.moe/
• http://konachan.com/

Post inside pool using danbooru is slow

if the post inside the post is too many, let's say 100, it will so long to wait until finish.

Do not clone and dispose

BooruDex/Booru/Booru.cs

Lines 821 to 826 in c89b2ff

	using (var temp = await this.GetJsonResponseAsync<JsonDocument>(url))
	{
	obj = temp.RootElement.Clone();
	}

don't clone the object then dispose it, if you do like that it will consume more CPU and RAM

Using 2 tags at the same time via DanbooruDonmai got an error about the number of tags.

Try to run this:

var a = new DanbooruDonmai();
var b = await a.GetRandomPostAsync(1, new string[] { "animated", "arknights" });

You'll get something like this

Unexpected error occured.
Status code = 422
Reason = Unprocessable Entity.

I don't know why, but when trying to GET /posts.xml?random=true&limit=1&tags=animated arknights it redirects you to /posts.xml?limit=1&tags=animated+arknights+random:1 and their API thinks that you are trying to find 3 tags instead of 2

Get request on “Find similar”

Hi there. I am trying to make Booru desktop tool for finding similar images and getting their links (like they did it on yandere). Yesterday I looked through the functions of your library, but haven’t seen something alike. Is there any way I have access to this functionality, or it’s a tool for the websites’ developers use only. Thanks in advance.

Preview url in Gelbooru02 error