shish/shimmie2

An easy-to-install community image gallery (aka booru)

     _________.__     .__                   .__         ________
    /   _____/|  |__  |__|  _____    _____  |__|  ____  \_____  \
    \_____  \ |  |  \ |  | /     \  /     \ |  |_/ __ \  /  ____/
    /        \|   Y  \|  ||  Y Y  \|  Y Y  \|  |\  ___/ /       \
   /_______  /|___|  /|__||__|_|  /|__|_|  /|__| \___  >\_______ \
           \/      \/           \/       \/          \/         \/

Shimmie

Documentation

• Install straight on disk
• Install in docker container
• Upgrade process
• Basic settings
• Advanced config
• Developer notes
• High-performance notes

Licence

All code is released under the GNU GPL Version 2 unless mentioned otherwise.

If you give shimmie to someone else, you have to give them the source (which should be easy, as PHP is an interpreted language...). If you want to add customisations to your own site, then those customisations belong to you, and you can do what you want with them.

shimmie2's Issues

broken images

I have change the host and have faced such problem
http://img.leprosorium.com/1321415

Corrupted link in numeric_score

ext\numeric_score\main.php class NumericScore
Line 35

35      if($event instanceof DisplayingImageEvent) {
36          if(!$user->is_anonymous()) {
37              $html = $this->theme->get_voter_html($event->image);
38              if($user->is_admin()) {
39                  $html .= "<p><a href='/numeric_score_votes/{$event->image->id}'>See All Votes</a>";
40              }
41              $page->add_block(new Block("Image Score", $html, "left", 20));
42          }
43      }

The generated link in line 39 should be generated via make_link. Also, this line should be put in the theme.php, so it could be altered within a custom theme.

Silent program exit @ mysql _connect

Hey guys,

I'm at my wits' end... I transfered my whole programming environment to another computer, and now shimmie2 isn't working anymore. He keeps showing me nothing than a blank screen when I go to index.php.
So, I enabled error displaying in the php.ini

error_reporting = E_ALL & ~E_DEPRECATED

display_errors = On

display_startup_errors = On

(I hope this is correct.)
But he doesn't show me any error.
I managed to break down the error source on the native function "mysql_connect". It seems that the program stops at this function without any error or something.

lib\adodb\drivers\adodb-mysql.inc.php
function _connect
line 363

        if (ADODB_PHPVER >= 0x4300){
            print "<br />ADODB_PHPVER >= 0x4300";
            print "<br />" . $argHostname . " " . $argUsername . " " .
                     $argPassword . " " . $this->forceNewConnect . " " . $this->clientFlags;
            $this->_connectionID = mysql_connect($argHostname,$argUsername,$argPassword,
                                                $this->forceNewConnect,$this->clientFlags);
            print "<br />mysql connected";
        }

As you can see, I added some debug printing, to see what's happening.
"ADODB_PHPVER >= 0x4300" gets printed, than he also shows me the (correct) connection parameters, but the "mysql connected" message never gets printed.

As I said, I had shimmie2 running (not to say, I have the exact same version running on another computer), but this one wont work. (The same database is used btw.)

So, does anyone see the error right away or is able to tell me, how to find the error? mysql_error doesn't work, cause the program never reaches any code beyond mysql_connect...

Downtime page error

when applied, using the default theme, the following is shown to non admin users
if no administrators are online, there is no way to log back in

Notice: Undefined variable: user in /home/public_html/shimmie/contrib/downtime/theme.php on line 22

Fatal error: Call to a member function get_auth_html() on a non-object in /home/public_html/shimmie/contrib/downtime/theme.php on line 22

Request: Autoresize when uploading on site.

If i resize image from site - all fine, can you add autoresize function for Upload?

Also for existing ones.
If you want to change your images in all gal?
Then, if the image resolution is less - to miss.
If more then automatically change the resolution.

https source links broken

Insert: https://somedomain.com/
got http://https//somedomain.com/

It's ok in the database.

Feature request: Admin tool to revert mass tag vandalism

This depends on tag_history being enabled so I'm not sure if it should go in the Admin Tools panel or the Tag Changes panel. It'd make more sense in Admin Tools.

Add a form with the following inputs:
Revert all tag changes made by <user or IP address> since <date or "since the beginning">

Collect all the images changed by the above criteria from the tag_histories table and execute a revert to the change just before that to wipe the vandalism.
(Credit to JAM for the idea)

index page download from Firefox.

I made an upgrade to the current one. there was a problem.
Browser Firefox

1. Many of the thumbs, do not load the first time.
2. Many times the offer pops download index page when you click on the links on the site.
3. The same problem occurs when you try to add tags. i.e. when selected and clicked "Set"
4. If I try to refresh the page bypassing the cache, then pops up again offer download Index.php

It may be a problem with the caching system? Maybe add a button to force a cleanup?

Request: Users

Can you add new user category?
As I see it:

1. Admin - All privileges
2. Moderator - deals with reports, rolls back the history tag, download, delete and most admin priv.
3. Power User - can create pools, manage tags, upload, but do not remove it. Submit reports.
4. User - standard
5. Guest

Give admin the ability to create groups of users that will be strictly defined rights. Those who would give himself.
For example:
Moderator - manage users, reports, tag history, images, wiki, forum, ratings, commas... more need think.

PU (Power User) - give them the ability to create pools, report about the image, set tag, upload pictures (without delete), view other users pools, use the Image Score, add the wiki page, see all rating (safe-explicit, while ordinary users could only watch safe-quest.), give the possibility to display more images per page (25,50,100 images per page)

SU (Standart User) - standart rights without pools, ratings

In general admin to the right of deciding who and what opportunities to give.
And yet it would be nice to add the ability to hide some of the marked images that are available for free to view only a particular group (ex PU, incl. Admin and Moder).

Method to sort by top scored images in numeric_score module

I've been looking into the possibility of sorting images by score in a display similar to post/list and it appears to be a non-trivial hack to the imageboard code... Am I right, or would this actually be a lot easier than I am seeing? What would be the best way of going about this?

Wiki. space broke the text.

When I need to insert long words or URLs in Wiki, in the text when you save it, there are gaps and omissions. The solid is crushed to 10 text characters, or something like that. Links to images, tags, just split up and of course do not work.

I've got a problem with thai langauge user's comment.

I've got a problem with thai langauge user's comment. it represents as an unknown langauge. In the previuos version (2.2.4) it works fine. (Now I use 2.3.1) I've no idea how to fix this, please advice.

And i've tested it at your site, it doesn't work too. http://shimmie.shishnet.org/v2/post/view/2880

Thank you!

Bookmarklet Cancel doesn't work

If you use the Bookmarklet to upload (transload) an image, and you click the "Cancel" button, the image is still uploaded.

ReCAPTCHA is not working

Looks like ReCAPTCHA support is broken after it has become one of the Google services.
I wonder if API was not changed, and only minor fixes i.e. changing domain names will suffice.

Fatal error: Call to undefined function newadoconnection()

As the title says.
I tried a fresh install with the master branch first on my comp with WAMP, and then on a free hosting server. Both gave me this error.
I'm using PHP 5.x+ and MySQL

Fatal error: Call to undefined function newadoconnection() in /home/nagel182/public_html/board/install.php on line 241

Fatal error: Call to undefined function NewADOConnection() in C:\wamp\www\board\install.php on line 241

even if i used the 2.3 branch as a base and overwritten it with the master its still the
same problem.
eve

Error Ext RSS Images - update from 2.3

PHP Fatal error: Call to undefined method CustomPage::add_header() in /home/ssllav/public_html/site.ru/ext/rss_images/main.php on line 20

paged tag list

sometimes there are a lot of tags, limit by first letter?

Alternative user authentication

Okay, I'd like to change the user authentication of shimmie. I'm about to create the possibility to inherit a java session from the same domain.

But I have the problem that I don't know how to alter the needed function (_get_user) and class (User) while keeping my code compatible with future releases.

My first approach is to create a new extension, but how would I overwrite the said function/class without also altering the calls of them?

Any help appreciated :)

Alias Editor MySQL error

After I installed Shimmie and tried to access the Alias Editor it gave me an MySQL error:

mysql error: [1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'OFFSET 0 LIMIT 30' at line 1] in EXECUTE("SELECT oldtag, newtag FROM aliases ORDER BY newtag ASC OFFSET 0 LIMIT 30")

i searched around the code and found that line which it was refering too:
in ext/alias_editor/main.php Line 73
$alias = $database->db->GetAssoc("SELECT oldtag, newtag FROM aliases ORDER BY newtag ASC OFFSET ? LIMIT ?",array($page_number * $alias_per_page, $alias_per_page);

I searched around for this error and learned that the LIMIT is little bit more important than offset.

So I switched the two to this:

$alias = $database->db->GetAssoc("SELECT oldtag, newtag FROM aliases ORDER BY newtag ASC LIMIT ? OFFSET ?", array($alias_per_page, $page_number * $alias_per_page)

And it worked!

Search for not existings tags causes PHP warning

When searching for an unused tag, I get

Warning: mt_rand() [function.mt-rand]: max(-1) is smaller than min(0) in /srv/www/vhosts/xxxxxxxxx/subdomains/yyyyy/core/imageboard.pack.php on line 94

Warning: assert() [function.assert]: Assertion failed in /srv/www/vhosts/xxxxxxxxx/subdomains/yyyyy/core/imageboard.pack.php on line 104

Edit: I'm using Shimmie v2.3.0
Edit2: Seems to be Shimmie v2.3.1 which still says v2.3.0

Home page - not utf8

Encoding Extension Homepage is not utf-8.
When I tried to translate it into another language (ru), had to specify the encoding. Charset - cp1252 or cp1251.
He showed that in Ext Homepage - encoding is not like the entire engine.
Please check it.

Thumbnail cropping problem.

Any thumbnails lower than a 5:1 aspect ratio seem to get cropped at the end and moved to the front of the thumbnail.

Example @ 300x60 : http://imgur.com/q6Zim
Example @ 300x59 : http://imgur.com/tGgwj

Through a bit of testing, problem seems to be with the +repage command..

Edit: Forgot to mention I'm using imagemagick.

Unable to login with 2.3?

This is a weird one - 2.3 installed fine & I created the first account but I can't log it in.

Searching around it seems I've encountered this from almost a year ago in RC3: http://redmine.shishnet.org/issues/show/850

If I login with correct credentials I get redirected to /user but it just says "You aren't logged in. First do that, then you can see your stats." The shimmie cookies seem to have been set though...

This was originally happening to me on a local Ubuntu VM install. A db & script wipe followed by a reinstall didn't fix it. I then tried it on my Linode and I get the same behaviour.

You can access the Linode install here if it helps diagnose the problem: http://shimmie.everypony.net/

In case the bug is setup related - the Linode is;
OS: Ubuntu 10.04
Web server: nginx (0.8 stable)
PHP: 5.3.5 + Suhosin patch. This is running in PHP-FPM mode (FastCGI alternative) behind nginx
MySQL 5.1

Oh, and I'm also using APC for caching in PHP.

Other scripts using login cookies/sessions are working fine on this setup (for example, Wordpress 3).

nginx's access.log shows the login POST going to index.php?q=/user_admin/login and then a 302 redirect sending me to index.php?q=/user as expected (well - I'm assuming that's the normal process?).

The only line in nginx's error.log is a deprecation notice about split() in the util include.

Any ideas? D:

Edit: Oh, and 2.2 works fine on this server setup btw.

handle_pixel: Quotes around convert in exec() breaks Windows ImageMagick thumb engine?

OS: Microsoft Windows XP Professional Version 2002 Service Pack 2 & Service Pack 3
Webserver: Apache httpd 2.2.17 & 2.2.19 (Apache.org win32 VC6 builds)
PHP: 5.2.4 & 5.2.17

I use some crappy old XP Pro SP2 machine as a webserver. ImageMagick thumbnails weren't working in my new Shimmie install, even though they are still working in my outdated install. I did some debugging (tested 2.3.1 & git trunk).

I wanted to check the parameters sent to convert.exe. I found it (line 98), outputted it to .bat and found it executed perfectly through the command prompt, resulting in a thumbnail. The syntax is valid, wtf? After tweaking around with the section, I found that convert wouldn't execute through exec() on my machine unless "convert" was entered without surrounding quotes.

Examples:
$cmd is "convert" "images/84/8434054aae547c4882941613956c0ad6[0]" -crop 461x700 +repage -flatten -strip -thumbnail 192x192 jpg:"thumbs/84/8434054aae547c4882941613956c0ad6" -- No thumbnail

$cmd is "convert.exe" "images/84/8434054aae547c4882941613956c0ad6[0]" -crop 461x700 +repage -flatten -strip -thumbnail 192x192 jpg:"thumbs/84/8434054aae547c4882941613956c0ad6" -- No thumbnail

$cmd is convert "images/84/8434054aae547c4882941613956c0ad6[0]" -crop 461x700 +repage -flatten -strip -thumbnail 192x192 jpg:"thumbs/84/8434054aae547c4882941613956c0ad6" -- A wild thumbnail appears!

$cmd is convert.exe "images/84/8434054aae547c4882941613956c0ad6[0]" -crop 461x700 +repage -flatten -strip -thumbnail 192x192 jpg:"thumbs/84/8434054aae547c4882941613956c0ad6" -- Also works

In the meantime I've added a string replace below sprintf to unquote convert.
$cmd = sprintf($format, $convert, $inname, $size[0], $size[1], $w, $h, $outname);
$cmd = str_replace(""convert"", "convert", $cmd);
It works perfectly after that.

Oh, and I'm not sure if my OS is supposed to fail this check, but it does:
if(in_array("OS", $_SERVER) && $_SERVER["OS"] == 'Windows_NT')

The default thumb_convert_path if I did pass it, convert.exe, would still fail because of the quotes added later..

The strange thing is that if I add quotes around convert in my old Shimmie install, it executes fine:
exec("convert {$inname}[0] -geometry {$w}x{$h} -quality {$q} jpg:$outname"); -- Original, works

exec(""convert" {$inname}[0] -geometry {$w}x{$h} -quality {$q} jpg:$outname"); -- This also works

Is PHP being stupid?

If PHP is at fault, it's unfortunate that it occurs in the last release of 5.2. 5.3.5 (VC6) and 5.3.6 (VC9) appear to break Shimmie entirely.

Fatal Error: If mysql version is 5.5

Hello,

If you try to install shish shimmie2 v2.3.1 and your MySQL database server is version 5.5 (or newer?) installation will be canceled with this error:

[code]
Fatal error: Uncaught exception 'ADODB_Exception' with message 'mysql error: [1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'TYPE=InnoDB DEFAULT CHARSET='utf8'' at line 5] in EXECUTE("CREATE TABLE aliases ( oldtag VARCHAR(128) NOT NULL PRIMARY KEY, newtag VARCHAR(128) NOT NULL, INDEX(newtag) ) TYPE=InnoDB DEFAULT CHARSET='utf8'") ' in C:\xampp\htdocs\lib\adodb\adodb-exceptions.inc.php:78
Stack trace:
#0 C:\xampp\htdocs\lib\adodb\adodb.inc.php(1040): adodb_throw('mysql', 'EXECUTE', 1064, 'You have an err...', 'CREATE TABLE al...', false, Object(ADODB_mysql))
#1 C:\xampp\htdocs\lib\adodb\adodb.inc.php(1015): ADOConnection->_Execute('CREATE TABLE al...', false)
#2 C:\xampp\htdocs\install.php(252): ADOConnection->Execute('CREATE TABLE al...')
#3 C:\xampp\htdocs\install.php(220): create_tables('mysql://root:@l...')
#4 C:\xampp\htdocs\install.php(149): install_process('mysql://root:@l...')
#5 C:\xampp\htdocs\install.php(112) in C:\xampp\htdocs\lib\adodb\adodb-exceptions.inc.php on line 78

[/code]

That is because MySQL 5.5 use "ENGINE=InnoDB" instead "TYPE=InnoDB" in table creating.

Regards.
Ivelin Georgiev

Upload extension doesn't check $file['error']

If PHP throws a file error (because, say, the file is bigger than upload_max_filesize), the upload extension doesn't handle the error and tries to upload the file anyways. It goes back to the main page without reporting the error.

Simply checking for it in try_upload should fix it.

Localisation Support

While the script is not so big, you could make all the language constructs in a single language_file?
And make it a plug-in separately?
Each time bit hard to translate each file with every update. ((
Site Template files can be skipped.
Please.

Request: Empty box or ADS blocks

Can I add an empty box?
For example, to insert ads, e. Google, or your links to friends, buttons,
Maybe like extension.
And in the settings, take the place of display and enable or disable the display.
Over the image - checkbox.
Under the image - checkbox.
In the column - checkbox.

Pools

Using the newest version of XAMPP and the newest of shimmie. If I try to click into Pools I get this error page:

Message: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''20' OFFSET '0'' at line 7
Error: SELECT p.id, p.user_id, p.public, p.title, p.description, p.posts, u.name AS user_name FROM pools AS p INNER JOIN users AS u ON p.user_id = u.id ORDER BY p.date DESC LIMIT ? OFFSET ?

alias_editor/imageboard.pack: Aliasing a tag already in use fails

When aliasing a tag that's already in use on pictures, PDO barfs up a MySQL state error about unbound variable:

Message: SQLSTATE[HY093]: Invalid parameter number: parameter was not defined Error: SELECT images.*, UNIX_TIMESTAMP(posted) AS posted_timestamp FROM tags, image_tags, images WHERE tag LIKE :tag0 AND tags.id = image_tags.tag_id AND image_tags.image_id = images.id AND (images.id < :val)ORDER BY images.id DESC LIMIT :limit OFFSET :offset

This is apparently fixed by adding $tag_n = 0; after merging the tag querylets as below (core/imageboard.pack.php around lines 743-756):

// merge all the tag querylets into one generic one
$sql = "0";
$terms = array();
foreach($tag_querylets as $tq) {
    global $tag_n;
    $sign = $tq->positive ? "+" : "-";
    $sql .= " $sign (tag LIKE :tag$tag_n)";
    $terms["tag$tag_n"] = $tq->tag;
    $tag_n++;

    if($sign == "+") $positive_tag_count++;
    else $negative_tag_count++;
}
$tag_n = 0;

I spent a good time trying to wonder what was wrong and then spotted that blasted tag1 in the query variables. Hope this helps, I'm unable to provide a pull request/patch other than this right now.

MySQL > 4.x compatibility

Hi Guys

I'm totally new to github, php and shimmie2 :D Anyway, I found a little bug within the code which makes it impossible to use a MySQL Database higher than version 4. (And I would like to use the current version 5.5)

In the file core\database.class.php line 86

        $ctes = "TYPE=InnoDB DEFAULT CHARSET='utf8'";

Has to be

        $ctes = "ENGINE=InnoDB DEFAULT CHARSET='utf8'";

This fix is still downwards compatible to MySQL 3.x/4.x

Call to undefined method PDOStatement (tags_editcloud)

When i switch on tags_editcloud and tried to look at the picture ... I got this:
Fatal error: Call to undefined method PDOStatement::GetArray() in /home/xxx/public_html/ext/tag_editcloud/main.php on line 99

in version 2.3.5 no trouble.

rss not working

XML Parsing error: syntax error
line 1, column 1: XML parsing error: :1:1: not well-formed (invalid token)

nice urls not working

Test failed, test failed. Once enter to "board config" and nice url broke

Confirmation box for Delete in images

A confirmation box whenever the Delete image button is pressed would be a useful safeguard for those of us that have trigger happy mouse fingers =)

Problem with large queries in alias/add

/index.php?q=/alias/add

when i add tag alias, and changes too large ~200-400 pics minimum, i have error page 404.

only when adding.

Only after 3-8 times to trying script eat him normal and add to table.

This is in june-july 2011 version. Maybe in newer version no that problem? Or this is problem about lang charset?
Anybody, please check with big alias changes.

Keywords from Tags

Some templates are inserted tags in the field Keywords. And some do not. For example "lite", if you look properties page displays only the keywords entered in the admin, and I would like to tag was taken from the image.
How to fix this?

tag_history does not gather existing tags when enabled

If I enable tag_history after uploading images and tagging them, the current tags are not included in the log. This means if the site is vandalized or a mistake made while changing tags, the original tags will be unrecoverable because the first entry in the log is the change made after tag_history was enabled.

I propose that the current image_tags table be imported into the tag_histories table during the install process for the tag_history extension. Any idea of what kind of CPU impact this might have on a site with a large existing library?

Blank user page after update

I have updated recently from v2.3.1 by deleting anything but images/thumbs/config.php and copying new ones from v2.3.3.zip.
The issue is when I successfully login "My account" page goes blank.

Better view for tag_editcloud?

When i add tags for image from tag_editcloud too long, my eyes like X_X ... XD.... broke , maybe you can add "+A / -A" for increase and decrease tags size in the editcloud? While I use Ctrl+/- in browser. But this is not main idea.

I'll be happy if you do:
Between the lines in alphabetical order for editcloud add separator like "---" or an empty string after each character block? I think that it will be better for viewing and fast search in large tag_editcloud.
Like:
A ( or ---, or empty line string, or "from new string")
after another antro algo alter ....
B ( or ---, or empty line string, or "from new string")
big boom bloom bleach ....
C ( or ---, or empty line string, or "from new string")
critical crown ....
is it possible?

For me better if that will be like empty string or "from new string". RU characters in ....index.php?q=/tags/alphabetic not working.

Request: Export all images tool

Just a simple admin tool to export all images.
Should do something along the lines of:
Copies all images to seperate folder > adds ext back to file name > zips images.

Negative tags not working on their own.

As title says, negative tags only seem to work while using them with other tags (I.E: wallpaper -dualscreen).
So instead of: Search database for wallpaper > remove anything containing dualscreen.
You get: Get Database > remove anything containing dualscreen.

event log ip search postgres

it doesn't the working

HDD Migration Duplicate Hash Error Problem

Shimmie was originally installed on HDD D:, then was migrated to C: after a while.
After that, an issue surfaced: whenever uploading a duplicate file, instead of giving an
"Error with x.y Image n already has hash z"
error message with a thumbnail attached and a clickable link, instead it generates a
"Error with x.y Failed to copy file from uploads () to archive (images/m/z)"
style message. You still can find the original image by searching for "hash=Z" in the searchbox.
Very annoying, and persisted for as long as I know build-wise. No idea how to fix it properly outside of workarounds that replace the HDD copy error message with a makeshift imitation of the duplicate error with the thumbnail.

Oh and it affects only images uploaded BEFORE the migration. The error message for any duplicate image uploaded after the migration is the proper one.
The OS is Windows Server 2008.

Image Title

I would be interested in seeing a new option when uploading an image, a title. I use Shimmie2 for a personal site and some of the photographs I upload have titles such as a project name. As not every image needs this, I think it should be an optional field for the photo, and probably implemented as an extension, not in the core.

Thoughts on the subject would be appreciated.

Thanks for all the hard work already, love the software.

Blotter SQL Error

Enabling the blotter extension on 2.3.5 gives me the following error on every page load:
mysql error: [1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ':lim5' at line 1] in EXECUTE("SELECT * FROM blotter ORDER BY id DESC LIMIT :lim5")
running mysql 5.5.16 and php 5.3.8

installer needs more PDO

it hasn't been transitioned yet

Disk nearly full, uploads disabled

Disk nearly full, uploads disabled

go to upload and see:
No handler could be found for the page 'upload'

but disk not nearly full

HDD Migration Duplicate Hash Error Problem

Shimmie was originally installed on HDD D:, then was migrated to C: after a while.
After that, an issue surfaced: whenever uploading a duplicate file, instead of giving an
"Error with x.y
Image n already has hash z"
error message with a thumbnail attached and a clickable link, instead it generates a
"Error with x.y
Failed to copy file from uploads () to archive (images/m/z)"
style message. You still can find the original image by searching for "hash=Z" in the searchbox.
Very annoying, and persisted for as long as I know build-wise. No idea how to fix it properly outside of workarounds that replace the HDD copy error message with a makeshift imitation of the duplicate error with the thumbnail.

Oh and it affects only images uploaded BEFORE the migration. The error message for any duplicate image uploaded after the migration is the proper one.
The OS is Windows Server 2008.

Upload bookmarklet link wrong in 2.3

See https://github.com/shish/shimmie2/blob/branch_2.3/ext/upload/theme.php#L51

It's using make_link() and it should be using make_http().