Comments (6)
I have a hypothesis regarding this issue. I suspect that reusing the Socket instance might be causing some problem. Can you reproduce the issue with the following commit as well?
https://github.com/shogo4405/HaishinKit.swift/tree/feature/network-framework
There is a feature to output detailed logs for the Network framework. Please provide the logs using the following branch:
https://github.com/shogo4405/HaishinKit.swift/tree/feature/network-framework-logging
You can see the logs like this.
2024-13-07 01:31:47.986 [Info] [com.haishinkit.HaishinKit] [RTMPNWSocket.swift:162] viabilityDidChange(to:) > Optional(Establishment Report:
Duration: 10ms
Attempt Started After: 0ms
Previous Attempts: 0
tcp (0ms/0ms RTT)
Proxy not configured, not used, to unknown
Privacy stance: Not Eligible)
2024-13-07 01:31:47.992 [Info] [com.haishinkit.HaishinKit] [RTMPNWSocket.swift:130] doOutput(data:) > Data Transfer Report:
Duration: 0ms
Paths Used: 1
Interface: lo0[]
Application Bytes Sent: 293
Application Bytes Received: 0
Transport Bytes Sent: 293 (Retransmitted 0)
Transport Bytes Received: 0 (Duplicate 0, Out-of-Order 0)
Transport RTT: 1ms (Minimum 2ms, Variance 1ms)
Transport Congestion Window: 133998
Transport Slow Start Threshold: 1073725440
IP Packets Sent: 3
IP Packets Received: 0
2024-13-07 01:31:47.992 [Info] [com.haishinkit.HaishinKit] [RTMPNWSocket.swift:130] doOutput(data:) > Data Transfer Report:
Duration: 0ms
Paths Used: 1
Interface: lo0[]
Application Bytes Sent: 153
Application Bytes Received: 0
Transport Bytes Sent: 153 (Retransmitted 0)
Transport Bytes Received: 0 (Duplicate 0, Out-of-Order 0)
Transport RTT: 1ms (Minimum 2ms, Variance 0ms)
Transport Congestion Window: 134022
Transport Slow Start Threshold: 1073725440
IP Packets Sent: 2
IP Packets Received: 0
from haishinkit.swift.
Unfortunately, I couldn't reproduce it in my environment, so I'm having difficulty finding a solution. I'm considering trying it in a different environment. How about others?
from haishinkit.swift.
I am still able to reliably reproduce this issue. In my case, I don't think I'm seeing any transfer speed at all after the reconnect.
In order to work around this problem, I have had to implement my own reconnect strategy. In my implementation, when a disconnect happens, but then connectivity is restored, in order to successfully reconnect I am forced to perform the following:
- close the connection on the RTMPStream object
- nil out the RTMPStream and RTMPConnection objects
- Initialize new RTMPStream and RTMPConnection objects
- connect and publish using the same URL and stream name as the previous stream
Following this pattern, I am able to reliably reconnect and keep data flowing from the client to server. However this is not ideal, as nilling out the RTMPStream and RTMPConnection objects means I am not able to keep local recording active through a disconnection event. Ideally I would like to keep an uninterrupted local recording that runs even while a disconnect/reconnect of the RTMP stream occurs.
If I instead attempt to connect and publish again on the same RTMPConnection and RTMPStream objects (the same way the HaishinKit example project handles reconnects), I will run into the bug as described by this thread. HaishinKit will log NetConnection.Connect.Success
, but after this point no data will reach the server. Logging the RTMPConnection's currentBytesOutPerSecond
value shows 0
, confirming that no data is being sent.
In my testing, the repro path I follow involves a phone that is connected to both cellular (typically 5G) as well as Wifi. If I start the broadcast, then shortly after that open control center and disable wifi, the bug is noticed pretty much immediately. I've also tested by walking out of range of the Wifi signal. The phone is still connected through cellular, and HaishinKit will very quickly log that the following connection was a success, but no data gets sent.
However, if I perform another test in which I keep the phone in airplane mode with no cellular connection, and I simply disable and re-enable wifi, it seems the reconnect can work successfully in that case. The issue seems to be something specific about switching between wifi and cellular, which seems to align with the issue as described in this GitHub issue post.
I have attached a log file from a test I ran on the haishin kit example project. In the test I included the RTMPConnectionDelegate
code as outlined in original post of this issue thread.
Please let me know if there are any other details I can provide, or any additional tests I can perform on my environment with this reliable repro path to gain further insight. I would love to find a resolution for this issue so that I can support local recording throughout a disconnection/reconnection event.
Thank you
2024-08-07_haishinKit_reconnect_bug_log.txt
from haishinkit.swift.
I've tested the feature/network-framework
branch, and I believe I was still able to reproduce the same issue.
In my test, I ran the Example iOS + SwiftUI project on an iPhone 15 Pro Max on iOS 17.5.1.
I had the Preference
file configured to set the uri and stream name to use our video service, Mux.
I then ran the app and started broadcasting. After about 12 seconds, I disabled Wifi from Control Center. Depending on signal, my phone will then attempt to use either 5G or LTE provided by Verizon. The example app attempts to reconnect, but the result is that the currentBytesOutPerSecond
seems to still get stuck at 0.
Logs from that attempt are here:
haishinKit-swiftUI-demo-trace-network-framework-wifi-to-cellular.txt
I then tested feature/network-framework-logging
and performed the same test. The result was the same.
In this log file, we can observe the Wifi connection is no longer available at line 16086.
Then, we see Connection viability changed to true
on line 16111.
After this point, the network logging shows the interface has been changed from en0[]
(I believe this is Wifi) to pdp_ip0[lte]
(LTE)
haishinKit-network-logging-wifi-to-cellular.txt
In both tests, I did include the RTMPConnectionDelegate
code shown at the initial post of this issue, and set the RTMPConnection delegate to self
(referencing ViewModel from the SwiftUI example).
Near the end of both log files we see a repeating line:
sufficientBW 640000 64000 0
This is the log message added in the RTMPConnectionDelegate
, and it is showing how our current bytes out is showing data is no longer sending correctly after the transition form Wifi to cellular.
Please let me know if there are any additional tests I can perform to help diagnose the issue.
Thank you
from haishinkit.swift.
@jhays
Thank! I checked the log file haishinKit-swiftUI-demo-trace-network-framework-wifi-to-cellular.txt.
CONNECT
C -> S [COMMAND] publish
S -> C [USER] stream begin
S -> C [COMMAND] onStatus -> NetStream.Publish.Start
RECONNECT
C -> S [COMMAND] publish
S -> C NO RESPONSE
HaishinKit expects a response from the server to establish the Publish. Since there is no response from the server, it remains in an Idle state, as seen in the logs.
Due to the lack of server response, the client cannot determine whether to continue sending data. It's natural that currentBytesOutPerSecond = 0 since no data is being sent from the client.
Cause
It's likely that the server is attempting to reconnect at a time when it hasn't detected the client's communication interruption. Due to improper handling of this situation, it remains in an Idle state.
In cases like nginx + rtmp module, errors like NetStream.Publish.BadName might be returned.
Solutions
Solution 1
- Introduce a wait period during reconnect attempts.
Solution 2
- Monitor the NetStream.Publish.Start event before publishing.
- If NetStream.Publish.Start isn't received within a certain period, initiate a reconnect.
Solution 3
- Emulate the same sequence as FMLE encoder, which might handle disconnections properly by cutting off the previous connection.
Example: stream = RTMPStream(connection, fcPublishName: streamName)
from haishinkit.swift.
Thank you for the info.
I will investigate your proposed solutions soon!
from haishinkit.swift.
Related Issues (20)
- Exception "required condition is false: [_nodes containsObject: node]" when I close RTMP stream connection HOT 6
- LTE and 5G Network Connection Failure: POSIXErrorCode(rawValue: 50): Network is down HOT 4
- Change resolution during stream HOT 4
- Recording not working since 1.8.0 HOT 3
- connection closed by peer on stopping the RTMP stream HOT 6
- [Sponsorship] Need Help with New Features HOT 1
- [SRT] After `SRTConnection.close` `SRTConnection.connected` is true
- [SRT] After fist live audio does not have a program
- Black screen at the trailing HOT 1
- NetConnection.Connect.Failed when I use RTMP stream with H264
- [Bug Maybe] Feedback for 1.8.0 and 1.8.2 HOT 5
- SRT no video track HOT 2
- Missing required module 'SwiftPMSupport' HOT 5
- Offscreen Rendering issue with some PNG formats HOT 3
- Undefined symbols for VisionPro HOT 3
- Low quality camera image HOT 6
- Issue with Live Streaming URL HOT 1
- Xcode15.4+, High CPU Usage and Increse Memory with SPM HOT 21
- IOStream's method append(_ sampleBuffer:) not work as expected HOT 1
- Every FLV frame has key type HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from haishinkit.swift.