shopgate/theme-gmd

Shopgate's Google Material theme.

Google Material Design theme for the Shopgate Connect PWA

About Shopgate

Shopgate is the leading mobile commerce platform.

Shopgate offers everything online retailers need to be successful in mobile. Our leading software-as-a-service (SaaS) enables online stores to easily create, maintain and optimize native apps and mobile websites for the iPhone, iPad, Android smartphones and tablets.

License

Google Material Design theme for the Shopgate Connect PWA is available under the Apache License, Version 2.0.

See the LICENSE.md file for more information.

theme-gmd's Issues

category view can't be loaded

I updated the platform-sdk to 1.2.2 and use the latest master (260ef7d) which is also the latest tag 4..0.1 and when I want to access a category I get this error in my chrome console:

arning: Failed prop type: Invalid prop `id` of type `number` supplied to `Portal`, expected `string`.
    in Portal (at index.jsx:47)
    in Item (at index.jsx:27)
    in li (created by GridItem)
    in GridItem (at index.jsx:20)
    in ul (created by Grid)
    in Grid (at index.jsx:19)
    in div
    in div (created by InfiniteContainer)
    in InfiniteContainer (at index.jsx:38)
    in ProductGrid (at index.jsx:155)
    in div (at index.jsx:154)
    in div (at index.jsx:152)
    in Products (created by Connect(Products))
    in Connect(Products) (at index.jsx:64)
    in article (at index.jsx:187)
    in div (created by Swipeable)
    in Swipeable (at index.jsx:182)
    in section (at index.jsx:181)
    in View (created by Connect(View))
    in Connect(View) (at index.jsx:61)
    in Category (created by Connect(Category))
    in Connect(Category) (created by RouteContent)
    in div (created by RouteContent)
    in RouteContent
    in div
    in Route (at index.jsx:66)
    in main (at index.jsx:20)
    in Viewport (at index.jsx:60)
    in Router
    in I18nProvider
    in Provider
    in App (at index.jsx:59)
    in Pages (at index.jsx:28)
    in AppContainer (at index.jsx:27)
printWarning @ warning.js?d66c:20
warning @ warning.js?d66c:50
checkPropTypes @ checkPropTypes.js?9ed7:48
validatePropTypes @ react.development.js?b5ba:1162
createElementWithValidation @ react.development.js?b5ba:1259
patchedCreateElement @ patch.dev.js?661c:188
Item @ index.jsx?bff0:30
instantiate @ createClassProxy.js?efa3:78
Item @ VM7284:4
mountIndeterminateComponent @ react-dom.development.js?5582:8014
beginWork @ react-dom.development.js?5582:8212
performUnitOfWork @ react-dom.development.js?5582:10219
workLoop @ react-dom.development.js?5582:10287
callCallback @ react-dom.development.js?5582:541
invokeGuardedCallbackDev @ react-dom.development.js?5582:579
invokeGuardedCallback @ react-dom.development.js?5582:437
renderRoot @ react-dom.development.js?5582:10355
performWorkOnRoot @ react-dom.development.js?5582:11010
performWork @ react-dom.development.js?5582:10959
requestWork @ react-dom.development.js?5582:10877
scheduleWorkImpl @ react-dom.development.js?5582:10719
scheduleWork @ react-dom.development.js?5582:10682
enqueueSetState @ react-dom.development.js?5582:6193
Component.setState @ react.development.js?b5ba:235
onStateChange @ connectAdvanced.js?3a83:195
onStateChange @ createPrototypeProxy.js?ced7:42
dispatch @ createStore.js?f75a:150
(anonymous) @ redux-logger.js?c379:1
(anonymous) @ observable-middleware.js?417a:24
(anonymous) @ index.js?f838:1
dispatch @ applyMiddleware.js?296a:21
(anonymous) @ getProducts.js?ff14:154
Promise.then (async)
(anonymous) @ getProducts.js?ff14:137
(anonymous) @ index.js?f838:1
dispatch @ applyMiddleware.js?296a:21
(anonymous) @ fetchCategoryProducts.js?7e6d:28
(anonymous) @ index.js?f838:1
dispatch @ applyMiddleware.js?296a:21
(anonymous) @ getProducts.js?23f7:19
(anonymous) @ index.js?f838:1
getProducts @ connector.js?8b6b:28
componentDidMount @ index.js?ab9a:101
proxiedComponentDidMount @ createPrototypeProxy.js?ced7:63
commitLifeCycles @ react-dom.development.js?5582:8737
commitAllLifeCycles @ react-dom.development.js?5582:9913
callCallback @ react-dom.development.js?5582:541
invokeGuardedCallbackDev @ react-dom.development.js?5582:579
invokeGuardedCallback @ react-dom.development.js?5582:437
commitRoot @ react-dom.development.js?5582:10044
performWorkOnRoot @ react-dom.development.js?5582:11017
performWork @ react-dom.development.js?5582:10959
batchedUpdates @ react-dom.development.js?5582:11078
batchedUpdates @ react-dom.development.js?5582:2326
dispatchEvent @ react-dom.development.js?5582:3421
invariant.js?bdf9:22 Uncaught Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
    at invariant (invariant.js?bdf9:22)
    at createFiberFromElement (react-dom.development.js?5582:5740)
    at createChild (react-dom.development.js?5582:6962)
    at reconcileChildrenArray (react-dom.development.js?5582:7281)
    at reconcileChildFibers (react-dom.development.js?5582:7630)
    at reconcileChildrenAtExpirationTime (react-dom.development.js?5582:7756)
    at reconcileChildren (react-dom.development.js?5582:7746)
    at finishClassComponent (react-dom.development.js?5582:7880)
    at updateClassComponent (react-dom.development.js?5582:7846)
    at beginWork (react-dom.development.js?5582:8212)
invariant @ invariant.js?bdf9:22
createFiberFromElement @ react-dom.development.js?5582:5740
createChild @ react-dom.development.js?5582:6962
reconcileChildrenArray @ react-dom.development.js?5582:7281
reconcileChildFibers @ react-dom.development.js?5582:7630
reconcileChildrenAtExpirationTime @ react-dom.development.js?5582:7756
reconcileChildren @ react-dom.development.js?5582:7746
finishClassComponent @ react-dom.development.js?5582:7880
updateClassComponent @ react-dom.development.js?5582:7846
beginWork @ react-dom.development.js?5582:8212
performUnitOfWork @ react-dom.development.js?5582:10219
workLoop @ react-dom.development.js?5582:10287
callCallback @ react-dom.development.js?5582:541
invokeGuardedCallbackDev @ react-dom.development.js?5582:579
invokeGuardedCallback @ react-dom.development.js?5582:437
renderRoot @ react-dom.development.js?5582:10355
performWorkOnRoot @ react-dom.development.js?5582:11010
performWork @ react-dom.development.js?5582:10959
requestWork @ react-dom.development.js?5582:10877
scheduleWorkImpl @ react-dom.development.js?5582:10719
scheduleWork @ react-dom.development.js?5582:10682
enqueueSetState @ react-dom.development.js?5582:6193
Component.setState @ react.development.js?b5ba:235
onStateChange @ connectAdvanced.js?3a83:195
onStateChange @ createPrototypeProxy.js?ced7:42
dispatch @ createStore.js?f75a:150
(anonymous) @ redux-logger.js?c379:1
(anonymous) @ observable-middleware.js?417a:24
(anonymous) @ index.js?f838:1
dispatch @ applyMiddleware.js?296a:21
(anonymous) @ getProducts.js?ff14:154
Promise.then (async)
(anonymous) @ getProducts.js?ff14:137
(anonymous) @ index.js?f838:1
dispatch @ applyMiddleware.js?296a:21
(anonymous) @ fetchCategoryProducts.js?7e6d:28
(anonymous) @ index.js?f838:1
dispatch @ applyMiddleware.js?296a:21
(anonymous) @ getProducts.js?23f7:19
(anonymous) @ index.js?f838:1
getProducts @ connector.js?8b6b:28
componentDidMount @ index.js?ab9a:101
proxiedComponentDidMount @ createPrototypeProxy.js?ced7:63
commitLifeCycles @ react-dom.development.js?5582:8737
commitAllLifeCycles @ react-dom.development.js?5582:9913
callCallback @ react-dom.development.js?5582:541
invokeGuardedCallbackDev @ react-dom.development.js?5582:579
invokeGuardedCallback @ react-dom.development.js?5582:437
commitRoot @ react-dom.development.js?5582:10044
performWorkOnRoot @ react-dom.development.js?5582:11017
performWork @ react-dom.development.js?5582:10959
batchedUpdates @ react-dom.development.js?5582:11078
batchedUpdates @ react-dom.development.js?5582:2326
dispatchEvent @ react-dom.development.js?5582:3421
react-dom.development.js?5582:9747 The above error occurred in the <Portal> component:
    in Portal (at index.jsx:47)
    in div (at index.jsx:46)
    in div
    in Link (at index.jsx:31)
    in Item (at index.jsx:27)
    in li (created by GridItem)
    in GridItem (at index.jsx:20)
    in ul (created by Grid)
    in Grid (at index.jsx:19)
    in div
    in div (created by InfiniteContainer)
    in InfiniteContainer (at index.jsx:38)
    in ProductGrid (at index.jsx:155)
    in div (at index.jsx:154)
    in div (at index.jsx:152)
    in Products (created by Connect(Products))
    in Connect(Products) (at index.jsx:64)
    in article (at index.jsx:187)
    in div (created by Swipeable)
    in Swipeable (at index.jsx:182)
    in section (at index.jsx:181)
    in View (created by Connect(View))
    in Connect(View) (at index.jsx:61)
    in Category (created by Connect(Category))
    in Connect(Category) (created by RouteContent)
    in div (created by RouteContent)
    in RouteContent
    in div
    in Route (at index.jsx:66)
    in main (at index.jsx:20)
    in Viewport (at index.jsx:60)
    in Router
    in I18nProvider
    in Provider
    in App (at index.jsx:59)
    in Pages (at index.jsx:28)
    in AppContainer (at index.jsx:27)

Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://fb.me/react-error-boundaries to learn more about error boundaries.

Update: The page is just white and nothing is displayed

No possibility to adjust markup in SuggestionList component

Currently it is not possibly to add more markup to a SuggestionList component (only title of product / string), only a string which is rendered as-is. React escapes the string. Maybe some portals might be useful there. And some way to allow rendering HTML.

theme-gmd/components/Search/components/Suggestions/components/List/index.jsx

Line 48 in 19e981a

{suggestion}

Errors in navigating between product and the cart views.

It seems that I was able to get into an infinite loop of action setViewTitle

action SET_VIEW_TITLE @ 13:59:46.221 (in 0.34 ms)
index.js:90  prev state {cart: {…}, category: {…}, client: {…}, favorites: {…}, filter: {…}, …}
index.js:90  action     {type: "SET_VIEW_TITLE", title: "Cart"}
index.js:90  next state {cart: {…}, category: {…}, client: {…}, favorites: {…}, filter: {…}, …}

That followed a lot of errors like this:

Uncaught Error: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.
    at invariant (invariant.js:42)
    at requestWork (react-dom.development.js:10833)
    at scheduleWorkImpl (react-dom.development.js:10732)
    at scheduleWork (react-dom.development.js:10689)
    at Object.enqueueSetState (react-dom.development.js:6212)
    at Cart.me6n.Component.setState (react.development.js:237)
    at Cart.__onSize__REACT_HOT_LOADER__ (index.jsx:57)
    at Cart.__onSize__REACT_HOT_LOADER__ (createPrototypeProxy.js:44)
    at Object.Cart._this.onSize (index.jsx:43)
    at ProxyComponent.SizeAwareComponent._this2.strategisedSetState (sizeMe.js:247)

What I did was:

• added product to the cart
• went to cart
• updated quantity in the cart
• went back to the same product
• added the same product again
• tried to go to the cart and the issue appeared, leaving me with not so sensible waiting time, but showed the cart at the end.

Hope you have enough info to improve the things.