shtakai/a-jamming-aka-mc-jammar

SPA using spotify API url is https://osashimi-tabetaina.surge.sh/

a-jamming-aka-mc-jammar's Issues

Ensure playlist information doesn't get cleared if a user has to refresh their access token

Only display songs not currently present in the playlist in the search results

After adding to playlist, this track is not shown on search result.
It has been already implemented.

video

Pressing enter triggers a search

On search box,

• Watch pressing enter key.
• Emit search function if ↑.
• Display search results same same clicking Search button.

Project Review: Summary

Rubric Score

Criteria 1: App Creation, Folder Structure, and File Paths

• Score Level: 4/4
• Comment(s): Overall the folder structure/file paths used looks great. All of the components are properly organized and imported/exported 👍

Criteria 2: Correct Implementation of User Flows (e.g. Searching, Token Generation, Save Playlist, etc.)

• Score Level: 4/4
• Comment(s): I can't specifically test the user flows myself without the config file, though the code itself looks pretty much perfect with respect to the solution code. All of the components to be rendered are in the right places and your Spotify.js looks great as well. Promises are handled appropriately and token generation should work appropriately here.

Criteria 3: Proper JavaScript and JSX Syntax and Formatting

• Score Level: 4/4
• Comment(s): Awesome work with the overall formatting/syntax throughout your Project as well. You've done well in keeping class methods short and to the point, including render methods. You've also kept things DRY (not repeating yourself) throughout the components/util as well. Nice work!

Criteria 4: Implementation Adheres to DRY Principles

• Score Level: 4/4
• Comment(s): See above ☝️

Overall Score: 16/16 🔥 🔥

Awesome work with this one! Project is pretty much spot on with respect to the solution/specification.

Update the access token logic to expire at exactly the right time, instead of setting expiration from when the user initiates their next search

idea

• set expiration datetime to sessionStorage.

Add a loading screen while playlist is saving

• When SAVE TO SPOTIFY clicked,
• On starting saving, the button is disabled.
• After saving is finished, the button is enabled.
• Display spin on loading.
• Disappear spin after loading.

1. started saving

2. finished saving

After user redirect on login, restoring the search term from before the redirect

Just using localStorage.

• Saving search term to localStorage.
• Rediredt on login, retroring the search term from before the redirect.

Include preview samples for each track

• Can grab preview.
• On the search result side, show preview sample image on each track.
• But we don't need to show preview on new play list.

Like this ↓

↓ Show play list side.

Feature Request Review

Was looking for a link to a Google Doc for your feature request but saw a short text file instead.
It looked like it got caught off halfway as it only showed up to 21 lines?
Will be looking forward to a full implementation and write up of your feature request!