siddhantgoel/beancount-ing

Beancount Importers for ING (Germany) CSV Exports

>>> import this
The Zen of Python, by Tim Peters

Beautiful is better than ugly.
Explicit is better than implicit.
Simple is better than complex.
Complex is better than complicated.
Flat is better than nested.
Sparse is better than dense.
Readability counts.
Special cases aren't special enough to break the rules.
Although practicality beats purity.
Errors should never pass silently.
Unless explicitly silenced.
In the face of ambiguity, refuse the temptation to guess.
There should be one-- and preferably only one --obvious way to do it.
Although that way may not be obvious at first unless you're Dutch.
Now is better than never.
Although never is often better than *right* now.
If the implementation is hard to explain, it's a bad idea.
If the implementation is easy to explain, it may be a good idea.
Namespaces are one honking great idea -- let's do more of those!

beancount-ing's Issues

Add Github topics to the repository

Hi, can you add the following topic to this repository?

• https://github.com/topics/ing-diba

Thanks!

Support CSV exports without Balance amounts

Sometimes the Balance (Saldo) amount is missing from the CSV exports, but the ECImporter expects it to be there.

The "Saldo" metadata entry should be made optional.

Unexpected sorting info line

Hi,

my ING CSV exports contain a header line that says something about sort order.

...
Saldo;XX,XX;EUR

Sortierung;Datum absteigend   <= HERE

In der CSV-Datei finden Sie alle bereits gebuchten Umsätze. Die vorgemerkten Umsätze werden nicht aufgenommen, auch wenn sie in Ihrem Internetbanking angezeigt werden.
...

This line seems to be unexpected in your importer.
https://github.com/siddhantgoel/beancount-ing-diba/blob/5a23c2bcf23cf7d69232d10c3786a42d89ea5b59/beancount_ing_diba/ec.py#L171-L179
Could you please check this?

Thanks and regards
Fred

Initial Update

The bot created this issue to inform you that pyup.io has been set up on this repo.
Once you have closed it, the bot will open pull requests for updates as soon as they are available.

How to use it exactly

Sorry for bothering you with the maybe simple question but I've just started to use beancount and its documentation about importers does not help me much. In the usage section of your importer project, you just posted a small python script which contains an import and an example configuration array. But I don't know where to put this file and it does not tell me how it is executed.

Could you clarify this eventually?

Thank you in advance.

Category not represented

Hi,

For me the importer only worked after I added the "Category" field. I think it's only active if you activated the "Analyse" as a user. Would be nice to have the option to activate/deactivate it.

Moreover, it's possible to download CSVs that don't have a Balance (Saldo), but this importer expects it to be there. Would be nice to mention this in the docs.

User name restricted to two words

There seems to be a bug with user names, that consist of more than two words (first name + last name). See error output below. There should not be any restriction in this regard in order to make the package usable for everyone.

ERROR:root:Importer beancount_ing_diba.ec.ECImporter.extract() raised an unexpected error: too many values to unpack (expected 9)
Traceback (most recent call last):
  File "/Users/USERNAME/.virtualenvs/ENV/lib/python3.8/site-packages/beancount/ingest/extract.py", line 182, in extract
    new_entries = extract_from_file(
  File "/Users/USERNAME/.virtualenvs/ENV/lib/python3.8/site-packages/beancount/ingest/extract.py", line 67, in extract_from_file
    new_entries = importer.extract(file, **kwargs)
  File "/Users/USERNAME/.virtualenvs/ENV/lib/python3.8/site-packages/beancount_ing_diba/ec.py", line 210, in extract
    (
ValueError: too many values to unpack (expected 9)

When the name is reduced to two words (which does not match the name associated with the bank account in my case), the script runs through and gives the following output:
;; -*- mode: beancount -*-

Any chance, you can fix this soon?

Thanks for the great work!