Improve the `CurrentAttributes` module

[qblanc]

Improve the `CurrentAttributes` module

[mperham]

As object hydration can often raise an error or require the database, this is something out of Sidekiq’s responsibilities IMO. I advise people to use lazy accessors which load the object on demand. Save user_id as an attribute so only the id is persisted to the job.

[mperham]

1. Already the default. This adds the client middleware in all environments:

sidekiq/lib/sidekiq/middleware/current_attributes.rb

Lines 69 to 74 in 73c150d

	def persist(klass_or_array, config = Sidekiq.default_configuration)
	cattrs = build_cattrs_hash(klass_or_array)
	config.client_middleware.add Save, cattrs
	config.server_middleware.add Load, cattrs
	end

2. Sounds intriguing but I'm not sure what that entails. I'd be happy to get a PR or discuss more.

[qblanc]

Thanks for the answer !

1. Sorry I got confused by the config.client_middleware, I didn't knew the Sidekiq.default_configuration was configuring both server and client side at the same time
2. Our problem is that we are using Current to pass along objects (for instance Current.agent) and the current implementation is serializing with to_s, thus serializing the name of the object rather than the whole object or the id at least. On the server side, the Load method is recreating a Current.agent that is not the previous Current.agent but only a string. Maybe it is bad practice to use Current with records, but the doc is actually taking such an example (Current.user). It would be cool if the module was able to pass along objects/records rather than just strings (unless I only didn't understood how to do it 😬)

[qblanc]

Alright, I get the point. Thanks for the insight