siegeengineers/aoc-reference-data

Reference data for Age of Empires II projects.

aoc-reference-data

Reference data for Age of Empires II projects.

Contents

• Events
• Players
• Teams
• RMS packs
• Platforms
• Datasets
• Constants

Contributing

Most data changes rarely. However, the player data needs to be consistently updated. Assistance would be welcomed.

Player Notability

Only notable players for games of the Age of Empires franchise may be added. Notability is defined as meeting at least one of the following criteria:

1. Has a notable player page on the Age of Empires Liquipedia.
2. Was ever a top 200 player listed on Aoe Tournament Elo.
3. Was ever a top 250 player on the primary competitive 1v1 ladder for at least one month while actively playing.
4. Is a Twitch Partner and primarily streams a game of the Age of Empires franchise.

Other players may be added based on the maintainer's discretion for the benefit of the community at large.

Team Notability

Only notable teams may be added. A team is notable if it has at least one player meeting any of the first three player notability requirements.

Sources

Team data and some player social link data comes from Liquipedia.

aoc-reference-data's Issues

Unique constraint for `id: 613` failed

- name: Ny4JyN
  country: br
  platforms:
    rl:
      - '2429762'
  id: 613

- name: TeMo
  country: ma
  platforms:
    rl:
      - '6815493'
      - '12059289'
      - '14910497'
      - '14650521'
      - '15345163'
  id: 613
  aoeelo: 1322

Probable misattributed account for Dragonstar

aoc-reference-data/data/players.yaml

Line 2226 in 446d6f9

- "5242781"

Use the `liquipedia` player property and the Liquipedia API to generate unique identifiers for players<->teams

Ideally we use the liquipedia player property and the Liquipedia API to write a script that automatically generates this file.

Originally posted by @happyleavesaoc in #33 (comment)

Regarding: a small script that enumerates the players in the players.yaml and put in a unique ID in teams.json for referencing players

Add CI

This assumes that our standard workflow is always creating PRs also from bots and lock the master (main) branch against modifications.

What we could check for:

• Doublettes being added (check for doubles from fields like liquipedia, Platforms->DE and Platforms->Voobly ids, name, aoeelo)
  • basically index those fields and throw an error if values already exists in the file
• item IDs not being reused, kept unique (done in #107)
• Probably implicit, but also valid YAML (done in #109)
• Valid ISO 3166-1 alpha-2 country code
  • https://pypi.org/project/pycountry/
  • https://pypi.org/project/iso3166/
• other stuff (additions?)

Unique constraint for `id: 594` failed

- name: Dooidy
  country: cn
  platforms:
    rl:
      - '2594552'
  id: 594
  aoeelo: 1144

- name: Terz
  country: de
  aoeelo: 1066
  platforms:
    rl:
      - '573282'
      - '15465466'
  discord_id: Terz#8397
  id: 594
  liquipedia: Terz
  twitch:
    - https://www.twitch.tv/terz_aoe
  team: 22

Remove 404 links from CI link checker output

Summary

Status	Count
🔍 Total	633
✅ Successful	621
⏳ Timeouts	0
🔀 Redirected	0
👻 Excluded	0
❓ Unknown	0
🚫 Errors	12

Errors per input

Errors in data/platforms.json

• https://www.ageofempires.com/stats/match-details/: Failed: HTTP status client error (404 Not Found) for url (https://www.ageofempires.com/ageofempires/stats)
• http://www.vooblycn.com/match/view/: Failed: HTTP status client error (404 Not Found) for url (https://www.vooblycn.com/match/view/)

Errors in data/players.yaml

• https://www.youtube.com/BKPaganini: Failed: HTTP status client error (404 Not Found) for url (https://www.youtube.com/BKPaganini)
• https://www.youtube.com/@mihai06-ageofempires25: Failed: HTTP status client error (404 Not Found) for url (https://www.youtube.com/@mihai06-ageofempires25)
• https://www.youtube.com/UCNCY4gGtk099xAm1CYKm2eQ: Failed: HTTP status client error (404 Not Found) for url (https://www.youtube.com/UCNCY4gGtk099xAm1CYKm2eQ)
• https://kick.com/capoch: Failed: HTTP status client error (403 Forbidden) for url (https://kick.com/capoch)
• https://www.youtube.com/user/MrGamal100: Failed: HTTP status client error (404 Not Found) for url (https://www.youtube.com/user/MrGamal100)
• https://twitter.com/Gabi32996955: Failed: HTTP status client error (404 Not Found) for url (https://twitter.com/Gabi32996955)
• https://www.youtube.com/@annotophaoe2894: Failed: HTTP status client error (404 Not Found) for url (https://www.youtube.com/@annotophaoe2894)
• https://www.youtube.com/rayaoe: Failed: HTTP status client error (404 Not Found) for url (https://www.youtube.com/rayaoe)
• https://kick.com/dogaoaoe: Failed: HTTP status client error (403 Forbidden) for url (https://kick.com/dogaoaoe)
• https://www.youtube.com/c/maxiarg: Failed: HTTP status client error (404 Not Found) for url (https://www.youtube.com/c/maxiarg)

Full Github Actions output

Discussion: Criteria for Player inclusion

With a growing community and usage of this repository comes also the need for transparency on certain topics, that got handled internally before or were not really worth thinking about: What are our criteria to include players into the players.yaml file?

Misleading Ranking for players in the Leaderboard

I'm talking about Ertug. His account is clearly rank4 in EW ladder, but according to some rationale you decided it's best to not to display correctly in your service. Anyways it says Mr.Yo is rank4 there.

I don't know what is your reasoning behind this but this is clearly "misleading" and therefore it is immoral.

You may still don't want to put Ertug in the ladder but by doing so you are delibaretly misleading people, this is no joke. You can correct your mistake by allocating people to correct spots. (i. e. Mr. Yo to rank5 and so on).

CI: Check for `no` that is considered as a boolean by YAML spec

Regarding: 41e8502

We should check in our CI for using no anywhere as a boolean instead of a string.

See YAML spec: https://yaml.org/type/bool.html

y|Y|yes|Yes|YES|n|N|no|No|NO
|true|True|TRUE|false|False|FALSE
|on|On|ON|off|Off|OFF

All of these without quotes are considered booleans. Would probably make sense to try to parse e.g. the countries and other things as boolean and compare to fields that shouldn't contain/be a boolean.

Add corresponding preview pictures for community pages

There are still some previews that need to be added for new entries in #63

Unique constraint for `discord_id` failed

- name: A bao'
  country: vn
  platforms:
    rl:
      - "1743669"
    voobly:
      - "125010872"
  id: 400
  discord_id: Babaorum#3699

- name: Babaorum
  country: fr
  platforms:
    rl:
      - "576919"
      - "3335279"
    voobly:
      - "123145914"
  liquipedia: Babaorum
  twitch:
    - https://www.twitch.tv/babaorum_aoe
  aoeelo: 851
  id: 233
  discord_id: Babaorum#3699

Keep datasets automatically in sync with recent patches

https://github.com/SiegeEngineers/aoc-reference-data/blob/master/data/datasets/100.json
https://github.com/SiegeEngineers/aoc-reference-data/blob/master/data/datasets/1.json

Could we discuss a way here how we could keep these files automatically in sync with recent patch changes of AoE2DE?
It would be really cool to have easy access to these information to use for streaming overlays for example.

Or is there already a repository for this and I'm overlooking something?

Datalist for AoE related pages

Does it make sense to collect a list of all the different pages one can get information from like aoe2insights, aoe2techtree, aoe2recs, etc. with a description-field for the content and a tag? Maybe as an overview as in platforms.json and easy to parse for future chat commands for example?

Maybe like this(?):

name: String
url: String
description: String
tags: [ Array of Strings ]
preview-url: String
contact: String

preview-url could be a screenshot taken at a certain time, not sure if it's needed. Just an idea.
contact could be an eMail-Address or a link to a contact form, discord username (or others and more than one)

Return empty arrays explicitly

There are some cases in players.yaml where platforms is empty. I think it would be better to return an empty array explicitly (instead of using null) with [] for platforms: [] so we don't have to check for null but can threat it like an array immediately.

Use json for players

I think json is easier to consume by clients than yaml, so I would like to change the players.yml to json. We can put the comments into a comment property like this:

- name: LaaaaaN
  country: es
  aoeelo: 62
  liquipedia: LaN
  esportsearnings: 56830
  aka:
    - LaN
  platforms:
    voobly:
      - "124116514" # ByT
      - "123989026" # Heresy
      - "124691590" # Jackie_Chan_
    rl:
      - "232410" # Antagonist
      - 196366-nac3 # Laaaaan
      - "1819193" # sheriff
      - "2602752"
      - "6892418"
  team: 21
  twitch:
    - https://www.twitch.tv/lan_aoe
  id: 8
  notability:
    aoe2: true
  discord_id: LaaaaaN#5576

becomes

{
    "name": "LaaaaaN",
    "country": "es",
    "aoeelo": 62,
    "liquipedia": "LaN",
    "esportsearnings": 56830,
    "aka": [
        "LaN"
    ],
    "platforms": {
        "voobly": [
            {id: "124116514", comment: 'ByT'},
            {id: "123989026", comment: 'Heresy'},
            {id: "124691590", comment: 'Jackie_Chan_'},
        ],
        "rl": [
            {id: "232410", comment: 'Antagonist'}
            {id: "196366-nac3", comment: 'Laaaaan'}
            {id: "1819193", comment: 'sheriff'}
            {id: "2602752"},
            {id: "6892418"},
        ]
    },
    "team": 21,
    "twitch": [
        "https://www.twitch.tv/lan_aoe"
    ],
    "id": 8,
    "notability": {
        "aoe2": true
    },
    "discord_id": "LaaaaaN#5576"
}

Add license to the repository

"When you make a creative work (which includes code), the work is under exclusive copyright by default. Unless you include a license that specifies otherwise, nobody else can copy, distribute, or modify your work without being at risk of take-downs, shake-downs, or litigation. Once the work has other contributors (each a copyright holder), “nobody” starts including you."

https://choosealicense.com/no-permission/

Would be nice if there would be a license added to this repository

Some Input for community_pages.yaml

Temporary collection for future additions:
https://github.com/Arkanosis/awesome-aoe2

I also asked in the following repository if it makes sense to centralize the data list and pull it in from this repository here.
https://github.com/collinstommy/aoe-library/blob/main/AOELibrary.csv

Tracking: collinstommy/aoe-library#2

Store relative path to player pictures in player object

There are some pictures in https://github.com/SiegeEngineers/aoc-reference-data/tree/master/data/photos/players it might be nice to store a relative path to the corresponding picture in the players.yaml file?