instruments in sidepanel use incorrect url

[signalk]

instruments in sidepanel use incorrect url

[panaaj]

This is the remaining feature where Freeboard behaviour is detecting the server type and using:
Node server = /webapps
Artemis server /signalk/v1/apps/list
urls to retrieve a list of webapps.

A request is sent to the appropriate url and the response expected to be consistent across servers...

The response is expected to have the following keys:

{ 
   name: ..., , 
   description: ... ,
   _location: ..., 
}

which are used to compile the target url as follows:

if(!_location) { url= `/` + name }
else { url= _location }

KIP entry returned by node-server looks like this... so you can see the "_location": "/@mxtommy/kip" is used for the url.

{
	"_from": "@mxtommy/[email protected]",
	"_id": "@mxtommy/[email protected]",
	"_inBundle": false,
	"_integrity": "sha512-NBJjKmpw34AHJOzxJlXoFVj8I/77vm+DAheJLAX74wAlTuzeLjBf8pIh2IWpw0XejHurApTahN6y5D8avXuOBw==",
	"_location": "/@mxtommy/kip",
        "name": "@mxtommy/kip",
        "description": "This is an instrumentation package to display signalK data. Display can be split up in any arrangement to show all data available on the server.",
	"_phantomChildren": {},
	"_requested": {
		"type": "version",
		"registry": true,
		"raw": "@mxtommy/[email protected]",
		"name": "@mxtommy/kip",
		"escapedName": "@mxtommy%2fkip",
		"scope": "@mxtommy",
		"rawSpec": "0.1.8",
		"saveSpec": null,
		"fetchSpec": "0.1.8"
	},  
        ....

Can you provide a sample of what Artemis server returns for KIP.

This is clearly a server behaviour that should be documented in the spec so consistent behavour is experienced by client applications.

[rob42]

Yes a spec addition is needed. I thought we already agreed on path signalk/v1/apps with list, search,install, remove. /webapps was just the early node custom implementation? I will make a PR for the spec.

I will alter my signalk/v1/apps/list to return:

{ 
   name: ..., , 
   description: ... ,
   _location: ..., 
}

[rob42]

Hmm, _location seems oddly named, location or href (which I have) seems better. Any idea why the _ ?
I will include both _location and href for now.

[rob42]

Artemis is now returning:

[{
	"_location": "../@mxtommy/kip/package/public/index.html",
	"licence": "",
	"author": "Thomas St.Pierre <[email protected]>",
	"name": "Kip",
	"description": "",
	"href": "../@mxtommy/kip/package/public/index.html",
	"repository": "https://github.com/npm/npm.git",
	"version": "0.1.8"
},
....
]

[rob42]

Thanks, it works!!
Closing now