Giter Site home page Giter Site logo

Comments (5)

haydentherapper avatar haydentherapper commented on July 18, 2024 1

re: LogId, I'm fine with removing OID because I don't think we'll move to CT 2.0 any time soon.

re: HashAlgorithm, one issue is we've hardcoded support for SHA256 all over the place. I think it'd be reasonable to keep the enum for HashAlgorithm in case we want to add additional algorithms in the future, but removing 512 now would be fine I think.

Is SignatureAlgorithm used anywhere currently? It doesn't seem like it, I think we can just delete the message.

from protobuf-specs.

kommendorkapten avatar kommendorkapten commented on July 18, 2024 1

The SignatureAlgorithm is not used, so it can be removed. There was first a tuple <signature algorithm, key encoding> but it was flattened to a list of permutations to avoid scenarios where invalid combinations was used. It just seems that the SignatureAlgorithm was not removed.

from protobuf-specs.

woodruffw avatar woodruffw commented on July 18, 2024

Is SignatureAlgorithm used anywhere currently? It doesn't seem like it, I think we can just delete the message.

Not that I can see either 🙂 -- maybe there's somewhere that should have it that's currently missing, although the only place I can think of it being relevant is in the certificates themselves (and those are opaque DER blobs to the protobuf layer).

from protobuf-specs.

woodruffw avatar woodruffw commented on July 18, 2024

Opened #39 for this -- I left SignatureAlgorithm in because I wasn't sure, but I addressed the other two.

from protobuf-specs.

woodruffw avatar woodruffw commented on July 18, 2024

Will remove now!

from protobuf-specs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.