filePicker does not work when file path contains non-ascii characters like German umlaut

[sihorton]

filePicker does not work when file path contains non-ascii characters like German umlaut

[sihorton]

The file picker is a bit of a hack to be honest. If I remember correctly it actually boots off a separate windows executable and passes in the parameters including a text file to write to. I have checked index.js and it does read and write in utf8 so my guess is that the executable itself is not writing the text file in utf-8 format.

[sihorton]

Just done some checking, the winfunc.nsi file is in the extension. http://nsis.sourceforge.net/Utf8Converter shows how to convert to utf8. Therefore we would need to update the following code:
FileOpen $5 "$OutPath" w
FileWrite $5 '$SelectedFile'
FileClose $5

To write out a UTF8 string instead (as it does now) an ascii string.

[lvbeck]

thanks a lot, I updated the winfunc.nsi script as follows and recompiled the winfunc.exe, it works now:

!include "Utf8Converter.nsh"
Var /GLOBAL SelectedFileUTF8    

${AnsiToUtf8} $SelectedFile $SelectedFileUTF8
FileOpen $5 "$OutPath" w
FileWrite $5 '$SelectedFileUTF8'
FileClose $5

[sihorton]

Great thanks a lot. Would you like to make the same change and submit a pull request for it? That way you get the credit you deserve for the fix

[lvbeck]

hi @sihorton, I can not find the deskshell-win-func module in the master branch anymore, is it deprecated?

[sihorton]

Ah I am sorry I moved it. Not by laptop right now will find correct place for you this afternoon.

[sihorton]

I moved it to the deskshell-showcase repository. My idea was to move anything custom or extra to that repository and then let people choose if they want to use it or not, so the files are now located:

https://github.com/sihorton/deskshell-showcase/tree/master/win-native-func/node_modules/deskshell-win-func

Thanks.