silug/cpanspec

Generate a spec file for a CPAN module

cpanspec's Issues

Deal with recent perl default removal of '.' from @INC

just need a definition in the %build section, harmless if perl doesn't remove '.'
(see: http://blogs.perl.org/users/todd_rinaldo/2016/11/what-happened-to-dot-in-inc.html)

Pretty sure that other 'build perl module' packages have this problem as well, but
when they fail I prefer to fall back to simpler tools like cpanspec.

diff -up ./cpanspec-1.78/cpanspec.orig ./cpanspec-1.78/cpanspec
--- ./cpanspec-1.78/cpanspec.orig 2020-12-26 10:40:41.443813026 -0500
+++ ./cpanspec-1.78/cpanspec 2020-12-26 10:42:08.183698533 -0500
@@ -1083,6 +1083,7 @@ END
print $spec <<END;

%build
+declare -x PERL_USE_UNSAFE_INC=1
END

 if ($usebuildpl) {

recommended packages should not be required

recommends EUMM entries get compiled into hard requirements.
This should not happen
See https://bugzilla.redhat.com/show_bug.cgi?id=552105

%files section with unneeded entries

Some modules don't have any /bin/ or /man3/ entries. The previous release didn't cause any troubles but the latest (taken from master branch) causes the spec file to include too many entries in the %files section, which causes rpmbuild to error out:

RPM build errors:
    File not found by glob: /home/rpmbuild/rpmbuild/BUILDROOT/perl-Mojolicious-Plugin-TtRenderer-1.56-1.el7.centos.x86_64/usr/bin/*
    File not found by glob: /home/rpmbuild/rpmbuild/BUILDROOT/perl-Mojolicious-Plugin-TtRenderer-1.56-1.el7.centos.x86_64/usr/share/man/man1/*

With latest version:

%files
%defattr(-,root,root,-)
%doc Changes cpanfile example LICENSE README
%{_bindir}/*
%{_mandir}/man1/*
%{perl_vendorlib}/*
%{_mandir}/man3/*

%changelog
- Specfile autogenerated by cpanspec 1.79.

And with the previous:

%files
%defattr(-,root,root,-)
%doc Changes cpanfile dist.ini example LICENSE META.json README
%{perl_vendorlib}/*
%{_mandir}/man3/*

%changelog
- Specfile autogenerated by cpanspec 1.78.

I didn't have time to investigate the issue further but will try to make a PR later this week if no fix is made meanwhile.