silverstripe/silverstripe-frameworktest

Silverstripe Framework Test

silverstripe-frameworktest's Issues

Generate content blocks for performance testing

Hook into the existing "generate pages" command?

Increase sample data to meet our NFRs

• FTPageMakerTask should output >10,000 pages, with at least one leaf node having >1000 pages.
• FTFileMakerTask should putput >10,000 files, with at least one folder having >1000 files.

When adding a new item on gridfield I get an error

I'm on feature-test-pages/gridfield/ (GridFieldTestPage) and I click the 'Add Company' button and get this error:

[User Error] Uncaught Exception: Object->__call(): the method 'push' does not exist on 'HTMLText'

Trace
Object->__call(push,Array)
GridFieldDetailForm.php:625
HTMLText->push(ArrayData)
GridFieldDetailForm.php:625
GridFieldDetailForm_ItemRequest->Breadcrumbs()
GridFieldDetailForm.php:363
GridFieldDetailForm_ItemRequest->ItemEditForm(GridField,SS_HTTPRequest)
GridFieldDetailForm.php:291
GridFieldDetailForm_ItemRequest->edit(SS_HTTPRequest)
RequestHandler.php:288
RequestHandler->handleAction(SS_HTTPRequest,edit)
RequestHandler.php:200
RequestHandler->handleRequest(SS_HTTPRequest,DataModel)
GridFieldDetailForm.php:93

Is there something wrong with the core gridfield code or is the this function which I think is creating the new company?

Company.php (line 83)
public function requireDefaultRecords() {
parent::requireDefaultRecords();
$companySet = DataObject::get('Company');
foreach ($companySet as $company) {
$company->delete();
}

    foreach($this->data() as $companyData){
        $company = new Company();
        $company->Name = $companyData[0];
        $company->Category = $companyData[1];
        $company->Revenue = $companyData[2];
        $company->CEO = $companyData[3];
        $company->write();
    }
    DB::alteration_message("Added default records to Company table","created");
}

Bring numbers of objects up to date with latest NFRs

The following updates will bring this module into line with our latest NFR's as specified here

This work will assist this the 'more realistic platform regression testing' issue here https://github.com/silverstripeltd/product-issues/issues/33

FTPageMakerTask.php

• 10,000 pages total, and at least one page with >200 child pages
• 5 levels of page hierarchy

TODO:
Hardcode to the following: (don't bother making configurable)

• 10 (was 5)
• 250 (was 100)
• 1
• 1
• 1

FTFileMakerTask.php

• 10,000 files, and at least one folder with >1000 files
• Files contain a variety of types, e.g. JPEGs with 2MB file size

TODO:

• change protected $folderCountByDepth to
  0 => 2,
  1 => 1, (was 2)
  2 => 2,
  3 => 2,
  4 => 2,

• change protected $fileCountByDepth to
  0 => 100,
  1 => 1001, (was 30)
  2 => 5,
  3 => 5,
  4 => 5

Company.php

• 10,000 objects (managed through ModelAdmin or GridField)

TODO:

• update data() to go from 216 companies to 10K
• simply that array and suffix '-01', '02' etc 50 times

TODO:
Also as a part of work, fix this issue at the same time #64

Add large sample data sets for all kitchen sink models

Not a complete list:

• Blog pages
• Tags

PHP 7.4 compatibility

There's a few instances of things like this

save function on TestPage_Controller referring to legacy code

function save calls Director::redirectBack(); when it should call $variable->redirectBack(); Unsure of the exact variable in this instance.

function save($data, $form) {
$form->saveInto($this->dataRecord);
$this->dataRecord->write();
Director::redirectBack();
}

Action 'Form' isn't allowed on class TestFileUploadPage_Controller.

Keep getting this message when making changes to these files but when I add allowed actions to the array it still doesn't work e.g.

private $allowed_actions = array(
'Form',
'Form/field/Companies/item/new', // or even if I add the whole url action
'Form/field/Companies/item/edit',
);

Reduce reliance on frameworktest for behat tests which require test extension classes

Behat tests can use TestOnly extensions. For an example of this, see silverstripe/silverstripe-elemental#930

There is likely some content in here that is intended for use in behat tests which can be implemented via Extension classes. We should evaluate to see if that's the case and migrate any such code into the relevant modules.

admin/test-react is broken

RelationFields / Tree / Search fields don't search

HasOnePageWithSearch and ManyManyPages (with search) fields on the RelationFields page no longer search through the items when you start typing the name or even if you have finished adding a name

Postgresql fails on dev build when framework test is installed

When frameworktest is installed and you're doing a fresh dev build, it will fail because it will try to run a query against a _Versions table that will not have been created yet.

HasOnePageWithSearch field returns html

See attached image, as soon as you click the field the correctly chosen item in the tree list appears.

v3.1 master with a default installation

First dev/build fails on changeset permissions

[Emergency] Uncaught LogicException: The current member does not have permission to publish this ChangeSet.

Remove update-js workflow

Update-js workflow breaks because there's no ci.yml file

This dev-only module is piled high with tech debt e.g. cannot yarn build, however it's a waste of time fixing this since this module is just auto-generated database records and some behat only php classes

Just rely on dependabot for this one

ACs

• Remove update-js workflow
• Update module-standardiser to exclude update-js from module-standardiser

Method 'sethasemptydefault' does not exist on 'ReadonlyField'

Viewing the basicfields page on SilverStripe 3.2 throws the following error:

This could actually be the module doing it's job...

Need to drop database before running dev/build

I installed this module on an existing project. I was unable to to run /dev/build?flush as I was shown the error
Unknown column 'SiteTree_Versions.RelationFieldsTestPageID' in 'field list'

The solution was to drop the database, create a new database, then run /dev/build?flush

Wrapper task to generate all available sample data

Should generate pages, files, and based on the models available in the codebase, also blocks and other models.

Generate more realistic tree shapes in sample data

• FTPageMakerTask only creates 2k pages, yet our internal NFRs dictate 10k pages.
• It only has 100 pages under one node tops, but should have a random amount between 10 and 1000 (above the default node_threshold).

GraphQL scaffolding breaks Kitchen Sink

The CWP Kitchen Sink repo's CI builds have been failing since the GraphQL Scaffolding PR was merged to this module in December, due to a DB query trying to fire during the flush prior to dev/build. Removing the GraphQL config introduced by this PR resolves the issue (as does having a populated database prior).

I haven't been able to determine a root cause, unfortunately. You can reproduce the issue consistently by installing the Kitchen Sink project and running /dev/build?flush. I can provide a full stack trace if this would be useful.

PR

silverstripe/silverstripe-graphql#204

Ensure frameworktest is working with SS4.0 - some things broken

Apparently, some things are broken and its required for testing UI. Needs review...

Pull requests

• #43

Ability to generate [x] random page types

This will help testing the overhead associated with site tree generation, i.e. /admin/pages/treeview referenced here: silverstripe/silverstripe-cms#1977

One good approach would be to have a separate task to create randomly named page type files (within a range) and then integrate that into FTPageMakerTask to utilize either Page or any of the randomized page types (which will not vary from Page except in name). With this in mind, it may be best to ensure that the randomly generated page extend a single specific page class which can be used to then determine which (of the random set of pages) to create in this FTPageMakerTask (to ensure we don't randomly create instances of pages that are built separately for unrelated testing purposes).

Create SilverStripe 5.x branch

The SilverStripe installer now requires this module in Travis builds: silverstripe/silverstripe-installer#283.

The master branch must be updated to support SilverStripe 5. We cannot merge up the installer branches until this is done.