silviom/node-mem-cache

simple in memory key/value cache with autoclean by timeout

node-mem-cache's Issues

Item expire

I have tried this code and the output is not as expected. I also have looked at the code and the tests only look for expire events.

var cache = new Cache({ timeout: 300 });

cache.set('foo', 'bar');

setTimeout(function () { console.log(cache.get('foo'); }, 1000);

which outputs bar when expected null.

Assertion randomly fails

I ran the unit tests on the module and got a random failure in the section should renew the item's timeout on every single 'get'. The assertion is too narrow. For example, timeout + timeout * 4/3 = 233.3333...., while you check that new Date().getTime() - now = 233 should be greater. Since the value's precision is not high enough, it does not account for the 0.3333 nanoseconds, it may be greater if and only if the time required to run the test is greater than 5000 nanoseconds. This is not the case on fast computers. Therefore, the test is fails.

You should round down the value and check for "greater or equal" instead :

assert.ok(Math.floor(timeout + timeout * 4/3) <= new Date().getTime() - now);

The same thing happens for the test case should expire an item by timeout where the test

assert.ok( timeout < delta);

should be

assert.ok( timeout <= delta);

for the same reason.

Module options

I was wondering what was the motivation behind having negated options? I mean, why timeoutDisabled = false instead of autoTimeout = true ? Or why doesNotRenewTimeout = false instead of renewTimeout = true ?

I'm just curious.