sim22/pihole-exporter-helm-chart

Simple helm chart for pihole exporter

pihole-exporter-helm-chart's Issues

Getting this working with stable/prometheus-operator

Hi, Can you share instruction work this with stable/prometheus-operator helm chart.

Thank you

Allow to use a custom secret instead of inlined secret values in values.yaml

Is your feature request related to a problem? Please describe.
I need, for configuration and security purpose, to separate secret management and configuration

Describe the solution you'd like
The best solution would be to allow to choose the name of a secret to use instead of creating one in the chart. The secret has to be prepared and installed in the NS by the (human) operator before the helm template/upgrade command.

# secretEnvVars:
#   PIHOLE_PASSWORD: 
#   PIHOLE_API_TOKEN: 

secretName: foo-bar

In this example, no secret is created by the chart and the deployment uses the foo-bar value as secretName.

Describe alternatives you've considered
It's a very common way to let users provide their own secret, so no, I don't have other solution for now

Additional context
This has one advantage, if you install PiHole and PiHole exporter in the same ns, they'll be able to use the same secret for password/apikey configuration, so simpler to manage/rotate.