similarweb/puppet-airflow

Puppet module to provision Airbnb's Airflow

puppet-airflow's Issues

scope['variable'] for proper variables handling, ldap loop... and some linter stuff

I found some issues which may be fixed:

• in the templates' files for the services like webserver or worker the syntax for variables is as follow:

@foo

and it seems to be hard to reach them, so I propose to change it to the

scope['airflow::foo']

• also there are some puppet-linter issues like:

$ puppet-lint modules/airflow/manifests/
modules/airflow/manifests//resource/service.pp - WARNING: arrow should be on the right operand's line on line 11
modules/airflow/manifests//params.pp - ERROR: trailing whitespace found on line 75
modules/airflow/manifests//config.pp - WARNING: arrow should be on the right operand's line on line 11

• the celery_ssl_active should be done for an apache-airflow v1.9 It is necessary for proper application setup. My proposition is to set it false by default

• I also see that an airflow.cfg.erb file has static LDAP settings which may be treated more dynamic. I used a loop for it which allows to add some other than listed values like search_scope
  It is for your decission if you like it or not... if yes it may be used in other elements like statsd_settings or mesos_settings

Tested with the apache-airflow v1.9

Add support for Puppet 4

class inhouse_airflow::install {
  class { 'airflow': }
}

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, validate_integer(): Expected first argument to be an Integer or Array, got NilClass at .../airflow/manifests/init.pp:219:3 on node node.example.com

puppet version - 4.10.5
airflow module version - 0.1.2
kernel - Linux 3.10.0-514.el7.x86_64
system - CentOS Linux release 7.3.1611 (Core)

I understand Puppet 4 is not outright supported, but it would be great if this could be done