simonask/libyaml-safer

YAML library, based on unsafe-libyaml

libyaml-safer's Issues

Panic: TODO: What is expected here?

Minimal reproducer:

let mut data: &[u8] = b"[!,";
let mut parser = libyaml_safer::Parser::new();
parser.set_input_string(&mut data);
let _ = libyaml_safer::Document::load(&mut parser);

Panic: unexpected end of input

Minimal reproducer:

let mut data: &[u8] = b"a: ''|\n 0";
let mut parser = libyaml_safer::Parser::new();
parser.set_input_string(&mut data);
let _ = libyaml_safer::Document::load(&mut parser);

Fix for CRLF

Thanks for creating this library! I've been working with it for a couple of months, mostly using the event-based Parser API.

One thing I've noticed is that CRLF line endings are not working (I work on a Windows machine), in that they are resulting in double-line feeds (\n\n) in strings coming out of the library, and incorrect line numbers in Marks.

I believe the fix is very simple. Line 143 of scanner.rs (in read_line_break) should read:

if let ('\r', Some('\n')) = (front, self.buffer.get(1).copied()) {

Similar to line 111, and to the corresponding libyaml implementation (https://github.com/yaml/libyaml/blob/1e66c1e13a50577bd7ad76abec61ba436d0145bd/src/scanner.c#L533)

I cloned locally and made this change, and it did resolve my issue. I have not done any further testing. I'm happy to open a PR but I'm not sure if you're accepting contributions to this repo.

Implement Serializer/Deserializer

Now that serde_yaml is unmaintained, add implementations of serde::Serializer/Deserializer directly to libyaml-safer to provide an alternative.

The initial implementation should be 1:1 compatible with the behavior of serde_yaml.