simonh1000/elm-colorpicker

Elm library to implement a color picker tool

elm-colorpicker's Issues

Opacity slider does not reflect color

It reflects only hue - not brightness or saturation.

Hard to use when storing state as hex value

hex2Color and color2Hex relies on 255 color format

Thanks for making this package, I use it for my Elm-powered knitting pattern designer.

I found a bug in the hex conversion functions, since elm-hex needs a value between 0 and 255 (for colors), it will not work when using the values directly from Color which is now between 0 and 1. color2Hex can be fixed by multiplying with 255 in the List.map and hex2Color by using Color.rgb255 instead of Color.rgb.

I can make a pull request attempting to fix this, but since they are no longer used internally and elm-color has a toCssString function. You might want to remove them altogether. Then you can also drop the elm-hex dependency.

Example code missing dependency

It wasn't immediately obvious to me that avh4/elm-color also needs to be installed & imported in order for the example code to run.

Perhaps something like:

import Html exposing (Html)
import ColorPicker 
import Color exposing (Color)

might make it more clear that the example relies on elm-color in particular?

Can we make this completely stateless

The state of the colorpicker is only for tracking the mouse if I am not mistaken.

If we use MouseEvent.button or MouseEvent.which for safari, we can simplify the colorpicker even more.

https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/button

When using a predefined value, hue is not set correctly.

Thanks for this ColorPicker. I really like it.

When not starting with white or black though, the hue in the colorpicker is incorrect:

Hue should be at red, is at cyan

Here the relevant code:

type alias Model =
    { colorPicker : ColorPicker.State }


initialModel : Model
initialModel =
    { colorPicker = ColorPicker.empty }


type Msg = ColorPickerMsg ColorPicker.Msg


update : Msg -> Model -> Model
update msg model =
    model


view : Model -> Html Msg
view model =
    div []
        [ Html.map ColorPickerMsg <| ColorPicker.view (Color.rgb 1.0 0.0 0.0) model.colorPicker
        ]

When using two colorpickers, the alpha-selector background color is identical

When using two colorpickers at the same time, the background of the second alpha selector is always the one of the first:

See this ellie-example