simonsator/bungeecordpartyandfriends

Easy to use party and friends plugin for Bungeecord

bungeecordpartyandfriends's Issues

Suggestion: Velocity Support

As the title suggests, adding Velocity support would be helpful in boosting the platform and open this plugin up to a new audience!

Spaces get removed in private messages

When a user sends a private message to one of his friends, the spaces get removed from the final message. I tried editing the code after cloning the master branch, but I couldn't get it to work.

Maybe it has to do with the last commit: fixed bugs

NoName HideTool

Hey, bin gerade dabei das Plugin zu configurieren.
Hab dabei gemerkt dass das HideItem keinen Namen hat.
Hab mal deinen Code decompiled, und siehe da:
unter de/simonsator/partyandfriendsgui/manager/ItemManager.java
fand ich das:

string = "Inventories.SettingsMenu.PlaceHolderItem.";
this.SETTINGS_MENU_PLACEHOLDER = configuration.getBoolean(string + "Use") ? itemManagerSetupHelper.getItemStack(TextIdentifier.FRIEND_ACCEPT_MENU_PLACEHOLDER, string + "ItemData", string + "MetaData") : null;
string = "Inventories.ToolBar.HideItem.";
this.HIDE_ITEM = configuration.getBoolean(string + "Use") ? itemManagerSetupHelper.getItemStack(# TextIdentifier.FRIEND_ACCEPT_MENU_PLACEHOLDER, string + "ItemData", string + "MetaData") : null;

ich habs für mich jetzt selber gefixed, aber für die anderen solltest du das im nächsten update fixen :D

LG Julian

Show "last online" at mouse over in friend gui.

Hi,
it would be a nice little addition to show the last online time + date when mouse over a player skull in friends menu.

Update uuid player in database

Welcome

I noticed you have a problem that you are not updating UUID player. When the player first enters the server, you add them to the table 'fr_players' with player_name and player_uuid.

When a player buys a premium account in minecraft, the uuid changes.
When i get PAFPlayer PartyManager.getInstance().getPlayer(uuid) returns me null, because cannot find a player with this uuid in "fr_players".

I solved it by doing update player_uuid during AsyncPlayerPreLoginEvent (event.getUniqueId())

Can't translate Friends.Command.MSG.SentMessage

Hi,

I've a strange bug, each time I change the message Friends.Command.MSG.SentMessage in Messages.yml, it get replaced by original value: &e[SENDERNAME]&5-> &e[PLAYER]&7: [CONTENT].

I translated every other line without any issues, but this won't work...

kicked by using command /friend jump

Describe the bug

When I type /friend jump and press TAB,I will kicked by server ，and bungeecord show errors:

UpstreamBridge - encountered exception io.netty.handler.codec.EncoderException: java.lang.NullPointerException at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:125) at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:893) at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:875) at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:984) at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:868) at io.netty.channel.ChannelDuplexHandler.write(ChannelDuplexHandler.java:115) at com.loohp.interactivechat.proxy.bungee.InteractiveChatBungee$3.write(InteractiveChatBungee.java:912) at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:891) at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:875) at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:984) at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:868) at io.netty.channel.ChannelDuplexHandler.write(ChannelDuplexHandler.java:115) at me.neznamy.tab.shared.features.injection.NettyPipelineInjector$TabChannelDuplexHandler.write(NettyPipelineInjector.java:115) at me.neznamy.tab.platforms.bungeecord.BungeePipelineInjector$DeserializableBungeeChannelDuplexHandler.write(BungeePipelineInjector.java:115) at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:891) at io.netty.channel.AbstractChannelHandlerContext.invokeWriteAndFlush(AbstractChannelHandlerContext.java:956) at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:982) at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:950) at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:1019) at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:310) at net.md_5.bungee.netty.ChannelWrapper.write(ChannelWrapper.java:90) at net.md_5.bungee.UserConnection$1.sendPacket(UserConnection.java:155) at net.md_5.bungee.connection.UpstreamBridge.handle(UpstreamBridge.java:270) at net.md_5.bungee.protocol.packet.TabCompleteRequest.handle(TabCompleteRequest.java:87) at net.md_5.bungee.netty.HandlerBoss.channelRead(HandlerBoss.java:128) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:289) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:346) at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:318) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1407) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:918) at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166) at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788) at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724) at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650) at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562) at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:994) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at java.base/java.lang.Thread.run(Thread.java:833) Caused by: java.lang.NullPointerException

To Reproduce

This bug may not be reproducible immediately. My server has been running normally for several days without any issues, but it suddenly appeared again tonight. The last time this bug occurred, I restarted Bungerecord and it was resolved

1.install PAFInstallOnBungeeCordAndLobbyServers, Friends-Online-Info-On-Join-For-PAF-1.0.1-SNAPSHOT，Teleport-To-Friend-Addon-1.0.3-RELEASE on Bungeecord
2. install PAFInstallOnBungeeCordAndLobbyServers ,Teleport-To-Friend-Addon-1.0.3-RELEASE on normal Server
3. type command /friend jump and press TAB
4. kicked by server

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

Server (please complete the following information):

• OS: [e.g. iOS]
• Bungeecord-1848
• purpur-1.20.1-2062

Minecraft client (please complete the following information):
1.20.1

• Mods: [e.g. forge]
• Client version: [e.g. 1.19]

Additional context

question

You can recommend some tutroial on how to install MySQL on your PC ??

Error with party

I bought the plugin for the spigot version. But I am having errors when I execute the command / party invite

i'm using 1.7.10 kcauldron.

[13:17:57] [Server thread/ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing 'party invite abacate' in de.simonsator.partyandfriends.party.command.PartyCommand(party)
	at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:188) ~[SimpleCommandMap.class:1.7.10-1448.121]
	at org.bukkit.craftbukkit.v1_7_R4.CraftServer.dispatchCommand(CraftServer.java:717) ~[CraftServer.class:1.7.10-1448.121]
	at net.minecraft.network.NetHandlerPlayServer.func_147361_d(NetHandlerPlayServer.java:1317) [nh.class:?]
	at net.minecraft.network.NetHandlerPlayServer.func_147354_a(NetHandlerPlayServer.java:1099) [nh.class:?]
	at net.minecraft.network.play.client.C01PacketChatMessage.func_148833_a(C01PacketChatMessage.java:38) [ir.class:?]
	at net.minecraft.network.play.client.C01PacketChatMessage.func_148833_a(C01PacketChatMessage.java:53) [ir.class:?]
	at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:244) [ej.class:?]
	at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:173) [nc.class:?]
	at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:991) [MinecraftServer.class:?]
	at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:431) [lt.class:?]
	at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:809) [MinecraftServer.class:?]
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:669) [MinecraftServer.class:?]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_191]
Caused by: java.lang.NoClassDefFoundError: net/md_5/bungee/api/chat/BaseComponent
	at de.simonsator.partyandfriends.party.PartyManager.createParty(PartyManager.java:52) ~[?:?]
	at de.simonsator.partyandfriends.party.command.Invite.onCommand(Invite.java:89) ~[?:?]
	at de.simonsator.partyandfriends.party.command.PartyCommand.onCommand(PartyCommand.java:178) ~[?:?]
	at de.simonsator.partyandfriends.api.commands.PartyFriendCommand.execute(PartyFriendCommand.java:21) ~[?:?]
	at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:181) ~[SimpleCommandMap.class:1.7.10-1448.121]
	... 12 more

Can you add a custom sound optien when a friend join or send a message

Can you add a custom sound optien when a friend join or send a message

Virus Scan Positive [Exploit.CVE.JS.5707]

Running the latest file from spigot in a virus scanner shows up this vulnerability: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-5707.

Virus Scan Results:
https://www.virustotal.com/gui/file/28b8ca07822ab679ba2b05901ea8c19f17e306faae9a85d3b2a78a57b9821909/detection

Disable hide player module in specific servers or worlds

Is your feature request related to a problem? Please describe.
Yes.In the survival server,my players can use the hide player module and ignore someone.Then they can place blocks at that player's location,which causes the player being blocked in walls and suffer damage.
So i want an option to disable hide player module in specific servers.

Describe the solution you'd like
I want an option to disable hide player module in specific servers.It's not just ban the command /hide.I prefer to everyone is forced to see every player.

Describe alternatives you've considered
Ban the /hide and /hidegui,then force everyone to stay in "show all player"state.

Additional context
I am willing to help you test the new feature if you need my help.You can contact me through Discord.I am DreamStarσ#0440

question

how to disable a command on a specific server? (same as /friend jump but with the others). I need to disable /party because the server has its own party system

messy & inefficent code

my eyes hurt after trying to read this code.
the code is very messy and unreadable, this could've been done in so many other & better ways

Command tab comple

If possible to add command tab complete for any commands?

Player fires

Disable friendly fire for Party and Friends

Upgrade bug

The time when a player was last online does not get set right until the player joins the server again. Because of that the time of those players cannot be read.

questions

Hello ! I have some questions I put the plug in the right folder, but when I do the command / party or / friend tells me that the command does not exist .. why ??
(Use the latest version of the plugin instead bungeecord is 1.8)

necessarily have to use mysql ?? if you tell me how to download it on my computer or some site that sells mysql services

Party Deleted Event

Is your feature request related to a problem? Please describe.
There is no event for catching the destruction of a PlayerParty.

Describe the solution you'd like
Add such an event under https://github.com/Simonsator/BungeecordPartyAndFriends/tree/master/src/main/java/de/simonsator/partyandfriends/api/events/party

Describe alternatives you've considered
None.

Additional context
So that https://github.com/PikaMug/Unite might be able to support this.

UpdateChecker missing

Hi, I am currently trying to build the plugin from source, but Maven tells me, that he can't find de.simonsator:UpdateChecker

And I don't know either where to find it.

Can someone help me out?
Thanks in advice.

Dont click, this issue is already fixed

2 "cosmetic" killer-features! They are very useful and helping to determine friends from other players easy

And add 2 very useful "cosmetic" features:

1. Color friends nametags as blue (&9) like on Shotbow Network. Player nicknames are blue above head, in tab, in chat and everywhere else. Especially on PvP servers it will be much easier to react in milliseconds on enemies and separate them from friends. Friends will be instantly casted as players just by their calm blue nametag. So if nametag of another players is white - this means it's not your friend and you should be instantly noticed about that to react on that possible enemy;

2. Literally highlight your friends (simulating spectral arrow effect). So you will see your friends or your team even through walls and will not lost each other. To change color of spectral highlighting, change Scoreboard prefix color: better to implement that as Placeholder way to make compatibility with existing prefixes of players which are handled by multiple other plugins

I get this error in bungeecord console

https://pastebin.com/dQpSDrDa

ChatColor & -> §

Please use

textToTranslate = ChatColor.translateAlternateColorCodes('&', textToTranslate);

instead of

.replace("&", "§");

~Navo

Text of /fmsg does not contain spaces

In the version 1.0.81 i found this issue:
The command /fmsg Player Hello World!
Return "HelloWorld!" to the player who recieves the message instead of "Hello World!.
When the arguments of the command are attached to create the message the spaces are missing.