simplemachines / sphinx-for-smf Goto Github PK

View Code? Open in Web Editor NEW

8.0 8.0 7.0 27.98 MB

Sphinx Search Engine for SMF

License: Other

PHP 100.00%

smf smf-modifications sphinxsearch

sphinx-for-smf's People

Contributors

Stargazers

Watchers

Forkers

realdigger mtzukanov siddeyg gnif

sphinx-for-smf's Issues

charset_table

charset_table = 0..9, A..Z->a..z, _, a..z

Would be better to remove this line or make it optional, because it limit index to latin charset only.
Default value for charset_table are latin and cyrillic characters.

Open "View Sphinx.conf" in new tab/window

Hi,

i think it could make sense that the "View Sphinx.conf" link is opening in a new tab or window. With that its not needed to go back to the settings page again.

Non-static method

https://example.com/index.php?action=admin;area=search
8192: Non-static method sphinxql_search::searchSettings() should not be called statically
File: /var/www/Sources/ManageSearch.php
Line: 138

Sphinx config file issues

Tested on Sphinx 3.6.1

sql_attr_uint is deprecated. attr_uint must be used. Also it should be placed inside index block. Something like this:

index smf_base_index
{
	html_strip	= 1
	source		= smf_source
	#path		= /some/path 
	min_word_len	= 2
	charset_table	= 0..9, A..Z->a..z, _, a..z

	field = body, subject
	attr_uint = id_topic
	attr_uint = id_board
	attr_uint = id_member
	attr_uint = poster_time
	attr_uint = relevance
	attr_uint = num_replies
}

Another warning regarding explicit paths:

WARNING: datadir: explicit index 'path' is deprecated; please convert your config to use 'datadir' directive

I just commented paths and used the default datadir to fix it:

common
{
    datadir     = ./sphinxdata
}

binlog_path /var/sphinx/data vs. /var/sphinx/data/

Hi,

i'm not quite sure about the binlog_path:

binlog_path = /var/sphinx/data/

currently used within the plugin. With sphinx 2.2.10 i have seen messages like:

WARNING: binlog: failed to unlink /var/sphinx/data//binlog.001: No such file or directory (remove it manually)

The sphinx docs are showing (without the slash):

binlog_path = /var/data

http://sphinxsearch.com/docs/current/conf-binlog-path.html

After killing the searchd it seems that the binlog.001 is kept at that path so unlink might fail here because of the doubled slash.

Edit

Yes, a used binlog_path = /var/data is causing the binlog.001 to disappear after the searchd is killed.

Real time indexes

Hello,

First off, thanks for this package. It did help me with Sphinx.
Secondly, this is not an "issue". I don't know Sphinx thoroughly so I'd like to know your take on RT indexes.

Well I know that delta indexes are updated every hour and the base is updated daily. So that almost covers up most scenarios. Would you say that the hassle of setting up RT indexes doesn't worth it for a forum? That aside, just for the sake of implementing it: Should I set up integration hooks every time the messages table is updated to reflect those changes into the RT index table?

Add ability to use custom index name

Currently the code only allows "smf_index". But in a multi-forum environment, this won't work without multiple configs running on different interfaces. Simple solution is to allow different names.

Create listen directive to listen on localhost/127.0.0.1 if chosen

Hi,

currently the generated sphinx config contains a listen directive:

listen = $port:mysql41

If either localhost or 127.0.0.1 is chosen in the search settings of SMF it could make sense to create:

listen = 127.0.0.1:$port:mysql41

or:

listen = localhost:$port:mysql41

that the Sphinx Server is not listening on all interfaces.

Remove "Maximum # matches" from SMF config page

Hi,

with d294fee the deprecated "max_matches" setting was removed from the generated config.

After this change the "Maximum # matches" setting of the SMF config page could be also removed.

Version typo in package-info.xml?

Shouldn't this line in package-info.xml for the 2.1 install refer to the "SMF 2.1" folder rather than "SMF 2.0"?
https://github.com/SimpleMachines/sphinx-for-smf/blob/master/package-info.xml#L19

Looks like a copy-paste mishap.

Kernel 3.0

I have a VPS that unfortunately is still running Kernel 2.6 and Ubuntu 15.10. I see you require kernel 3.0. Is there any chance I can still get this to work?

Remove SMF Indexes

We should provide the option to delete the SMF indexes from Fulltext or Custom indexes.

hypens in names break message body

latest-news breaks results on simplemachines.org. Need to test more.

Non-English characters not showing correctly in SMF 2.1 RC4 (but they did in RC2)

Hi,

I have been using Sphinx for SMF v1.1 in my SMF 2.1 RC2 forum for a very long time without any problem. I have recently upgraded to RC4 and now non-English characters are not showing correctly in the search results:

In the previous example the highlighted words are

método
¡
recién
edición
quizá
fotografía

I am running sphinx-2.2.11-1 in CentOS 8.

Thank you!

Sphinx Version 3

http://sphinxsearch.com/blog/2018/03/31/sphinx-3-0-3-released/

Seems that version 3 has removed sql_attr_timestamp and sql_query_info.

Old configuration options.

using config file '/etc/sphinx/sphinx.conf'...
WARNING: key 'sql_query_info' was permanently removed from Sphinx configuration. Refer to documentation for details.
WARNING: key 'charset_type' was permanently removed from Sphinx configuration. Refer to documentation for details.
WARNING: key 'max_matches' was permanently removed from Sphinx configuration. Refer to documentation for details.

SMF Search bug causes only 1 page results

Due to a SMF bug regarding the $num_results being mishandled upon return of searchQuery, the number of results a page is shown is 1.

The current hot fix is to change this:

		return $cached_results['total'];
	}

To this:

		// Work around SMF bug causing multiple pages to not work right.
		$_SESSION['search_cache']['num_results'] = $cached_results['total'];

		return $cached_results['total'];
	}

Which is just forcing the search cache to have the correct number of results.

Deprecated features

Notice: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in /smf20/Sources/SearchAPI-Sphinxql.php on line 368
Notice: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in /smf20/Sources/SearchAPI-Sphinxql.php on line 368

[09-Nov-2015 13:19:19 Europe/Berlin] PHP Parse error:  syntax error, unexpected ',' in /var/www/forum/Sources/SearchAPI-Sphinxql.php on line 603