Giter Site home page Giter Site logo

simplepie / simplepie-ng Goto Github PK

View Code? Open in Web Editor NEW
41.0 6.0 7.0 61.96 MB

Don't use this yet.

Home Page: https://simplepie.github.io/simplepie-ng/

License: Apache License 2.0

PHP 91.99% Python 1.89% HTML 4.08% Makefile 1.46% Shell 0.05% XSLT 0.13% Roff 0.39%
php xml rss atom jsonfeed middleware-handlers simplepie simplepie-ng middleware w3c

simplepie-ng's Issues

Modeling `Type\Author` for h-feed.

this looks awesome @skyzyx! Glad you've got the time to take this on.

Just wanted to mention an issue I've had when retrofitting microformats into SimplePie OG (yes I think I will use that term...) The issue is that h-entry's have a wider vocabulary for authors via h-card than traditional feeds. So instead of just being a name or email address they can be full html markup with profile images, urls, etc. This makes it hard to be an afterthought because you've probably made a few assumptions about content types for author before implementing it.

Anyway feel free to close this issue.

[Insight] Commented code should not be committed - in src/Type/Entry.php, line 54

in src/Type/Entry.php, line 54

Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.

        if ($node) {
            $this->logger = $logger ?? new NullLogger();
            $this->node   = $node;

            // foreach ($this->node->attributes as $attribute) {
            //     $this->{$attribute->name} = new Node($attribute);
            // }
        }
    }

    /**

Posted from SensioLabsInsight

Clarify shared hosting providers non-support

Quoting the readme:

Will almost certainly not work with shared hosting providers. Time to get a grown-up server.

Since this is supposed to be just a PHP library, why would that not work on shared hosting providers?

The support for shared hosting providers is still important because, for example, for students, especially in less wealthy countries, shared hosting might be the only way to afford a “private cloud”. I was also relying on that until very recently. And even if one has the money, running a server takes significantly more effort.

Also, the ability to deploy applications to a shared hosting is the only reason why I still use PHP at all – on my own server I can just use the better languages.

[Insight] Object parameters should be type hinted - in src/Type/Feed.php, line 184

in src/Type/Feed.php, line 184

The parameter link, which is an object, should be typehinted.

                $links = $this->getComplexMultipleValues($this->getRoot(), $nodeName, $args[0] ?? null);

                if (isset($args[1])) {
                    $relFilter = $args[1];

                    return \array_values(\array_filter($links, static function ($link) use ($relFilter) {
                        return $relFilter === $link->getRel()->getValue();
                    }));
                }

                return $links;

Posted from SensioLabsInsight

Compat: missing_quote_in_attr

Should we leave bunk HTML alone? Or pass it through an HTML5 parser?

FeedParser.py passes it through an HTML5 parser.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.