Fullscreen option

[sindresorhus]

Fullscreen option

[sindresorhus]

A good pull request would be welcomed, but not something I personally need.

[Caesarovich]

Coming back on this late.
I've experimented a bit, I've managed to create a stable height option. Next was the fullscreen option, which is just a boolean that sets width and height as the terminal's dimensions. Although after experimenting a bit with it I have to conclude that the fullscreen option does not work quite well, because on most terminals there is say 15 rows available, but after boxen prints out the 15 row box, the terminal will always add a line break or stuff like that. Thus far on every different terminals I've tried this option on, the top of the box gets cropped because the terminal adds one or more blank line in the output. I don't know if I explained it correctly but in short: It does not look good at all.

So should I keep fullscreen or only add height ?

[LitoMore]

The line break shows that because your CLI process finished.

But for some living process, the line break will not be a problem.

You could design your fullscreen API according to your requirement.

Something like this:

type FullscreenOption = 
	| boolean
	| (width: number, height: number) => [width: number, height: number];

// Default use
app({
	fullscreen: true
});

// With modifications
app({
	fullscreen: ([w, h]) => [w, h - 1]
});

BTW, I had a branch before but it's outdated now. I can back to this work when I have time.

[LitoMore]

If you have interest in this, I would like to help to review.

[Caesarovich]

@LitoMore Your idea of the implementation is very nice ! I'll try implementing it as soon a I can !