Comments (7)
Well, after looking at the jsZip documentation, it seems like the .file
call should be sufficient, as the .folder
method returns a new jsZip instance for chaining, which doesn't really solve the problem as far as I know. I'm going to open an issue with the jsZip library itself.
from gulp-zip.
The .folder
method creates a new entry in the zip file (flagged as a directory) and returns a new instance for chaining. Calling .folder
instead of .file
will be enough in this case.
from gulp-zip.
I don't know whether the fix is as simple as simply switching between .folder
and .file
based on the results of .isDirectory
, but if you think it is, I'll give it a shot. If it's more complex than that, I'll be happy to try out any proposed fix you might come up with.
from gulp-zip.
Turns out JSZip had only just been updated with a "fix" that caused this problem. I'm working with the JSZip author to provide a fix.
from gulp-zip.
Could you please publish this new version to npm? This is kind of a sticking point for an active project I'm working on.
from gulp-zip.
@isochronous Yes, when #31 is resolved. Review of that PR welcome.
If you can't wait you can easily depend on a git SHA. See npm docs.
from gulp-zip.
I had no idea you could do that with npm. That's awesome, thank you!
from gulp-zip.
Related Issues (20)
- Replace gulp util
- Changelog HOT 1
- Feature Request: support Yazl's `options.mtime` to enable creating byte-for-byte identical zip archives across rebuilds HOT 2
- readable-stream throws error when using gulp-zip HOT 1
- Can't open zip on Mac OS HOT 7
- Unable to zip Windows "Junction" folders.
- yazl 2.5.0 broke gulp-zip HOT 1
- How to use the options configuration object HOT 1
- gulp-util removal request HOT 1
- gulp-zip change folder permission, from 755 to 666 HOT 6
- Can't install w/ npm HOT 1
- Remove gulp peer dependency? HOT 3
- Files without name are ignored during zip (e.g. ".txt") HOT 2
- yazl TypeError: jsDate.getDate is not a function when setting modfiedTime HOT 1
- How tooutput zip into source directory?
- Request: Add more examples to documentation HOT 3
- Won't zip if folder name contains [square brackets] HOT 2
- FEATURE REQUEST: zip files recursively HOT 1
- Append files to existing zip HOT 1
- Deprecation of Gulp-util HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gulp-zip.