Comments (3)
peterbe
commented on May 12, 2024
Downgrading to 0.4.1 solved it.
from ky.
sindresorhus
commented on May 12, 2024
This regression was introduced in a7c71b5. We needed to convert the string URL into an URL instance to be able to add search params. Since URL requires full URLs, it throws.
@sholladay Do you know what fetch() resolves against when it gets foo and /foo URLs? We need to imitate that for base in the new URL() call.
from ky.
sholladay
commented on May 12, 2024
Oy sorry about that. I wanted to write a test for that case, but we didn't have Cypress set up at the time and couldn't get it to work with node-fetch. The answer is document.baseURI. I will do a PR in a few hours if no one gets to it by then.
from ky.
Related Issues (20)
- "fetch() request with GET/HEAD/OPTIONS method cannot have body" in Bun HOT 2
- retry is wrongly counting HOT 1
- Error: `unsupported BodyInit type` on some runtimes HOT 1
- Ky does not pass custom options down to the native fetch HOT 4
- is there a way to prevent HttpError when response is not in range HOT 2
- POST request fails in Astro.js API route HOT 5
- Header not set on node version 18.18.2 HOT 14
- [help] trying to understand why headers are not set properly HOT 1
- 1.1.1 breaks multipart form boundary HOT 6
- Passing { next: { revalidate, tags } } options to ky does not work in NextJS edge (at least with dev server) HOT 10
- Tests are hanging HOT 2
- Best way to handle Fetch errors such as Failed to fetch, NetworkError when attempting to fetch resource, etc. HOT 1
- Retries on timeout HOT 1
- TypeError: signal.throwIfAborted is not a function HOT 9
- Support for SSL client certificate in Nodejs undici HOT 1
- How to abort retry before hitting the retry limit?
- Cannot use import statement outside a module, Jest HOT 1
- Types for headers HOT 2
- How to handle HTTP Delete Method (204) with ky?
- [BUG] When Response is a string(not valid JSON), `json` method occurs error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ky.