Comments (5)
I don't see any downside in letting ow
return true
when it passes. 👌
from ow.
I was thinking yesterday as to why we need this?
Aren't these identical?
function foo(input) {
if (ow(input, ow.string)) {
// heavy computation
}
}
And
function foo(input) {
ow(input, ow.string);
// heavy computation
}
Because if it throws, it exits the function so why wrap it in an if-statement then? When it passes it will always continue.
from ow.
Yeah, my example is flawed. It makes more sense when you see my actual use-case. I didn't include that as it would also need .optional
to work. https://github.com/imagemin/imagemin-pngquant/blob/0e0edd2ce0a379623ec06dd40236276027abf606/index.js#L52-L55
The key is that I only want to do a computation when the input is both defined and the correct value. If the input is undefined I do not want to do anything.
So I thought this could work:
if (ow(options.verbose, ow.optional.boolean)) {
args.push('--verbose');
}
But that would return true
when options.verbose === undefined
, so what I'm really looking for is something like:
if (ow.isDefinedAndValid(options.verbose, ow.optional.boolean)) {
args.push('--verbose');
}
Maybe I'm trying too hard to over-optimize this and maybe a callback would indeed be better for this use-case. I'm not sure anymore.
from ow.
@sindresorhus If I understand you correctly, do you want something like that?:
ow.isDefinedAndValid(options.verbose, ow.optional.boolean, (err, value) => {
if (err) {
/* ... */
}
args.push("--verbose");
});
ow.isDefinedAndValid(options.verbose, ow.optional.boolean)
.then(value => args.push("--verbose"))
.catch(err => /* ... */);
try {
const value = await ow.isDefinedAndValid(options.verbose, ow.optional.boolean);
args.push("--verbose");
} catch (error) {
/* ... */
}
from ow.
@Shinigami92 No, I would prefer an if-statement. If it were to be a callback, it would be:
ow.isDefinedAndValid(options.verbose, ow.optional.boolean, () => {
args.push('--verbose');
});
from ow.
Related Issues (20)
- Bug: `isValid` wrong typing HOT 3
- Package does not seem to work on node v8 `SyntaxError: Unexpected token {` HOT 1
- string.nonBlank validator HOT 1
- Error running with metro bundler
- generate objects from predicate HOT 3
- use browser-side HOT 1
- Unclear error message when checking NaN against the number type HOT 7
- Composition HOT 3
- Is there a way for an object predicate to differentiate between key with value `undefined`, and key not present? HOT 2
- should `ow.string.equals` be narrowing the type to specific strings? HOT 1
- wrong message: Expected `e` to be of type .... - instead of Expected argument to be of type HOT 3
- Show all possible errors exhaustively (option?)
- const values HOT 1
- Q: how to make custom type narrowing validator (i.e. Predicate<x>)? HOT 3
- metadata
- Documentation is 404
- Build errors when using ow in React app compiled with vite
- Upgrading to 1.1.0 from older version makes TS complain HOT 6
- correct pattern for optional 'required' properties?
- Cannot find module 'ow' or its corresponding type declarations HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ow.