Giter Site home page Giter Site logo

Comments (9)

poupryc avatar poupryc commented on May 16, 2024 1

Maybe change the name for enum ?

from ow.

sindresorhus avatar sindresorhus commented on May 16, 2024 1

👍 oneOf

from ow.

sindresorhus avatar sindresorhus commented on May 16, 2024

👍 Good idea

from ow.

SamVerschueren avatar SamVerschueren commented on May 16, 2024

Why? Enums are not the same as arrays. Can you give an example?

from ow.

poupryc avatar poupryc commented on May 16, 2024

for me, enum refers to the possible value that can take the string. Or I did not fully understand the use cases of "is"

from ow.

transitive-bullshit avatar transitive-bullshit commented on May 16, 2024

I think enum would make more sense if it were the type, not the function. And since enums don't exist as a native type in JS, @SamVerschueren's OP suggestion seems the most consistent to me.

from ow.

SamVerschueren avatar SamVerschueren commented on May 16, 2024

Exactly, enums are more a TS thing rather than a JS thing.

from ow.

poupryc avatar poupryc commented on May 16, 2024

Yes, it might be confused. "in" seems fine in this case ^^

from ow.

transitive-bullshit avatar transitive-bullshit commented on May 16, 2024

Alternatively, oneOf might be a little clearer and it follows react's prop-types naming.

ow(input, ow.string.oneOf(['foo', 'bar']));

from ow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.