sirmov/roomed

Hotel management system

Hi there, I'm Nikola Sirmov 👋

🔭 I’m currently working on Heccmas, Safe secrets and Roomed

🌱 I’m currently learning:

• Redis
• MongoDB

📫 How to reach me:

    

💻  Main tech knowledge

         
         
           
       
     
         

📊  GitHub Statistics

roomed's Issues

Response caching, session

Add response caching and session to IoC container.

Extract string based keys

Extract string based keys as constants to limit the use of magic string and improve readability.
Example: ViewData["Profiles"] -> ViewData[ViewData.Profiles]
Used for ViewData, TempData and other

Add is-invalid class to input when validation does not pass

Extract more complex model validation

Make use of IValidatableObject or FluentValidation to extract model validation logic from the controller.

Extend ISeeder interface

Extend ISeeder interface with IsSeededAsync method returning a boolean showing wether the data is already present in the database or not.

Make BaseService.GetAsync work with queryOptions

IDeletable entity repository
+Find(TKey id, bool isReadonly, boolWithDeleted = false);
+FindAsync(TKey id, bool isReadonly, boolWithDeleted = false);

Deletable entity repository
overwrite Find(TKey id, bool isReadonly) to get not deleted
overwrite FindAsync(TKey id, bool isReadonly) to get not deleted

Implement query result

Implement a QueryEesult class that should be returned by every method in every service. With it we can eliminate throwing exceptions by using a Errors property for example.

Consider renaming db context

Consider renaming the ApplicationDbContext to RoomedDbContext

Add error handling

Implement Home Error action for all status codes. Handle exceptions by using alerts, toasters or other types of messages for the client and log the errors for the server. Use the implemented status code pages as a fallback.

Ordering in modify query does not work

Ordering in modify query does not work. Because of this Skip and Take do not work also.

Add logging

Define constants in separate classes

Move from DistributedMemoryCache to StackExchangeRedisCache

Extract view names to constats

This can be useful when returning a different view. Example: using return View(Views.Create).

Decide how to handle identity documents of deleted guests

1. Indicate a message that the owner of the document is deleted
2. When the guest is deleted delete all of his identity documents
3. Don't show identity documents with deleted owners
4. Make a search filter

Extract error messages

Extract error messages as constants to reduce the use of magic strings. Make use of format strings.

Make IsBefore and IsAfter validation attributes generic

It should be able to be used with DateTime and DateOnly.

Create a Guard class

• AgainstNull
• AgainstTrue
• AgainstFlase
• AgainstRegex
• AgainstNullOrEmpty
• AgainstNullOrWhitespace

Move ProjectTo{TDto} last before ToListAsync()

This is a practice advised by the documentation of automapper.

Consider the use of "init;"

Make creating a reservation and its reservation days in a transaction

To resolve this issue the db context transaction api should be exposed by the IRepository intefrace.

Extract Front Office MVC area

Consider extracting front office as a mvc area leaving the non authorized users not having access to any area.

Extension methods

Add User extension methods e.g. Id(). Add session extension methods e.g. Get(ISession session, string key) Set(ISession session, string key)

Consider making access modifiers more restrictive where appropriate