sitecore-community/sitecore-mvc-contrib

Contrib library for Sitecore 7.5+ MVC

sitecore-mvc-contrib's Issues

InjectViewInPlaceholderFilter causes HTTP 503 issues

When a layout is used that has other controller renderings in it's presentation details the global injector filter become re-entrant, eventually killing of the app pool.

Improve "Clean" task build script

It looks like the build task "Clean" does not get rid of stale assemblies.

We should probably expand on the cleaning task or force a rebuild.

Should Sample route registration be more transparent

Route registration is done by adding a reference to the SitecoreContribSample assembly. Whilst elegant - it is less than obvious where the route registration is done.
Should we change this to be more clear?

Features need documenting

While I understand the goal of the project is to make our lives easier working with sitecore, this project could benefit from better documentation of existing features and how to use them.

Do we need to cater for WebAPI DI?

http://blog.ploeh.dk/2012/10/02/DependencyInjectioninASP.NETWebAPIwithCastleWindsor/

Expose Sitecore.Abstractions as a distinct NuGet package

It would be good to have the Sitecore.Abstractions available as a separate NuGet package. Potentially this could be made available in two flavours:

• Sitecore.Abstractions.Mvc
• Sitecore.Abstractions.AspNet (web forms)

InjectViewInPlaceholderFilter responds to Ajax requests

The InjectViewInPlaceholderFilter will act on any ajax requests made to a controller that has also has a route configured to use the placeholder injector mechanism. This will prevent controller actions returning JSON results if the controller is also used to service placeholder injection routes.

HttpContextHelpers compilation errors

[13:13:35][tests\unit-test\Sitecore.Mvc.Contrib.Test\Sitecore.Mvc.Contrib.Test.csproj] CoreCompile (26s)
[13:13:35][CoreCompile] Csc (26s)
[13:13:35][Csc] c:\Windows\Microsoft.NET\Framework\v4.0.30319\Csc.exe /noconfig /nowarn:1701,1702 /nostdlib+ /errorreport:prompt /warn:4 /define:DEBUG;TRACE /reference:"C:\Program Files\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.0\Microsoft.CSharp.dll" /reference:D:\TeamCity\Install\buildAgent\work\a2b94f0746baa2b1\packages\Moq.4.0.10827\lib\NET40\Moq.dll /reference:"C:\Program Files\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.0\mscorlib.dll" /reference:D:\TeamCity\Install\buildAgent\work\a2b94f0746baa2b1\packages\NUnit.2.6.2\lib\nunit.framework.dll /reference:D:\TeamCity\Install\buildAgent\work\a2b94f0746baa2b1\lib\Sitecore.Kernel.dll /reference:D:\TeamCity\Install\buildAgent\work\a2b94f0746baa2b1\lib\Sitecore.Mvc.dll /reference:D:\TeamCity\Install\buildAgent\work\a2b94f0746baa2b1\artifacts\Build\SitecoreAbstractions.dll /reference:D:\TeamCity\Install\buildAgent\work\a2b94f0746baa2b1\artifacts\Build\SitecoreMvcContrib.dll /reference:"C:\Program Files\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.0\System.Core.dll" /reference:"C:\Program Files\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.0\System.Data.DataSetExtensions.dll" /reference:"C:\Program Files\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.0\System.Data.dll" /reference:"C:\Program Files\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.0\System.dll" /reference:"C:\Program Files\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.0\System.Web.dll" /reference:D:\TeamCity\Install\buildAgent\work\a2b94f0746baa2b1\build\..\artifacts\Build\System.Web.Mvc.dll /reference:"C:\Program Files\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.0\System.Xml.dll" /reference:"C:\Program Files\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.0\System.Xml.Linq.dll" /debug+ /debug:full /filealign:512 /optimize- /out:obj\Debug\Sitecore.Mvc.Contrib.Test.dll /target:library ..\..\..\src\Common\CommonAssemblyInfo.cs ..\..\..\src\Common\CommonVersionInfo.cs Controllers\ControllerBaseShould.cs Controllers\AreaControllerRunnerTests.cs Data\Validators\ControllerRenderingValidatorShould.cs Data\Validators\ControllerValidatorShould.cs GlobalSuppressions.cs Pipelines\MvcEvents\InjectionFilterShould.cs Pipelines\Response\GetRenderer\AreaControllerShould.cs Presentation\RenderingItemProviderShould.cs Presentation\Renderer\AreaControllerRendererShould.cs Presentation\Renderer\ChildActionRendererShould.cs Properties\AssemblyInfo.cs TestItem.cs Utils\HttpContextHelpers.cs "D:\TeamCity\Install\buildAgent\temp\buildTmp\.NETFramework,Version=v4.0.AssemblyAttributes.cs"
[13:14:00][Csc] Utils\HttpContextHelpers.cs(4, 11): error CS0012: The type 'System.ComponentModel.DataAnnotations.ValidationAttribute' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.ComponentModel.DataAnnotations, Version=4.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'.
[13:14:01][Csc] Utils\HttpContextHelpers.cs(4, 11): error CS0012: The type 'System.Web.WebPages.Razor.WebRazorHostFactory' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Web.WebPages.Razor, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'.
[13:14:01][Csc] Utils\HttpContextHelpers.cs(4, 11): error CS0012: The type 'System.Web.WebPages.StartPage' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Web.WebPages, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'.
[13:14:01][Csc] Utils\HttpContextHelpers.cs(4, 11): error CS0012: The type 'System.Web.WebPages.WebPageBase' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Web.WebPages, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'.
[13:14:01][Csc] Utils\HttpContextHelpers.cs(4, 11): error CS0012: The type 'System.Configuration.Provider.ProviderCollection' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Configuration, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
[13:14:01][Csc] Utils\HttpContextHelpers.cs(4, 11): error CS0012: The type 'System.Configuration.Provider.ProviderBase' is defined in an assembly that is not referenced. You must add a reference to assembly 'System.Configuration, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
[13:14:02][tests\unit-test\Sitecore.Mvc.Contrib.Test\Sitecore.Mvc.Contrib.Test.csproj] Project tests\unit-test\Sitecore.Mvc.Contrib.Test\Sitecore.Mvc.Contrib.Test.csproj failed.

Add Form processing examples

Provide examples of form processing in the Sample project.

Error with Sitecore 8

When using the project on Sitecore 8, there is an exception:

A route named 'SocialConnectorSpecific' is already in the route collection. Route names must be unique.
Parameter name: name

If you comment out AreaRegistration.RegisterAllAreas() in the PostStart, everything works fine

Area Controller not able to UseChildActionBehaviour

The configuration needs to be set on the AreaController template and be read by the getRenderer pipeline for AreaController.

Test failing

All tests relying on TestItem are currently broken.

Add DataSource and Parameters support to rendering types

Provide support for DataSource and Parameters in Controller and view renderings.

I cannot find MVC Contrib from Nuget

Command 'PM> Install-Package Sitecore.Mvc.Contrib' does not work for me.

Is http://54.247.113.114:8080/nuget down?

Sample project installs unused item

/sitecore/content/Mvc Sample seems to be a leftover and no longer used...

Explore async actions

Multiple .sln files

There are two Sitecore.Mvc.Contrib.sln. I suspect the one under src is redundant.

Sample for ChildActionRenderer

Need to add a page on sample site for the ChildActionRenderer.