sitegeist/sitegeist.archaeopteryx

The missing link editor for Neos

sitegeist.archaeopteryx's Issues

BUG: Setting link in inline mode without selecting text breaks state

Support for new Media UI

I don't know how this could be achieved, but it would be great to support the new Media UI if installed. This is already possible for the Image and Asset property editor in Neos, but it doesn't work here. I assume it's a hardcoded dependency to the "old" Media UI?

UX: Don't show current link in non-matching tab

Currently, if a link is set, it is displayed in all tabs:

This is misleading because in the example above an external link is displayed as link target inside the internal page tab.

IMO it would make more sense to place this box outside the tab navigation:

What do you think?

You still have changes - Warning after deleting and updating required inspector link-property

Hello,

the problem is a bit more complicated to describe, so a slightly different listing:

Initial situation:

• Property in Inspector is set to required
• A link (NodeType) is already integrated and published

What do I do that the error comes:

• Remove link via trash can
• Apply button remains disabled due to required
• Click on "Create Link
• Window of Archaeopteryx opens
• Clicking on the window brings the error message: "You still have changes. What do you want to do with them?"

So I can continue working:

• Click on Throw away

CustomLink editor breaks layout

I installed Archaeopteryx 1.4.0 with Neos UI version: v7.3.20

The modal is too small for all 5 tabs and breaks:

Add configuration option like `nodeTypes` of the original Neos.UI Link Editor

At the moment an option to restrict the allowed node types for the node link type editor is missing. A configuration option and a corresponding visual indication as well as a selection logic need to be added the the node link type editor.

Production JS Build (currently almost bigger than the whole UI 2.2 MB)

i think we target ES5 (we can better straight go to 2020) also its not minified at all and might even be the dev build.

UI Improvment

Is it possible to remove the css max-width: 264px; at the .node__header__labelWrapper___dJ7OH at the document tree list?

Otherwise, the long page names will be shortened even though there is more space available.

TASK: Remove property converter workaround with bugfix merged

https://github.com/sitegeist/Sitegeist.Archaeopteryx/blob/9322b9cb8e4824bcaf7aaa247c23b1244a2f1167/Classes/LinkToArrayForNeosUiConverter.php#L12C16-L12C78 will be obsolete with neos/neos-development-collection#4638 merged and released.

"tel:" link isn't working

I already had some links on my site using the tel: ... scheme.

After installing Archaeopteryx and trying to edit these links, the following error occurs:

TypeError: Cannot read property 'useResolvedModel' of null
    at DialogWithValue (.../_Resources/Static/Packages/Sitegeist.Archaeopteryx/JavaScript/Plugin.js?f0f01c36:34134:27)
    at oh (.../_Resources/Static/Packages/Neos.Neos.Ui.Compiled/JavaScript/Host.js?41a91e0c:2:1031880)
    at xo (.../_Resources/Static/Packages/Neos.Neos.Ui.Compiled/JavaScript/Host.js?41a91e0c:2:1079133)
    at Qj (.../_Resources/Static/Packages/Neos.Neos.Ui.Compiled/JavaScript/Host.js?41a91e0c:2:1071446)
    at Kj (.../_Resources/Static/Packages/Neos.Neos.Ui.Compiled/JavaScript/Host.js?41a91e0c:2:1071371)
    at yj (.../_Resources/Static/Packages/Neos.Neos.Ui.Compiled/JavaScript/Host.js?41a91e0c:2:1068278)
    at .../_Resources/Static/Packages/Neos.Neos.Ui.Compiled/JavaScript/Host.js?41a91e0c:2:1018959
    at w.unstable_runWithPriority (.../_Resources/Static/Packages/Neos.Neos.Ui.Compiled/JavaScript/Host.js?41a91e0c:2:1095451)
    at cg (.../_Resources/Static/Packages/Neos.Neos.Ui.Compiled/JavaScript/Host.js?41a91e0c:2:1018668)
    at fg (.../_Resources/Static/Packages/Neos.Neos.Ui.Compiled/JavaScript/Host.js?41a91e0c:2:1018904)

It would also be great to have the tel: scheme as an option, similar to mailto:

Allow disabling unneeded linkTypes

Currently, all linkTypes are always visible in the Link Editor. I know that is meant more or less a drop-in replacement for the Link Editor, but the original is already hard to use. It would be a massive advantage if the tabs could be unset or disabled. That way the editor could be used for an external link, internal link, phone number etc. only.

Abstract node type constraints not working in Neos 8.3.7+

Due to a core change in neos/neos-development-collection#4561 (comment), using abstract node types for contraints in Sitegeist.Archaeopteryx:Node doesn't work anymore.

Hash link does not work

If you have an link with an hash (e.g. #newsletter) the editor returns following error:

Could not find an editor suitable for "#newsletter"

And if I try to click + Create Link I got the error:

TypeError
can't access property "useResolvedModel", linkType is null

FEATURE: Can we support the Shortcut [ Cmd + K ]

That would mimic the behavior of the normal link editor.

Deleted referenced node is not removable

Neos 7.3
Sitegeist.Archaeopteryx 1.3.1

If a document node is referenced to an deleted node, it shows an exception. The exception doesn't render the buttons to edit/remove the link. It is only possible to remove it by hand within the database.

BUG: `relNofollow` is not applied to link

Bildschirmaufnahme.2023-10-23.um.17.43.32.mov

As far as i can tell, this

In https://github.com/sitegeist/Sitegeist.Archaeopteryx/blame/a003751455ccd6759cd6968dea11c08481ee4296/Neos.Ui/core/src/application/Dialog/Dialog.tsx#L33-L40 we filter out unsupported link options, but as we declare the field relNofollow internally with a different casing relNoFollow, we always filter it out:

Sitegeist.Archaeopteryx/Neos.Ui/core/src/application/Dialog/Settings.tsx

Lines 69 to 72 in a003751

	{props.enabledLinkOptions.includes('relNofollow') ? (
	<Field<boolean>
	type="checkbox"
	name="options.relNoFollow"

My thesis is that the relNofollow has never worked before.

Does not work inside RichTextEditor if validation of another property failed

If you use a property with the RichTextEditor, you cannot set a link because the link editor modal is behind the Rich Text Editor.

How to test

• Configure a RTE property:

    foo:
      type: string
      ui:
        label: 'Foo'
        reloadIfChanged: true
        inspector:
          group: foo
          editor: 'Neos.Neos/Inspector/Editors/RichTextEditor'
          editorOptions:
            linking:
              'Sitegeist.Archaeopteryx':
                linkTypes:
                  'Sitegeist.Archaeopteryx:Node':
                    allowedNodeTypes: ['My.Site:Document.Mixin.LinkablePage']

• Open the RTE
• Try adding a link

BUG: Overlay / stacked dialog issue with Sitegeist.Archaeopteryx Editor in Neos UI 8.3.1^

Description

When creating a link with the Sitegeist.Archaeopteryx Editor the Link overlay from the editor is stacked under the UI overlay. But the link overlay should be displayed first.

Steps to Reproduce

1. Install (https://github.com/sitegeist/Sitegeist.Archaeopteryx)
2. Adjust your NodeType for example the TextWithImage NodeType:

    link:
      type: string
      ui:
        label: Link
        showInCreationDialog: true
        help:
          message: 'Create a link'
        inspector:
          editor: 'Sitegeist.Archaeopteryx/Inspector/Editors/LinkEditor'

3. Try too create a link.

Expected behavior

The overlay of from the Archaeopteryx editor should be at the first.

Actual behavior

The link overlay from the Archaeopteryx gets stacked under the UI overlay

neos-ui-overlay.mov

[What actually happened]

Affected Versions

Neos: 8.3

UI: 8.3.3

You can get this information by running composer show or using the package management module within Neos.
The UI version can also be found inside the left sidebar after version 1.0.3.

Originally posted by @crydotsnake in neos/neos-ui#3583

BUG: Node-Links with Hashes

In the Neos Core link editor, editors defined node links with additional hashs in the form node://XXXX#section-id

This is supported and work, now installing Archaeopteryx leads to error, e.g. "node://7b7a2070-0e85-44b6-92b7-c4135e3555b5#ausschreibungen" breaks like this making it impossible to edit:

The same error can be achieved by picking the custom editor and then entering "node://7b7a2070-0e85-44b6-92b7-c4135e3555b5#ausschreibungen"

As a minimum the editor should show this as a custom link and not fully break. Fixed with #60

Turn off some editors

It would be nice of an editor could be turned of:

editor: 'Sitegeist.Archaeopteryx/Inspector/Editors/LinkEditor'
editorOptions:
  linkTypes:
    'Sitegeist.Archaeopteryx:Node': false
    'Sitegeist.Archaeopteryx:MailTo': false

Make tab sorting configurable

With the current version, the sorting of the tabs is more in line with what we expect to be normally requirements, however I still think it would be great to have the editors sortable.

What do you think?

Node tree is not loading for users with restricted roles

The node tree is not loading corretly, if the user role has node acces restricts and therefore can not acces every node in the document tree.

Improve state when opening existing links

When an existing link is edited only the tab of this linktype is visible. The other tabs become visible once the link is cleared.

I would expect that all tabs are visible from the start and a link can be overridden by assigning a new target in any tab.

Missing setting "TargetBlank" and "RelNofollow" in Inspector view

Thanks for the nice Link-Editor!

Am I missing something or is it not possible to activate the options "TargetBlank" and "RelNofollow" in the Inspector view?

  inspector:
    group: 'image'
    editor: 'Sitegeist.Archaeopteryx/Inspector/Editors/LinkEditor'
    editorOptions:
      # doesn't work
      # linking:
         #  relNofollow: true
         # targetBlank: true
      linkTypes:
        # doesn't work
        # 'Sitegeist.Archaeopteryx:Web':
         #  relNofollow: true
         # targetBlank: true
        'Sitegeist.Archaeopteryx:PhoneNumber':
          enabled: false

Naming of the "document" tab

The editor Sitegeist.Archaeopteryx:Node is called "Document" in English and "Dokument" in German, which is in line with the term Document node type and also "Document tree"/"Dokumentenbaum". While I see this consistency, when setting a link, it can be misleading because at least in German, you would think that a "Document" is something like a PDF file.

I'm not sure what others think about the naming. Maybe it would just be good if there was a possibility to override the label.