Giter Site home page Giter Site logo

Comments (3)

gregpriday avatar gregpriday commented on August 30, 2024

Hi Vlad

Thanks for the suggestion. You're correct, there should be more data for that filter.

I'm having a proper look at all the filters in siteorigin_panels_render, and I can see there are a few inconsistencies with what data is being passed to each one. I'm going to think through this properly to try ensure we don't introduce any more inconsistencies.

Right now, I'm thinking that if we introduce a ['current'] key to the $panels_data array that includes the current row and cell indexes, that should be enough to ensure backwards comptibility and a good level of consistency.

I'll experiment with this idea though.

from siteorigin-panels.

vladkucherov avatar vladkucherov commented on August 30, 2024

That would be a solution, but it may take more resources then needed. the panels data object is already pretty loaded with data... maybe you'll run 2 filters and call this one deprecated?

from siteorigin-panels.

AlexGStapleton avatar AlexGStapleton commented on August 30, 2024

It appears this issue was resolved sometime around the 2.4 update. siteorigin_panels_row_cell_classes filter now includes an additional argument, $cell. This is equivalent to $panels_data['grids'][$gi].

from siteorigin-panels.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.