sixletters/pe

pe's Issues

The error message is wrong

I waited one minute to make sure that the limit wasnt reached and then keyed in a nonsense stock, the error should be that the stock is invalidated however, the actual error printed says that the API limit has been reached

Message spacing

you guys should put a spacing between the date and the time, so that the user can read it properly. If not it will just look like a long line of rubbish numbers

Abstraction of warning

The following should be abstracted so that the user does not know of the error

UG and Actual message dont match

The messages that were shown on UG showed loss of, however in the application it was profit of.

Wrong format yet it still works

I was able to key in buy /tsla 1 2 and somehow it only took the 1 as in input instead of printing an error or warning message.

Should use sequence diagram to explain sequences rathter than object diagrams

Across the DG, alot of sequences were explained with multiple object diagrams, when you could be explaining it all with one sequence diagram

DG diagram labeling

Diagrams in DG were not labelled.

API limit reached although I just started

I keyed in the first command which was "buy stock /2" and an API limit reached was printed

An empty blank page

Im not sure if it has to do with the exporting etc. But on your first page of the TP, there is a blank white space.

Command class repititiveness

Not all 7 child has to be squeezed into the diagram, instead as mentioned in the notes, you could show one proxy child to represent all 8.

Unsure of what stocks are available in database

The users are not informed of what stocks are actually available to buy. Is there a full list such as on the actual stock market? It just states that we can buy or sell stocks but we are not informed of what we can buy or where we can look for this info. And if it is based on the actual stock market, there should be an explicit mentioning that every stock is based on real world numbers.

Storage component not mentioned at all through the DG.

The storage compoenent was briefly mentioned with one line at the start of the DG, afterwards it was missing from all diagrams and sequences. The storing of the data was not explained at all.

Neatness of command summary

Command summary can be way neater and better formatted. At the same time putting an example of expected outcome and input would be good

Space infront of command, yet it works

Im not sure if this was intentional but I put a lot of space infron tof my command prompt and it still works.

Wrong error message printed

The quanity was correct, however the error was in placing the space infron of stock name, however this was not synchronous with the error message

DG diagram issue

I dont think it is neccessary to add in class method inside the diagram on the arrow. And on exit may not be a suitable return type or label as well.