sixoverground/tang

Stripe subscriptions

tang's Issues

Cache data and a big log file present

Hey there,

My name is Maciej Mensfeld and I run security & quality assessment for OSS libraries using Diffend.io.

While reviewing the changes for this lib, I noticed, that:

• the cache directory is being included in the release
• spec/tang_app/log/test.log is included in the release

Names of dirs and files that imho should not be in the final release:

• spec/tang_app/tmp
• spec/tang_app/log

Is this needed? Usually, it's added by mistake and causes:

a) confusion
b) problems when tracking changes
c) extensive library size

Removing those two mentioned, shaves 70MB if space when using this lib.

If the presence of cache data is valid I would love the reasoning. Thanks!

Tell us more

hi, this codebase looks like the most comprehensive reference for Stripe billing with Rails on Github. I'm very glad you open-sourced it. The code quality is excellent, definitely top 5% of what I'm used to seeing.

Can you tell us a little more about what features it implements / add to the README? And has the code been battle-tested in production?