sjmeverett/express-decorators

ES2015 decorators for express

express-decorators's Issues

route method uppercase throw error when register

https://github.com/stewartml/express-decorators/blob/313afc90951fea5ae3ef2206e2525d46bcf2b919/src/lib/index.ts#L214

when using @route('GET', '/some-path'), the register fails, since router['GET'] is undefined.

it should be router[route.method.toLowerCase()]

HapiJS

I'd love to see something similar for HapiJS!

Would you mind if I created a library based off this one, but for HapiJS? Or if you are planning to, I'd be willing to contribute/test.

Custom decorator.

Hello. Could you add an instruction to create a custom decorator? What issues I get: the context of the controller class is lost. Could you describe how do you use Reflect Metadata?

Regards.

How to add middleware for all controller actions?

We have a middleware to be shared among multiple controllers. We also want the middleware being called in every action.

@web.use requires a member function as the middleware, which is not suitable.
@web.middleware assigns middleware to a single action, which is not suitable as well.

Usage with Babel?

I am not using TypeScript and would still like to use these decorators. Are they also functional when using Babel?

Thanks!

TypeScript definitions?

Hi, typescript newbie here.
I'm trying to use the module in my nodejs+expressjs+typescript backend app and it seems I need to install the reference via tsd install to make it work. Right? Or am I missing something?
Because when I compile my project, I get this

app/app.ts(8,23): error TS2307: Cannot find module 'express-decorators/load'.

I fully understand this is a ES6 module, but it seems really useful for my case too.

Thanks in advance!

Cannot handle errors

an error handling middleware should be able to handle exceptions in the action, for example:

app.use((err, req, res, next) => {
  // ....
});

However when using this module I only got:

Error: .....
    at Handler.<anonymous> (....)
    at ....../node_modules/express-decorators/index.js:45:38

route del throw error when register

https://github.com/stewartml/express-decorators/blob/313afc90951fea5ae3ef2206e2525d46bcf2b919/src/lib/index.ts#L74

the 'del' throws error during register, since router['del'] is undefined, I am using express 4.17.1

It should be route('delete', path, middleware)

Multiple middleware needs to be specified in an unconventional order

Given the following code:

@web.get('/')
@web.middleware(a)
@web.middleware(b)
@web.middleware(c)
indexAction(req, res, next) { /* <…> */ }

Middlewares will be executed in such order: c → b → a. Which is not what you'd expect.

As a quick workaround, I changed the order in which I attach middlewares, but I guess it's something that could be addressed at library level.