skedgo/tripkit-ios

SkedGo's TripKit for iOS (and macOS)

tripkit-ios's Issues

504 Gateway Time-out when posting to: POST /satapp-beta/auth/signin/53e5744a-a815-417a-958c-6c7e9c44e13f

@MarianoTucat

I'm getting a lot of Timeouts when trying to make a quick booking:

Request:
POST /satapp-beta/auth/signin/53e5744a-a815-417a-958c-6c7e9c44e13f HTTP/1.1
Complete request/response
https://gist.github.com/danitinez/d2e3e6c0af3db0808472c5fe8cba9f64

Trip-kit sdk not parsing near lyft vehicles (realTimeAlternativeVehicles)

Hi guys, @nighthawk, @MarianoTucat I noticed that I can't get segment.realTimeAlternativeVehicles, trip-kit is not parsing the Locations of those vehicles and we need them to show on the map.

I made a quick fix on the sdk but I'm not sure if it's the right solution. The issue I think is that the sdk is only parsing this information for Public Service buses and no for lyft vehicles.

Do you plan to push an update for this? Should I do a PR for my quick fix?

Thanks

Mode Identifier is missing for some services and transport modes with bookingInfo available.

Hi guys, how are you?

I noticed that some segments with "booking" information are not filled with a "ModeInfo", with the proper "identifier" string, making difficult for us to show some data depending the transport mode. This is for segments of type "Collect", found in "Car2Go" or "Denver B-Cycle" for example.

As we need the mode identifier, is it ok to expect that the next segment of a "collect" segment, will hold the correct mode identifier?

Thanks

TKBookingConfirmation don't have a cancel action after trip update

Hi @nighthawk

After doing a trip update
router.downloadTrip(url, intoTripKitContext: context) { updatedTrip in ....

TKBookingConfirmation object don't have the cancel action on "actions" array. Is this expected?

Thanks

TKReporter should delay calls to reportPlannedTrip

Either by default or as an option. This would let apps allow calling this often, e.g., while paging through trips, but only having the last one reported.

Unauthorized, invalid token, after lyft authorization went ok

@MarianoTucat
I'm getting:

{
"usererror": true,
"errorCode": 470,
"title": "booking not successful",
"subtitle": "Unauthorized, invalid token.",
"error": "Unauthorized"
}

just after login to lyft. Is not this already solved?

Thanks

https://gist.github.com/danitinez/5414e2ca21536c585330ab43d749faae

We are not receiving a "cancel" action on booking with "approaching" status

@MarianoTucat @nighthawk

Here is the request/response with the Trip:
https://gist.github.com/danitinez/22d0260a900c375990b0483e7b36b7e5

The cancel action is missing on actions array. So we can't cancel the trip from our app.

Quick Booking: Bad Request

First call:
https://gist.github.com/danitinez/23c1851f7dd492d79821e210dcb11705

Second call to Sign In:
https://gist.github.com/danitinez/984d30440fea8c2146e17d21b540845a

This last one is giving a Bad Request error.

Trip distance

Is there a property or method to get the trip total distance?

TKInterAppCommunicator: Add Waze

Described here: https://www.waze.com/about/dev

Better Carthage support

• Declare dependencies in Cartfile
• Build TripKit, TripKitUI, TripKitBookings and TripKitInterApp as separate frameworks

Clean up how/where settings are saved

These classes could do with a clean-up and consolidation:

• TKSettings
• TKUserProfileHelper

bearing missing for "realTimeVehicle" when booking is Accepted

@MarianoTucat after a quick booking is done, realtimeVehicle is missing the bearing angle.

"realtimeVehicle": {
                    "id": "Lyft",
                    "lastUpdate": 1466717072,
                    "location": {
                        "lat": 34.14779,
                        "lng": -118.14452
                    }
                },

Don't send all-zero weights

Fine to omit the wp query parameter. It's better than sending all-zeroes.

More specific identifiers in results

Especially for public transport (e.g., pt_pub_bus) and TNCs (e.g., ps_tnc_lyft)

modeIdentifier is set to transport modes (like "ps_tnc_LYFT") for stationary segments

@MarianoTucat , modeIdentifier is set to transport modes (like "ps_tnc_LYFT") for "waiting" and parking segments. This breaks the icon representation of each segment on our app.

Will this mode identifier change for stationary segments?

https://gist.github.com/d9c4ac9edf7ed36a6367b7a2e9fe881a

segment.realTimeAlternativeVehicles empty when the booking is cancelled, or pending

I think this goes to @MarianoTucat

The issue is that after cancelling a quick booking, and when the status of the booking is "pending", realTimeAlternativeVehicles is empty for the trip, and I can't refresh the map with the near lyft vehicles.

Is this expected behaviour? Is this the only way to get the near vehicles?

Thanks.

Lyft: Too Many request

@MarianoTucat Server is returning "Too many request", and it's not on json format. This is breaking the parsing on our end.

https://gist.github.com/danitinez/cf18a999e8299f6c4830cb8a0a10f480

Class TKQuickBooking don't expose ETA through generated-Swift.h

For some reason, ETA variable on TKQuickBooking is not exported on generated-Swift.h

SWIFT_CLASS("_TtC5la_go14TKQuickBooking")
@interface TKQuickBooking : NSObject

/// Localised identifying this booking option
@property (nonatomic, readonly, copy) NSString * _Nonnull title;

/// Localised description
@property (nonatomic, readonly, copy) NSString * _Nullable subtitle;

/// URL to book this option. If possible, this will book it without further confirmation. These URLs are meant to be used with an instance of BPKBookingViewController.
@property (nonatomic, readonly, strong) NSURL * _Nonnull bookingURL;
@property (nonatomic, readonly, copy) NSString * _Nonnull bookingTitle;

/// URL to fetch updated trip that's using this booking options. Only present if there would be a change to the trip.
@property (nonatomic, readonly, strong) NSURL * _Nullable tripUpdateURL;

/// Optional URL for image identifying this booking option
@property (nonatomic, readonly, strong) NSURL * _Nullable imageURL;

/// Optional price for this option
@property (nonatomic, readonly, strong) TKQuickBookingPrice * _Nullable price;

/// Localised human-friendly string, e.g., "$10"
@property (nonatomic, readonly, copy) NSString * _Nullable priceString;
@end

Can't see TKQuickBookingHelper on generated-Swift.h branch:simplerBookings6342

I can't access TKQuickBookingHelper from ObjC code. It seems TKQuickBookingHelper is not exporting to generated-Swift.h. TKQuickBooking & TKQuickBookingPrice structs have to be changed to classes to can be exported as well.