skeeto/cl-lib-highlight

Syntax highlighting for Emacs' cl-lib.

cl-lib-highlight's Issues

Incorrect warning highlighting

The original function will only highlight tokens if:

1. they constitute the whole word.
2. they are in the head position of an s-expression.

This means that (replace-regexp-in-string ...) will get a warning overlay, even though it shouldn't. (mapcar 'replace ...) will not be highlighted, even though it should.

I suggest this fix:

(defun cl-lib-highlight-warn-cl-initialize ()
  "Mark all of the old cl functions with `flyspell-incorrect'."
  (require 'flyspell)
  (let* ((opt (regexp-opt (mapcar #'symbol-name cl-lib-highlight-cl) t))
         (old (list (concat "\\_<" opt "\\_>")
                    '(1 'flyspell-incorrect))))
    (font-lock-add-keywords 'emacs-lisp-mode (list old))
    (font-lock-add-keywords 'lisp-interaction-mode (list old))))

which should cater for hyphens and such.

Appears to require Emacs 24

cl-lib 0.3 doesn't seem to have cl-flet (?), so on Emacs 23.3, I get a warning at compilation time:

cl-lib-highlight.el:90:4:Warning: `(opt (syms) (regexp-opt (mapcar (function
    symbol-name) syms) t))' is a malformed function

and then an invalid function error at the same line when loading cl-lib-highlight.