skempin/reactjs-tmdb-app

Responsive React 'The Movie Database' (TMDb) App

reactjs-tmdb-app's Issues

Gradient do not fill entire screen

On large screens the background gradient don't fill the entire cover image

Example: http://d.pr/i/MIql

Disclaimer

Did you have an issue with showing movie posters in the demo on the gh-page site? Is it a requirement to put a link to a disclaimer or fair use copyright?

API KEY

Hey, I was going through your project, and I noticed, that you have your TMDB api key there open in your project. Hence I am bringing it to your notice that remove your api key because it's not a good idea to leave your working api key openly in the repo.

Search input broken

Looks nice. Keyboard doesn't pop up in search on iPhone 6S. Checking Mac browser tomorrow.

Same problem with entering search on the web through Safari. You have to hold the mouse in the field to enter a search term. It only works in Google Chrome. But here it is lightning fast. Looking forward to a fix ;)

When searching a different language title

When i search for a japanese movie title e.g. 'Love exposure' the search results show the title in Japanese.

an issue when run gulp watch

ReferenceError: primordials is not defined
at fs.js:40:5

Build is failing - what to do?

After running $: gulp watch

==== C stack trace ===============================

0   node                                0x0000000100bce203 v8::base::debug::StackTrace::StackTrace() + 19
1   node                                0x0000000100bcb389 V8_Fatal + 233
2   node                                0x0000000100147afa v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute) + 330
3   fse.node                            0x0000000102784bb1 fse::FSEvents::Initialize(v8::Local<v8::Object>) + 197
4   node                                0x00000001009cf21f node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&) + 854
5   node                                0x000000010017c39a v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) + 378
6   node                                0x00000001001e023c v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) + 924
7   node                                0x00000001001df679 v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) + 281
8   ???                                 0x000033a1d30063a7 0x0 + 56770122769319
9   ???                                 0x000033a1d335049a 0x0 + 56770126218394

fish: 'sudo gulp watch' terminated by signal SIGILL (Illegal instruction)

gulp watch: failed

I've got these when running command: gulp watch

Fatal error in ../deps/v8/src/api.cc, line 1248

Check failed: !value_obj->IsJSReceiver() || value_obj->IsTemplateInfo().

Illegal instruction: 4

i got it fixed after ran these to get updates from packages:

npm i -g npm-check-updates
npm-check-updates -u
npm install
gulp watch

And now got another issue:

[12:22:17] Starting 'html'...
[12:22:17] 'html' errored after 33 ms
[12:22:17] TypeError: $.useref.assets is not a function

gulp watch error

Hi man,

first of all thanks for the project. Looks interesting and cause i love movies i wanted to clone and run it. When i go through your steps from your readme i get the following error while executing gulp watch. Can you help?

➜  reactjs-tmdb-app git:(master) ✗ gulp watch
assert.js:350
    throw err;
    ^

AssertionError [ERR_ASSERTION]: Task function must be specified

Background image returns 'null'

I noticed that there isn't a fallback image for the background.
The response for that comes as https://image.tmdb.org/t/p/originalnull

To test that I've typed in the movie title Killer: A Journal of Murder (an excellent movie, btw)

Congrats with the project. Looks pretty neat.