skhayrulin/x_engine

I'm planning collect here all my work on rewrote version of Sibernetic engine

Hello World

x_engine's Issues

Add unit tests

Tests list:

• Check configuration test not correct number of particles not different amount of position and velocity of particles should give me an error.
• Not right type for particles position in file and
• Error with cl code
  ....

Add program arguments list

Add unittests

Add command line arguments parser

• add class for command line arguments parsing
• add description in README.md

Add throwing an exception here

If there were some problems during compiling the kernel source (we fall into the initialize_ocl in line 37), no ocl_solvers would be created, but execution would be continued. As a result, we would fall into make_partition and get division by zero in line 90 (in sph_model.hpp).

x_engine/inc/solver_container.hpp

Line 41 in 62e8a74

std::cout << ex.what() << std::endl;

Should variable size_t end be minus 1 ?

May be this line should be like this:
partitions.push_back(partition{0, static_cast<size_t>(size() - 1)});
?

If we have one device and we are trying to get last the last element in partition, it's desirable to write
model->get_particles().at(p.end);
which results in seg fault.
May be I'm wrong?

x_engine/inc/sph_model.hpp

Line 87 in 62e8a74

partitions.push_back(partition{0, static_cast<size_t>(size())});

There is no check for the case when number of velocities is less than number of positions.

x_engine/inc/sph_model.hpp

Line 263 in 2df7066

if (index >= particles.size())

swap these lines: size_t cell_id; size_t type_;

x_engine/cl_code/sph_cl_code.cl

Line 64 in 10b933e

size_t cell_id;

In the structure particle (in particle.h) the sequence of feilds is:

container pos;
container vel;
size_t type;
size_t cell_id;
size_t get_dim() const { return dim; }
T density;
T pressure;

In the structure particle_f (and also in particle_d) the sequence of feilds is:

float4 pos;
float4 vel;
size_t cell_id;
size_t type_;
float density;
float pressure;

As you can see, the feilds cell_id and type are written in a different order. That is the reason of data consistency problem.

Make configuration as JSON format