skills/hello-github-actions

Create a GitHub Action and use it in a workflow.

hello-github-actions's Issues

Title

Summary

A clear and concise description of what the bug is, and what you expected to happen.

How to reproduce

1. Go to '...'
2. Click on '...'
3. Scroll down to '...'
4. See error

Please include screenshots.

Additional context

Add any other context about the problem here.

[Bug] GitHub Action failure when creating new repo from template

Describe the bug
I started the GitHub Actions skills course and began by creating my own repository from the skills repo template. During that process, a GitHub Action runs to set up the new repo. I saw the following failure that prevented the GH Action from creating a PR in my repo: https://github.com/gclhub/hello-github-actions/actions/runs/3876581724/jobs/6610590261

To Reproduce
Follow the steps outlined at https://github.com/skills/hello-github-actions#how-to-start-this-course

Expected behavior
The PR should be created successfully in the new repo created from the template.

[Feature]

Summary

A clear and concise description of what the problem is, and what you solution you want.

Changes

What changes this feature would introduce. Any risks these changes involve. Any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

[Bug] Lab errors with false positive emoji error

Describe the bug
The existing - character in the word private-repositories causes a false positive in the emoji checking script.

To Reproduce
Steps to reproduce the behavior:

1. Run the lab - this generates an unexpected error after step 4 indicating that the line containing "private-repositories" contains an emoji not using an emoji shortcode

Expected behavior
Expected the lab to pass after completing the full workflow file

Screenshots
If applicable, add screenshots to help explain your problem.

Device information

• Type: 16" MBP (M1)
• OS: Monterey 12.4
• Browser Chrome
• Version 102.0.5005.61 (Official Build) (arm64)

Additional context
Add any other context about the problem here.

[Bug]

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Device information

• Type: [e.g. iPhone6]
• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

[Bug]

Summary

A clear and concise description of what the bug is, and what you expected to happen.

How to reproduce

1. Go to '...'
2. Click on '...'
3. Scroll down to '...'
4. See error

Please include screenshots.

Additional context

Add any other context about the problem here.

We are open to pull requests if you have suggestions :)

We are open to pull requests if you have suggestions :)

Originally posted by @heiskr in skills/review-pull-requests#6 (comment)

[Bug] pr not being created after step 3

I am following the steps of this skill, but after the step # 3, I was expecting a new PR to be created, but it didn't happen

Update discussion links

We now have a designated discussion area for each course! 🎉

This means all of our course links need to be updated to point to the correct discussion page.

There are two places in each course where discussions are referenced

• README.md
• .github > steps > X-finish.md

These two files will have a link to https://github.com/orgs/skills/discussions that will need to be replaced with the link for the course specific discussion. You can find those links here, in the left menu section. Copy the link to the discussion category for this course and replace it in those two files.

Be sure to link your PR to this issue for review.

Investigate deeper YAML checking

According to https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-Readme.md there's a number of YAML tools installed on the Actions runners by default. We could investigate if these tools could offer more checks for learners.

[Feature]

• Complete a issue

Can't make it past step 2

Summary

Hello! I work with @a-a-ron on the ACE team and we were getting told by our learners that they keep getting stalled at Step 2. I went and followed the steps and this happened to me as well.

How to reproduce

1. Complete step 1 of the hello-git-hub-actions skill
2. Copy and paste content into welcome.yml file

For reference here's my repo if you wanna take a gander and ensure I followed the instructions properly.

And a screen shot of my step 2 just incase it helps

Let me know if there's anything I can help out with!

Cheers,
Cami

Change learner action to be a welcome message on new pull requests

Let's update the action the learner creates to welcome new contributors when they make pull requests with an issue comment.

Dn

Nfk

[Bug]

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Device information

• Type: [e.g. iPhone6]
• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

[Feature] Add to the documentation GITHUB_TOKEN requeried permission

Summary

If you fork this project and follow the instructions are they are mentioned, there is no mention about the requeried permission for the GITHUB_TOKEN (default only allow read access)

Changes

Add a note to the documentation to double check the GITHUB_TOKEN permission.

Additional context

Add any other context or screenshots about the feature request here.

[Bug] Button 'Use this template' not showing up

Describe the bug
I just wanted to so this course but unfortunately can't see the 'Use this template' button.

To Reproduce
Steps to reproduce the behavior:

1. Log in to GitHub
2. Navigate to this repository

Expected behavior
See the above mentioned button.

Screenshots

Device information

• Type: Nothing phone
• OS: android
• Browser: chrome
• Version: 109.0.5414.118

[Bug] wrong text fragment on README.md | Step 5: Trigger the workflow | related to #6

In the Step 5: Trigger the workflow on the README.md file, some text must have been left in by mistake when changing the learner action from an emoji check to a welcome message on new pull requests.

In fact, the last part of the text makes no sense with the current learner action, as the workflow will only trigger later, when we are instructed to create the pull request, which can cause confusion to learners.

This is the bit (on bold):

Step 5: Trigger the workflow

You've now got a fully functioning workflow! 😄

Your new action will run any time a new commit is created or pushed to the remote repository. Since you just created a commit, the workflow should have been triggered.

The previous learner action triggered on: push, but the new one triggers on: pull_request: types: [opened].

The learner action change was done on PR #6 by @heiskr, but this text fragment must have passed unnoticed.