Comments (7)
hi @derekchiang, thank you for asking. this is the right place. this smart contract system has been audited by consensys diligence. the audit covered the codebase as of commit b206561. The second phase review after their recommendations covered the codebase as of commit db40cd3.
from tcr.
@kangarang Thanks for the prompt reply! Happy that the project has been audited.
I recommend putting this info in the README since I imagine it's a common question from people who want to use this project in production.
from tcr.
@derekchiang i agree, it is important and should be included in the readme as well as the owner's manual. thanks again for bringing this to our attention.
from tcr.
@kangarang Sorry, but I don't understand which is the commit that refers to the point in time where the audit was complete. By complete I mean that the auditors gave you some concerns / requests, you fixed them, they gave you more etc. At some point the audit was completed in the sense that both parties were happy.
reading the audit report and your response above:
The audit covered the codebase as of commit b2065612. The second phase review after our recommendations covered the codebase as of commit db40cd3c.
Does this mean that both parties determined for the first time at commit db40cd3 that the audit was completed with satisfactory results? Or Is that commit where the second phase of the audit began after initial concerns were addressed, but it was not completed until a later commit?
Hope that question makes sense, thanks!
from tcr.
https://github.com/ConsenSys/tcr-audit
@blinky3713 at db40cd3 both parties were happy. After that commit, all bets are off.
from tcr.
Awesome thanks! Can I suggest tagging this release so developers can find it more easily?
from tcr.
@blinky3713 thanks for the suggestion. finally got around to tagging this badboy: https://github.com/skmgoldin/tcr/releases
from tcr.
Related Issues (20)
- Increase test coverage to at least 85% for branches and 95% for statements HOT 1
- While a listing is locked in a challenge, tokens cannot be withdrawn if the withdrawal would leave the listing with < minDeposit unstakedDeposit HOT 1
- Document how tokens are supported modularly HOT 1
- Publish package to ethpm
- semantic improvements: determineReward / claimReward / tokenClaims HOT 2
- Deprecation warnings when compiling Registry and Parameterizer HOT 1
- Save gas by using a ParameterizerInterface in Registry HOT 2
- Factory/proxy - new token HOT 1
- PLCRFactory fails to deploy - can't deploy TCR HOT 8
- config.json is not actually used HOT 2
- Debug error with factory pattern HOT 1
- Error: Invalid JSON RPC response: "" HOT 1
- Make exitTimeDelay and exitPeriodLen a single value
- Update owners manual to cover new stuff in the develop branch
- Node 10 npm install failure HOT 1
- error deploying proxy script deploy_proxies.js HOT 1
- Update isWhitelisted to return false if a listing is inside its own init or finalize exit windows
- Running migration: 4_parameterizer_factory.js Error encountered, bailing. Network state unknown. Review successful transactions manually. Error: The contract code couldn't be stored, please check your gas amount
- Require check in challenge function has unnecessary part of conditional
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tcr.