REGISTRY
_Application
: add appEndDate
_Challenge
: remove deposit
, add challenger
, change pollID
to challengeID
_NewListingWhitelisted
: change to _ApplicationWhitelisted
Add: (#35 & #45)
_ListingWithdrawn(bytes32 listingHash);
_TouchAndRemoved(bytes32 listingHash);
Current Implementation:
event _Application(bytes32 listingHash, uint deposit, string data);
event _Challenge(bytes32 listingHash, uint deposit, uint pollID, string data);
event _Deposit(bytes32 listingHash, uint added, uint newTotal);
event _Withdrawal(bytes32 listingHash, uint withdrew, uint newTotal);
event _NewListingWhitelisted(bytes32 listingHash);
event _ApplicationRemoved(bytes32 listingHash);
event _ListingRemoved(bytes32 listingHash);
event _ChallengeFailed(uint challengeID);
event _ChallengeSucceeded(uint challengeID);
event _RewardClaimed(address voter, uint challengeID, uint reward);
Proposed implementation:
* event _Application(bytes32 listingHash, uint deposit, uint appEndDate, string data);
* event _Challenge(bytes32 listingHash, address challenger, uint challengeID, string data);
event _Deposit(bytes32 listingHash, uint added, uint newTotal);
event _Withdrawal(bytes32 listingHash, uint withdrew, uint newTotal);
* event _ApplicationWhitelisted(bytes32 listingHash);
event _ApplicationRemoved(bytes32 listingHash);
event _ListingRemoved(bytes32 listingHash);
+ event _ListingWithdrawn(bytes32 listingHash);
+ event _TouchAndRemoved(bytes32 listingHash);
event _ChallengeFailed(uint challengeID);
event _ChallengeSucceeded(uint challengeID);
event _RewardClaimed(address voter, uint challengeID, uint reward);
PARAMETERIZER
Add: (#34)
_RewardClaimed(msg.sender, _challengeID, reward);
Add: (#33)
_ProposalAccepted(bytes32 propID);
_ProposalUnprocessed(bytes32 propID);
_ChallengeSucceeded(uint challengeID);
_ChallengeFailed(uint challengeID);
Current:
event _ReparameterizationProposal(address proposer, string name, uint value, bytes32 propID);
event _NewChallenge(address challenger, bytes32 propID, uint pollID);
Proposed:
event _ReparameterizationProposal(address proposer, string name, uint value, bytes32 propID);
event _NewChallenge(address challenger, bytes32 propID, uint pollID);
+ event _ProposalAccepted(bytes32 propID);
+ event _ProposalUnprocessed(bytes32 propID);
+ event _ChallengeSucceeded(uint challengeID);
+ event _ChallengeFailed(uint challengeID);
+ event _RewardClaimed(address voter, uint challengeID, uint reward);
PLCRVOTING
PollCreated
: change args to commitEndDate
, revealEndDate
Add: underscores for convention
Experimental:
VoteRevealed
: change to (voter, pollID, votesFor, votesAgainst)
Current:
event VoteCommitted(address voter, uint pollID, uint numTokens);
event VoteRevealed(address voter, uint pollID, uint numTokens, uint choice);
event PollCreated(uint voteQuorum, uint commitDuration, uint revealDuration, uint pollID);
event VotingRightsGranted(address voter, uint numTokens);
event VotingRightsWithdrawn(address voter, uint numTokens);
Proposed:
_ event _VoteCommitted(address voter, uint pollID, uint numTokens);
* event _VoteRevealed(address voter, uint pollID, uint votesFor, uint votesAgainst);
* event _PollCreated(uint voteQuorum, uint commitEndDate, uint revealEndDate, uint pollID);
_ event _VotingRightsGranted(address voter, uint numTokens);
_ event _VotingRightsWithdrawn(address voter, uint numTokens);