skyrat-ss13/skyrat-tg

A Skyrat downstream of /tg/station SS13.

Skyrat 13 (/tg/station Downstream)

Website	Link
Git / GitHub cheatsheet	https://www.notion.so/Git-GitHub-61bc81766b2e4c7d9a346db3078ce833
Guide to Modularization	./modular_skyrat/readme.md
Website	https://www.tgstation13.org
Code	https://github.com/Skyrat-SS13/Skyrat-tg
Wiki	https://wiki.skyrat13.space/index.php/Main_Page
Codedocs	https://skyrat-ss13.github.io/Skyrat-tg/
Skyrat 13 Discord	https://discord.com/invite/hGpZ4Z3
Coderbus Discord	https://discord.gg/Vh8TJp9

This is Skyrat's downstream fork of /tg/station created in byond.

Please note that this repository contains sexually explicit content and is not suitable for those under the age of 18.

Space Station 13 is a paranoia-laden round-based roleplaying game set against the backdrop of a nonsensical, metal death trap masquerading as a space station, with charming spritework designed to represent the sci-fi setting and its dangerous undertones. Have fun, and survive!

Important note - TEST YOUR PULL REQUESTS

You are responsible for the testing of your content and providing proof of such in your pull request. You should not mark a pull request ready for review until you have actually tested it. If you require a separate client for testing, you can use a guest account by logging out of BYOND and connecting to your test server. Test merges are not for bug finding, they are for stress tests where local testing simply doesn't allow for this.

DEVELOPMENT FLOWCHART

Modularisation Guide

DOWNLOADING

Downloading

Running on the server

Maps and Away Missions

Compilation

Find BUILD.bat here in the root folder of tgstation, and double click it to initiate the build. It consists of multiple steps and might take around 1-5 minutes to compile.

The long way. Find bin/build.cmd in this folder, and double click it to initiate the build. It consists of multiple steps and might take around 1-5 minutes to compile. If it closes, it means it has finished its job. You can then setup the server normally by opening tgstation.dmb in DreamDaemon.

Building tgstation in DreamMaker directly is deprecated and might produce errors, such as 'tgui.bundle.js': cannot find file.

How to compile in VSCode and other build options.

Contributors

Guides for Contributors

/tg/station HACKMD account - Design documentation here

Interested in some starting lore?

LICENSE

All code after commit 333c566b88108de218d882840e61928a9b759d8f on 2014/31/12 at 4:38 PM PST is licensed under GNU AGPL v3.

All code before commit 333c566b88108de218d882840e61928a9b759d8f on 2014/31/12 at 4:38 PM PST is licensed under GNU GPL v3. (Including tools unless their readme specifies otherwise.)

See LICENSE and GPLv3.txt for more details.

The TGS DMAPI is licensed as a subproject under the MIT license.

See the footer of code/__DEFINES/tgs.dm and code/modules/tgs/LICENSE for the MIT license.

All assets including icons and sound are under a Creative Commons 3.0 BY-SA license unless otherwise indicated.

skyrat-tg's Issues

Infinite Storm Sound in lavaland.

Issue reported from Round ID: 42 (Skyrat SS13 - /TG/ Anthro-Friendly Roleplay Server [Apply on Discord, Weekly Events])

Reporting client version: 513.1536

The bug triggered is still unknown, but once the bug is triggered, the sounds of the storm remains ON, and when this happens, the event of Ash-Storm no longer gets triggered again.

Owai's 10-27 to 10-28 Rebase Test Observations

Mostly minor stuff this time around. Might condense all of my existing feature requests/bug reports into a single issue post since a lot of of the issues/features have been restored/fixed.

10-27

• Metal chairs are off-center, and are really hard to drag yourself/buckle onto. Also, picking them up gives you the old chair sprite.
• Trashbags, when worn on belt, show an odd purple belt around your waist instead of a bag.
• Decomposing Garbage doesn't seem to have a purpose? I wasn't able to find a way to clean it.
• Prisoners cannot latejoin.
• Dark mode is really weird when you rejoin. Your top half will be light mode, but chat will be dark. (Probably Upstream Issue)
• Lolipops still leave bullet pellets behind. (Probably Upstream)
• Carrying is really weird, some things being similar to what I reported here on Citadel. I wasn't able to test as much as I would have liked. Citadel-Station-13/Citadel-Station-13#11901

10-28

• Crab 17 protocol drains money way too fast, i’ve seen it drain 7-15% of funds every ~15 seconds, which means you have almost no time to deal with it. Assuming you lose 10% of your money every time it goes off, you lose all of it in 3 minutes.
• When dragging a borg, specifically, drake/dogborgs, their sprite becomes off-center until they use Rest to fix it.
• Cryo Cells Don't delete a large amount of items. Specifically, PDAs. (I think it deletes the internal ID though.)
• Light replacer not in Equipment Tab (QoL, Upstream) (PR Open Upstream)
• Magi-carp can 1-hit KO people and can be spawned via slime core.
• QM isn’t command and doesn’t have command comms.
• Can’t seem to approve some requests at cargo. Have to manually re-order.
• When making a large order at cargo, it doesn't add total together. QoL
• Cannot make satchels with cloth.
• Mold creature corpses should self decay, it leaves behind a huge mess.
• I heard taur clothing was being weird, but didn't test it myself.
• (Added 11-5-20) I -believe the mechanic where you can pick up/wear pets does not exist.

(Supplemental Info)
Xenobio Carp bad.

/mob/living/simple_animal/hostile/carp/ranged/xenobiology // these are for the xenobio gold slime pool
	gold_core_spawnable = HOSTILE_SPAWN
	allowed_projectile_types = list(/obj/projectile/magic/animate, /obj/projectile/magic/teleport,
	/obj/projectile/magic/door, /obj/projectile/magic/aoe/fireball, /obj/projectile/magic/spellblade, /obj/projectile/magic/arcane_barrage) //thanks Lett1

/mob/living/simple_animal/hostile/carp/ranged/chaos/xenobiology
	gold_core_spawnable = HOSTILE_SPAWN
	allowed_projectile_types = list(/obj/projectile/magic/animate, /obj/projectile/magic/teleport,
	/obj/projectile/magic/door, /obj/projectile/magic/aoe/fireball, /obj/projectile/magic/spellblade, /obj/projectile/magic/arcane_barrage)

Borg Offset

Chairs

[Minor] Icebox Mining spawns a bit wrong

Issue reported from Round ID: 20 (Skyrat SS13 - /TG/ Anthro-Friendly Roleplay Server [Apply on Discord, Weekly Events])

Reporting client version: 513.1536

Cannot say if this is consistent or a fluke. The ladder does allow access to and from the lower level without issue. I expect this is just icebox being improperly prepared for our mining outpost.
Other exits on this level are sealed in by snow, but otherwise passable.

Feature Port Request

Please port the wireless cell chargers and also the mining techs. When I first looked at snowbox I immediately got excited for the possibilities of what a mining tech can do with a multi z level mining base to play with. Also since fauna are more gnarly on tg I can see the base getting damaged-destroyed more often than on the current server

Owai's All-in-One Issue Listing (Updated 12-1-20)

Disclaimer

I just want to start this post out by saying -I'm not complaining- about any of this, it's just a list to keep everything organized. Each missing feature has a subjective importance to different people, so if I highlight something as "Important", it's because it would help with the servers guiding principles, or be an overall -huge- QoL improvement.

This isn’t just a list for maintainers, this is a list that first-time contributors could also look at. At least for some of them. Some of the fixes are relatively easy to do, they just haven’t been done yet. I'm not angry that any of this is missing, but keeping track of things can help them get taken care of instead of forgotten.

I'll be trying as best as possible to strike out the issues on this by hand, or remove them by hand to reduce the bloat on the issue report.

Important™

• V Panel. A lot of people really do want it back.
• Medical Scanner shows implants, but does not show if someone has cybernetics. This is -really- bad if someone tries to defib them, as it apparently fries their cybernetics.
• Voting menu is finicky, it doesn't let you revote, and it doesn't show your choice.

--Somewhat Annoying--

• Carrying is really weird, some things being similar to what I reported here on Citadel. I wasn't able to test as much as I would have liked. Citadel-Station-13/Citadel-Station-13#11901
• Your entire message, when drunk, can get deleted because of burps.
• Cannot use layer shifting while lying down.

"I miss it, but don't -need- it."

• Cannot use PDAs while lying down.

Minor Issues (or observations).

-- Cosmetic / Clothing--

• Griffon/Owl Masks dont work on lizards at all. Unknown about other species.
• Gamer Shirt Sprite Missing (Lizard, Digigrade)
• Gladiator Uniform not showing. (Lizard, Digigrade, Ashwalker)
• Festive Party Hat not showing. (Lizard, Digigrade)
• Griffon / Owl Mask not showing. (Lizard, Digigrade)
• Cargo Uniform not showing. (Lizard, Digigrade)
• Mafia Uniforms may not have digitigrade variants. “Jack Bros” was mentioned.
• Wheelie Heelies might appear strangely on digigrade legs or people with size modifiers.
• Jumpsuits (and other clothing) on taurs acts a bit weird. Specifically with Naga taurs still getting leggings.
• Minor layering issues while dragging people. (Feet appearing through horn/head.)
  

-- Character Customization/Species Stuff--

• Would be nice if character customization menu had more than a black backdrop.
• No mushroom race.
  - Some quirks are missing. Synthetic in particular.
• Race Bloodtypes/Colors (Different colored blood on the floor.)

-- Bugs/Everything Else--

• Slapping someones ass says you slap your own ass. (When the message is displayed to you, not others.
• Bluespace Techs drop Standard Batteries when they peace out.
• Can't carry people up and down stairs (but you can with a ladder)
• Ghosts can't click on stairs to go down them (like with ladders)
• Bluespace Delivery Pods sometimes land but never open. The landing designator also stays there.
• Can’t ghost or cryo as a simplemob.
• Changeling arm has a safety, and it starts on. Every time you spawn the arm, safety comes back on.

Balance Concerns

- You can’t use the succumb verb, and crit lasts a LONG time, meaning you’re stuck in your body until actual death happens. Being in crit can last a VERY long time.

• Garbage bag nerf may need to be ported from Citadel, and possibly done upstream.
• Magicarp can be spawned via slime cores, and they get access to 1 hit kill fireballs, even with the health changes.

Opinionated Gripes

• Obsessed is kind of a gross antag, it basically gives a person to be a creeper to you. (Is this still in?)

--Preference Related.--

• Only one PDA Style. Citcode had several.
• Cannot set your runechat color.

Non-Issues / Tiny Things

• Walking in a blood trail makes your entire body bloody, not just your shoes. This isn’t just blood pools, it’s also footprints.
• Some people dislike that dropping items puts them in a random spot below you, and that -slicing- objects leaves them in a neat little pile. They also can't make tidy tables as chef because the icon doesn't appear when alt-clicked.
• Can’t splat spiders by hand.
• Citadel / Skyrat foods
• A lot of clothing may need to be re-added to vendors.
• No Bluespace Rapid Pipe Dispenser
• Can’t add * to the end of a /say to make it an emote.
• Blood Bank Generator and Organ Synthesizer aren't roundstart map objects.
• Anesthetics / Painkillers aren't implemented, which might be for the best until chaos is balanced down. (Anesthetic Tanks, Morphine, Miner's Salve, Vitrium Froth (For Ashwalkers)
• (?)Cannot Craft Prisoner Jumpsuits
• Cannot Craft Satchel

--Map Related--

• Biogen Access: -All- maps should give chef easy access to biogenerators.
• Delta: Cabin 1 in dorms is scuffed. Doors don't work/cannot be locked.
• Delta: Rage Cage in Maint Bar is set up round start to shock.
• Some of the new holodecks are kinda iffy.
• Some maps permabrigs are really bad.

--Unverified/Need to Test.--

• Flavortext/OOC limit might be smaller on rebase. Needs testing/checked.
• Spray cans are probably missing additions like pawprints and lizard toes.
• Something about Prosthetic Styles not saving?
• Synths can’t get nanites. (This was possible on old base.)
• Paint Cleaner only cleans floor paint. It doesn't clean lights, which means it probably doesn't clean anything else.

--Possibly Upstream--

• Food: Sometimes sliceables aren't edible.
• Food: Can't slice foods with ghetto analogues.
• Cannot make Satchels with Cloth (Will probably PR this upstream.)

--Borg Upgrades/PAI Stuff--

• If you drag a borg, and then stop dragging them, their sprite location doesn't auto-reset. They need to sit to fix it.
• Janitorial Borgs and Service Borgs aren’t combined on TG
• PAI Dynamic Holoforms (So it looks like your character.)
• PAI Dogborg/Drakeborg Holoforms
• Borgs don't seem to have their lights blinked out when they're flashed/disabled. (Needs more testing.)
• Borgs cannot understand Vox. Possibly other languages.
• I'm unsure if borg wreckage/death states are working.
• Plasteel/Plasmaglass (Engiborg)
• Advanced Plasma Cutter
• Advanced PKA

Missing "Features"

• Prescription HUDs
• Can’t pick up / hold / wear pets.
• Towels, Towel Bin, Possibly Colored Towel Bins
• Tool Implants. Specifically, the Janitor one, was mentioned.

--Antag Stuff--

• Antag spawners should say if it’s a natural spawn, or sentience potion spawn.
• Thieving Gloves
• Scream Mask Kit
• Wall-Walking Shoes
• Hacking Implant
• Bluespace Shrinker

Requests / Ideas (Varying "importance.")

• Public Complaints console, similar to a CC fax. If misused, has different smites attached to punish false reports.
• Fax Machine, so lawyers can call CC in an IC way. (That, or a comms console?)
• Mutation Toxins for each race. (To help fix bodies easier without cryo and respawn.)
• Borg Boots, or a lockdown pad, to non-lethally detain borgs. (Think, Borg Handcuffs.)
• Blind people being able to see emotes as a general QoL
• Mechanical prevention of some common round removal methods. (Cremator, Gibber, ect)
• Paper Sheets / Paper Crafting Rework (Cups) Plastic Cups
• Language Skillchips, teaches you an extra language for the shift.
• Blackmajor’s Asteroid Spawning from Citadel

--Cargo Related--

• Medical Spray Crate
• Possibly, some modular bounties.
• Seed crates no have towercaps, grass, or poppy seeds.

Unsorted / New / Whatever / Shower Thoughts

• Hard to clean maints with the Janicart. Can’t attack flashlight to it, and dragging it means you face backwards.
• Heart attacks are semi-untreatable. You can’t defib someone who isn’t dead, and Penthrite is nearly unobtainable.
• Edit showers to just, replenish liquid when both on or off.
• Xenobio slimes should be able to speak common, so people are more likely to join them when sentience potioned
• Citadel Glitter, maybe?

• Booze seemed to take a long time to hit, hit all at once, make your speech unreadable, and then quickly disappear.

Owai-Seek slurs, "Cho wannnt lay ahbooot   on th'e ccuooch for ah...huuuhhh...bit, 'orrr are yuoo head'ed to Owai-Seek whispers, "SSSo, people don't tend to think of what you want or like?"
Owai-Seek slurs, "NNNe'wly booilt, ooor are peuple j'oooooossst th'ah't bahddd?"
Owai-Seek hisses, "I ssswear.... thisss booze makesss me sssound completely ssstupid... or not drunk at all."

• Piggyback layer issue if using ctrl rotate.
  

VVVV (Not added by Author, added by maintainers.) VVVV

Kat's List:

• No Beestation build your own shuttle (I've assigned that to myself, aka Kat).
• Ghost cafe & EORG. People were complaining about EORG, so it probably needs to come back... it's a huge net benefit to have.
• Xenomorph balance (???) needs further investigation to see if they're as laughably piss-easy to defeat even if everything goes right for them as they are on Citcode.

Missing character creation things

Hairstyle missing:
Long twintails

Polychromic Backpack missing.

Loadout items missing:
PAI Device
TTS Device

Comment to loadout:
All the Polychromic i used to use before is now all donator items. :c

Quirks missing:
Mute (Negative)
Allergic (Negative)
Flammable Skin (Negative)
Fist of steel (Positive)
Quick Step (Positive)

Engineering Zoomba Skin is Invisible

Round ID:65

Testmerges: #941 #943 #948

Reproduction: 1. Select cyborg job

2. Select engineering module alt skins
   3.Select Zoomba skin
3. You are now invisible to everyone and yourself.

Mining Zoomba skin works fine unsure of other skins.

'Features' and things we currently have on the main server

Long list. Lots of explanation behind on why I think this should be ported.

In order of priority, lots of it is just me trying to explain why:
-2: Exploitable Info, Custom objectives and crew records (General, Medical and Security), Reason: Fuck TG objectives, would be nice if cool antag boys that try make the round fun for others have something to work with and crew records because some people do really like to set them. Maybe be able to set race name so we arent stuck with TG names. I know a few people that would appreciate it but not really needed. Also Cafe for undisturbed (E)RP. Also more than 3 character slots. We have.. 30(?) on main.

-1: No head antags, QM to heads. All that effort and all that work and you decide to pull a fast one to go get the thermal drill and heist the vault? Instant trust with heads, RD antags are a nightmare, CE antags are a nightmare, now imagine if we had sec antags that simply go for "You arrested" and then just do the epic John Wick objective. Which brings me to the next one.

0. : Comment out assassinate and kill objectives. Probs make them opt in/opt out.

Reason: I had it with this powergame, grudge and validhunt catalyst. People can use custom objectives. If somebody wants to be involved in direct assassination stuff: They can put it in exploitable. I think thats why a guy initially paid a dude to get this ported from bay/Hestia anyhow. Worked super well on Hestia. Probs better to hard remove these objectives so no gamemode can ever roll them. Heres again the reason behind my way of thinking: Assassinate objectives are the most effective powergame, validhunt and grudge catalysts. This objective brings out the worst in people. You dont bother interacting with your coworkers anymore because if you dont know them OOCly they might just be up to do some shitty objective they set for themself or got assigned to without much thought. This results in people having the 2 tiles distance thing one observes on Para, Fulp, TG aswell as people having roundstart rituals like making the incredibly powergamy spray bottle of anti assassin (ClF3, Napalm, Lube) among other fun things. The game takes on a TTT like tone which is good for LRP like TG but poison to anything aiming for higher standards. Blueshields will take the "tactical locker" on bridge to block bullets for Captain if some guy rolls in for the fifteeth time this week with a TG style assassinate objective. Sec wont bother talking because alot of them can and will relate to the person that basicly got merced and just shoot to kill in the most gamy way possible. The Victims will get highly upset at sec if they decide to not execute the guy that merced them. Its simply a cascading effect we can opt out by simply not having these objectives coded into the game. If somebody loves getting involved in these plots they put it in exploitable. Plenty of people did on Hestia. It worked really well there when it was rather popular. We had tons of quality antags. Then devs stopped working due to baycode and Carl pulled the plug. "JuSt ReSpAwN" does not fix it. The damage is done regardless if you can respawn. This thing makes people jaded and not want to interact with anyone and do their own thing if that keeps happening out of the blue. And no "its just a slim chance" is not an excuse. The chance is there and thats enough for people to act like well.. they are in a game of TTT. Undirected Antagonism > Directed Antagonism. Heck I honestly rather have a murderhobo than yet another assassin gimmick but thats just personal opinion :').

Other than that on this entire thing: Not all of us get to play 4-5 rounds a day. Some get maybe half a round at most. Some have other things to do. People should not need to sacrifice their round for somebodies shitty ass permakill objective they did not bother to change just so they can respawn as a secondary character as epic lawyer/assistant/botanist.

1. Comment out Split Personality Reason: Heavily concerns due to how it will cause ahelps and be genuinly only used to "meme" and "grief", remove brain damage lines (4th wall breaks, LRP) --> We have this removed on main. Split personality ahelps are one of the more unfun and stressful things to deal with when the split deals like a genuine shitter (Yes they do most of the time.).

2. Comment out "Random X" events, specially random brain trauma, they fuck over a single person and contribute nothing to the round. Radiation storm contribute more. Hallucinations contribute more. Electrical overload contributes more. --> We have the Random X event being defunct on main and Brain Trauma commented out. Literally any other event is better.

3. Revert BOH anomaly requirement: Bad for the game, RNG is a bad balancing mechanic, this is CDDA game design if you ask me and we all know how people handle CDDA: They pick the build they like, remove the realism and RNG nerfs and then play it like it used to. Or you get a bunch of people that exploit the next best thing. People dont use anomaly cores even if they have them cause they are "scarce" or were made aware that they are "scarce". People being aware that something is a "rarety" makes them not want to use it.

4. Revert some of the other questionable changes (Removal of Singulo, tesla should be back in black, again CDDA game design is a bad example on how to make changes, botanies disk rack thingy and in general what botany has turned into is yikes.)

5. Revert racist pay: Everyone has to get the same paygrade, appropiate for their job, no matter race, we are a furry server, Lizzer CMOs should get the same pay as Moffs CMOs, Canine CMOs, Human CMOs.

6. Port deep rooted brain trauma fixable with lobotomy without worsening chance, aka no permanent brain traumas. Brain traumas are attached to far too many things. Including things that should not cause physical brain traumas (abductors --> This should cause psychological traumas.. not physical ones, they are far too advanced to fuck up that "trivial shit")

7. Add wizard changes maybe (no: Staff/Wand of Tranformation/Chaos, Instant Gib hand, Mindswap, Summon events ( WARNING GRAPHIC DESCRIPTION DO NOT READ:
   I love being mindswapped into a scene that breaks personal ERP prefs to the point I would love to scream while a very very detailed emote was posted in dorms 3 or something equal that I wouldnt like to see while the floor tiles were pried off and the toilet was moved to the entrance hallway for some reason
   GRAPHIC DESCRIPTION STOP DO READ AFTER THIS), Barnyard Curse, Insanity curse (Insanity curse is fundamentally broken for long rounds PERMANENT brain traumas that have the magic tag (literally not fixable bar aheal), also fourth wall breaks)) --> This could make wizard actually happen in normal rotation without people going "Kill wiz call shuttle"

8. Comment out wisdom cow: Fourth wall breaks

9. AI to Crewsimov (Probs done already, reason is obvious)

10. Fix midround events announcement to be less LRP: I can do that, just need an explanation on how to modularize things. Events in question are: Major Spacedust (Neighbour station throws rocks --> Makes no sense ICly), Sentient Animal (Make it just say "A bioscan revealed that one of the stations lesser creatures gained sentience." or alternatively "NT Psicorps Update: A lesser creature on your station gained sentience), Rat migration/mice migration: Remove any ragnarok reference or "space being cold" just make it say: "Bioscans indicate that several rodents are populating maintenance, handle them before it starts affecting productivity", the SM portal event is literally bad SCP shit, can we get that rewritten theres no reason to put [REDACTED] in an official announcement or in anything you send for somebody to read. You would not mention it in the first place so no questions are asked. Arbitrary naming of cataclysm event in the report that is an SCP ref and FAR too large in terms of how its explained. It more or less says the universe is fucked if the event isnt stopped. There are most likely more stations than just this using a magic crystal of power. It implies that this can happen to any SM crystal. In other words somebody would be bound to fuck up somewhere. Short version: Ruins immersion as this kind of scenario would fuck the universe sideways if this aint getting rephrased.

11. Make space dragons not PKers that spawn 20 mins in. ACTUALLY: It vores people. That doesnt make it better and will get people very sad because "vOrE iSnT mY FeTisH wTF". Make it put them into a bluespace portal or some shite. Legit just rephrase it, it gives corpses back on kill afaik, akin to a slaughterdemon on Paracode. I do know a Moff that would like the space dragon though.

12. Meteors early warning port

13. Disable Cult until reworked, disable Nuke Op till reworked/changed into mercs, maybe disable wizard till its not a "Kill wiz then call shuttle" kind of deal, perhaps get the heretic changes in we were trying ont he main server but never seemed to work properly, maybe they do now dunno. And please completely remove Revolution. Instantanous conversion with no effort, bad IFF in an overglorified TDM, literally "Duh huh kill other party" and the minor reason: Makes no sense ICly. Instantanous, effective and concealable mind control would have been definitly be abused by whoever found out about this one. And probs upscaled.

14. SUPER HIGH PRIORITY: *weh *merp *nya *bark *hiss, maybe Cits lizard screams they sound cute, TGs deathrattle sounds sound really off but thats probs just me. Also traits: Cold Blooded. Would be nice to have.

15. Some (not all) of the colorful traitor items we got on main.

I rather discuss this stuff further in DMs, I have no notifications for github.

Chat System Failure [GOODBYE]

Complete system failure caused infinite runtimes in living_say.dm.

[2020-10-19 21:26:31.063] runtime error: Cannot read null.prefs

• proc name: send speech (/mob/living/send_speech)
• source file: living_say.dm,314

Test round feedback, missing features, and bugs discovered from 10/19/2020

When I play test rounds, I take notes. Here's what I have for the most recent one.

Welcome screen is missing the character name. This might seem like a small thing, but it's nice to confirm you have selected the correct character you wish to spawn as.

Pixel shifting is missing, this is a much beloved feature.

Some functions of alt clicking a tile to list and interact with all items on it are not working. This is a major critical quality of life item. More testing is needed, as it seems to work partially but not the same was as on skyrat-cit.

Antag OOC would be nice to bring over.

Bug: security tech armor accidentally got ported over.

Voting is not working correctly. Every time I've attempted it, which is several test rounds on multiple days, it's not taken my vote. The links do not highlight to confirm selection, and the counters don't change, which leads me to believe it's not working. It obviously works for some people, but there are other reports of it not working.

Antag objectives... these need a major skyrat edit if TG is to become the new main. Many involve round elimination or highly disruptive activities. Some of them are in disagreement as well. In the ling round that had to be abandoned for a server restart, the changelings had a team objective, to replace an entire department with changelings. However, each changeling had a different department listed for their team to take over, and this would have been functionally impossible to achieve as a result. It also only put in three lings for an otherwise very crowded round, so antag scheduling probably needs a look at too.

Horns don't stick through "Bedhead Long" hair.

Round ID:

N/A, Tested With local downloaded Repo

Testmerges:

N/A

Reproduction:

Be lizard. Set horns to ram or similar. Set hair to Long Bedhead. Doesn't poke through like on the main repo. Sad!

Junkie kills you.

The junkie quirk shouldn't kill players, it doesn't fit with the servers playstyle and can prevent you from playing as a character that is a junkie if the medical staff don't or won't fix you, and thats if there is actually someone playing chemist. I had no chance to play the recent testing round because of this.

Old legacy donator items.

Would love it if my old donator items tied to ckey inferno707 could be transferred as well.

DNA Manipulator still missing from Botany

😢

Setting Supply Console board to "Broad" does not unlock contraband crates

Round ID:

Round 53

Testmerges:

#943
#948
#941

Reproduction:

Take out Board from Computer, Multitool to set to "Broad", Set back in, Be dissapointed (Or surprised if it works, and this was just some one-off bug)

TG Chat doesn't load

Round ID: 20

Testmerges: #943 #1285 #1356 #948 #1616 #1304

Reproduction: Connect to the server. Fancy chat doesn't work, reloading/clearing cache/restarting the PC doesn't help

Cyborg missing rest animations & lights failing to activate when module initially selected.

Cyborg eyes missing upon module selected.
This bug is very noticeable for drakeborgs since their light layer has a big part of their design. Cyborgs ALWAYS have the light-layer active unless disabled by EMP, flash or dead battery. When the cyborg selects its module the light-layer will be missing until they activate their flashlights or rest.

Cyborgs missing their rest animations.
activating rest you move normally spite laying down and your sprite does not change. ( am sure you guys are aware of it but just wanted to report it)

Sprite Graphical Bug, with Welding helmet and Atmospheric gas mask

New to GitHub, but I did find issues on the big rebase test, of the year of our lord October 19th, 2020.
Number one: as playing as a character with a big beak for their snout, the welding helmet or atmospherics gas mask will cause it to get removed. the red dude to the right.

Number two: small issue, but the sprite preview on the character appearances are a bit off compared to the ingame sprite size character.

Sec Otie Sprite

Security Otie Hound's sprite is somewhat not working

Some synths aren't allowed to take High-Luminosity Eyes at loadout

For some reason at loadout, most organ augments can't be taken by synthetic characters even if you have enough points left to gain it.

Round ID:

73

Reproduction:

1. Create a synthetic character (in my case, was synthetic lizardperson)
2. Select any quirk that gives you a positive quirk point count
3. Check for High-Luminosity eyes in the augments tab. Even if you have enough quirk points, this option will remain grayed-out as though unpickable.

HUDS, Prescription HUDS, do not exist, nor can they be picked in loadout

What it says on the tin, you can't even get these via research, unlike on main where they're freely available.

quality of life improvements rebase test day 11/7/2020

I am listing what should be added for convenience, and just make life easier

1. Give atmospherics people engineering access, unable to access electrical Lockers
2. add mag boots to suit storage units in engineering,
3. the sprite for the jaw of life and hand drill seem too small to know if it's in drill or bolt mode, along with jaw of life cutter or pry mode.
4. make it faster to assemble and dismantle machines, pipes, walls, windows.
5. a little bit faster movement speed, in general, would be helpful in getting tasks done faster.
6. re add Gas miners, so i don't try to efficient all the time be nice.

this is it for now.

P.S avian species and avian legs are currently not in skyrat rebase, bird people would love to have those.

"Snout" sprites are rendered in front of "Head" markings

The snout sprite should be a base the head marking is drawn over, otherwise details like mouths or teeth get buried underneath the base snout shape. Alternately, make it possible to order them yourself.

Handle button missing from Tickets

The handle button is missing from the ticket interface.

Owai's 10-19 Rebase Test Missing Feature/Report Thread

Annoyances/"Bigger" Issues.

• Lots of chat issues. Regular chat breaking, dead chat breaking.
• Ashwalkers cannot breathe on lavaland and also spawn with plantigrade legs.
• (Added 10-20) Would kinda like a debug area (Ghost Cafe) spawn) to help test stuff as non-admin.
• (Added 10-23) Positronic (and possibly, Drone) Ghost-Ping Consoles for Robotics.
• Someone mentioned not being able to drag things across catwalks. (Such as the Janicart)
• Flavortext/OOC limit might be smaller on rebase. Needs testing/checked.
• Double clicking stairs as ghost doesn’t give option to go up or down (like ladders)
• Someone mentioned that they cannot adjust hypospray amount.
• Emote star seems to only show up on long emotes, but not short ones.
• Voting might be a tad broken? (It didn’t mention anyone not voting, and pushed all non-votes into one of the options)

Mildly Unimportant.

• Status tab does not list connected players.
• Different jobs. (Brig Phys, Synthetic Repairer, ect.)
• Someone mentioned the metric unit measurements for size.
• Some sound effects are a bit weird now. (Gasp, Cough, Sneeze, Sigh)
• Bluespace Techs drop Standard Batteries when they peace out.
• Some maps are missing cryo cells (Ice Box)
• Pubby Perma is SMOOOL.
• People take burn damage in metalstation freezer.
• (Added 10-20) Several Spraypaints are probably missing, such as paw prints, but I forgot to check.

Possible Clothing Issues

• People mentioning Polychromatic stuff is Donator Only
• Fishnet Stockings don’t exist. (Underwear/socks?)
• Requests for berets and departmental winter coats.
• Tennis Balls not on loadout.
• Nurse Outfit
• Jeans and Chaplain may not be working with digi legs.
• Egyptian Chaplain Clothes missing from vendor.

Character Customization

• Angel / Dragon wings disappear when looking to side.
• (Added 10-20) Luminescent Eyes will turn back on by themselves if toggled off, if you move or change direction at all.
• Slime People apparently do not start with shapechange.
• Several Quirks are missing. (Synthetic, Monophobia, Coldblooded, ect.)
• Language Customisation Missing? (Was in last test.)
• Food Likes/Dislike Customisation
• Two mute perks. Mute (+2) Tongue-Tied (0)
• Everyone seems to get navigationally challenged trait, even if its turned off. Is it a pref hidden somewhere?

Requests

• (Added 10-21) It would be nice if the character preview showed floor tiles, or had a selectable backdrop that wasn't pure black.
• (Added 10-21) Someone mentioned that it would be cool for pepperspray to be more useful. As it stands now, using any eyewear basically nullifies it, even if it would (realistically) allow you to still get peppersprayed. (IE: Single Eye Medihuds, Eyepatches, ect.)

MISSING CLOTHING ITEMS

THIS IS FOR ALL THE ANTHRO/MUZZLED/DIGI ERRORS.

Calling return as a bluespace tech with a synth character leaves battery

Issue reported from Round ID: 65 (/TG/ Skyrat 13)

Reporting client version: 513.1532

When calling return while bluespace tech as a synth. leaves behind a standard battery.

Owai's ~10-11 Missing Feature/Bug Report Mega"Thread"

Missing Features

• SSD Timers for Cryo Cells, and / SSD Examine Text. ZZZ Above heads for when someone is SSD
• Star Symbol for Emotes (Runechat)
• Radio Message Sound (For if you do ; :h, ect.
• Sprite Size Customization
• Towels, Towel Bins, Colored Bedsheet Bins
• Additional Alert Levels (Violet, Amber, Orange)
• PDA Noises (Beeping when clicking through menus. Beeping on message sent. Possibly sounds for when a message fails to send?)
• Prize Machines / Tickets
• Hand Mirrors
• Some PDA Styles are missing. (Specifically, Holographic, unless they're just named different.) I don't think it can be changed midround either.
• Food Preferences
• Directional Falling seems to be missing.

(Apparently not being done?)

- Cloning is not fully implemented.
- Auto-Call/Extension Votes
- All the random ERP stuff.

MEDICAL

• Anesthetics / Painkillers (Anesthetic Tanks, Morphine, Miner's Salve, Vitrium Froth (For Ashwalkers)
• Blood Bank Generator / Synthblood (Possibly remake it so it has proper upgrade tiers for efficacy instead of doubling blood rounstart.)

Possible Bugs

• Changeling Transformation Stings might not work correctly? (Don't know if it's just a TG feature or not.)
• Ghosting in Cryo doesn't immediately remove your body.
• Face Masks (At least for muzzle variants) don’t show properly when looking down
  
• Pickpocketing things from someone will drop the item on the floor, making it pretty easy to tell you tried to nick their shit.
• Same thing goes for buying things at vendors. Items kinda just drop out of the vendor.

QoL Improvements

• Alt-Click to select amount for Reagent Containers
• CTRL Click Jumpsuit to max sensors.
• Can't wear trash bags on belt.
• Food Crafting takes -forever- compared to Citcode.
• Ghost filtering of common messages.
  

Straight up requests.

• Stuff to help prevent permakilling. IE: Gibber/Cremator spitting out brains, Fryer not allowing brains to be fried, brain cake removal. Reminders for both antags and security players that permakilling is a last resort, and assassination objective does not mean you can permakill people.
• Mutation Toxins and a spawnable bottle of them for each race. (For Easier TF Reversal, Citcode only had a few.)

Stuff that probably doesn't matter or needs done upstream.

- Chat doesn't have a two-tone mode (Dark Top, Light Bottom)
- PDA Messages and Pointing count as "Unsorted" Messages. Could use some category?
- OOC and LOOC cannot be sorted seperately. I always want to see LOOC messages, but the chat sorts them both in the same category.
- Color Coding for Medipens (I might just do this upstream, 3 medipens look exactly the same. Epinephrine Medipen, Emergency First -Aid Autoinjector, Hypovolemic-response Autoinjector.)
- Polychromatic Clothing

End Notes:

Some of these may have already been fixed, but I was urged to put these things on the github instead of a random google document that I don't look at all that much. I'll try to strike things off of this as they're fixed, and either open up a new thread, or make date-stamped addendums under this message.

Cargo console bluescreen

Round ID:

69, skyrat rebase test server

Testmerges:

Reproduction:

Open a supply console. It bluescreens and shows

[object Event]
at undefined:undefined
User Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.1; WOW64; Trident/7.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; Zoom 3.6.0)
State: {"ckey":"tehsplintercell","interface":"Cargo","window":{"key":"[0x203ceec]-main","size":null,"fancy":1,"locked":0}}

Nanotrasen (c) 2525-2559

Synth Chem/Medibot Issues

Round ID: 72

Reproduction:

A medibot will try to tend wounds on a synthetic/IPC player forever.
Chloral Hydrate can apparently put synths to sleep.

Wearing HUDs with implants makes the implant stop working

This bug happened in a server that uses Skyrat-tg code. I'm not sure if this bug is from Skyrat-tg or from /TG/

Reproduction:

Have an Medical HUD Implant
Wear an health scanner HUD
Remove the health scanner HUD
Notice you implant is not working anymore

[MINOR] Trays cant load food items into microwave/grinder/food processor

Round ID: 21

Reproduction:

Reproduction: Load up a tray with bacon, meat, a crop, really any food that be loaded onto the tray then unloaded into a microwave, grinder, or food processor. The tray wont work and it wont unload the food so for instance:

You cant load cutlets into a food processor to make bacon.

You cant load bacon into the microwave to cook it

You cant load wheat into the food grinder to quickly grind wheat.

Basically, the tray doesnt do anything you click on the object with loaded food items (microwave, processor, grinder, etc.) and it does nothing.

paper writing and bound books issues with colors and broken symbols

Round ID:

16

Testmerges:

Reproduction:

There are a few issues regarding paper writing and binding books.
First, editing papers with a black pen makes them blend in as white letters, can be read in the preview, and read normally.
When the paper is bound as a book, characters like " are replaced with “… and the words are also in white, making reading the book impossible without highlighting it.
Different color pens can be seen editing and on books but show as black letters instead of their color of red or blue.
in summary:
-black pens are white while editing and on bound books,
-Some symbols break when binding books,
-preview/reading papers only show black letters. making different color pens black. can see red and blue on edit and on books

Full rejoin doesn't fix the issue

Antag Pacifism

Round ID: 16

Reproduction:

Antags do not lose pacifism when rolling antag.

This isn't too much of a problem on its own but for antags like changeling which generally have to murder someone to do their objective, it becomes a problem when they cannot fight at all.

Blood trails

Blood trails make your entire body get covered in blood.

Snake tuar blueshield outfit (NOT ARMOR) broken and showing socks.

As title says.

Feature Request Mega(Not really)-List

A compiled list of missing features or requested changes I've found in my testing hours. More to be added maybe.

Items will be removed as they are addressed.

• PLEASE for the love of God get rid of random item placement when you drop shit. Not being able to put things like cyborg shells directly in the middle of the tile is scraping at my OCD to no end.

• I really fucking miss being able to sprint.

• Lots of things are super over-buffed when it comes to deconstruction steps. A reinforced window takes more steps and effort to deconstruct than a fucking reinforced wall.

• IMPORTANT BOBMED FEATURES LIKE DECAPITATION WOUNDS, SYNTHETIC WOUNDS, AND SEPARATED LIMBS ARE ALL MISSING (!!!!!!!!!)

make the mothwing neck fuzz an optional thing

i can't be the only one who would want this, a character that would have moth wings, but not have the neck fluff that comes with it.

Showers have finite water aAAAAAAAaaaaAAaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

AAAAAAAAAAAAAAAAaaaaaaaaaaaaaaaaaaaaaAAAAAaAAaaaAAaaaAAAAAAAAAAAAAAaaaaaaaaaaaaaaaaaaaa this ruins the shower rp, give us unlimited water back.

Holding CTRL and trying to face a direction just causes you to move in that direction instead.

Round ID:

2

Testmerges:

Null

Reproduction:

Hold CTRL and try to press a movement key to turn to that direction
end up moving in that direction instead of just turning
feel like a busted bayblade

Polychromic are donator items?

...wanna talk about it?

Can hear whispering through walls / Yelling heard through walls is the same text size as normal conversations

Round ID: 24

Reproduction:

If a wall separates you and another person, and you are within whispering range, you can hear the person whispering, albit with the wall you are two tiles from the source so you can see a partial message instead of the full one.

Through walls, you can hear yelling/screaming, however the text is the same size as normal conversations vs smaller as it was on the older tg code.

To replicate either of these, just go into a room, put someone on the other side of that wall, and try whispering to replicate the first issue, or yelling to replicate the second issue.

FAX MACHIENS BACK! BRING EM BACK SO WE CAN FAX INFO INSTEAD OF RUNNING BACK AND FORTH!

Title says its all why no fax machines!

Large glass doors light overlay doesn't rotate.

Round ID:

N/A

Testmerges:

#1785

Reproduction:

Spawn the large glass door in a shuttle, rotate the shuttle. Probably also happens if you make the door sideways via DIR in VV or through map editing.
https://cdn.discordapp.com/attachments/640760727489085450/780895234099904562/unknown.png

Sizes of characters

While not quite a priority, I feel we should sooner or later get the size adjustments in
I know a lot of people, if not basically almost everyone fiddled with the sizes of their characters at some point, and I joined in on one of the tests, and its almost comical on how much you can tell when your used to a character that was either really big or really small

Vox suffocate quick and their emergency tank is oxygen

Round ID: TG testmerge round, 02/10/2020

Testmerges:

Reproduction:

As a vox, your nitrogen tank depletes really fast compared to base Skyrats, in 20-30 minutes or so. To make matters worse, your emergency tank is oxygen so you are right fucked if you want to breathe for long periods of time without constant recharges

Dog borgs invisible

As it says on the tin, will look into it.

Morgue Sprite Issue

Round ID:

92

Testmerges:

Reproduction:

Look at one of the many maps with Morgue Trays facing up or down

Serving Tray cannot pick up ANY food objects.

Round ID:

N/A

Reproduction:

Use a Serving Tray to try and pick up any food item (Cutlets, Steaks) . It doesn't work. In Skyrat/Citcode, Sxerving Trays can pick up all foods, reagent containers (such as Flour/Rice Bags) and even bowls.

A lot of Divisions by zero - New Audio Falloff re work rt

This is a new runtime, since the new sounds update. Presumably by
#1406 (comment)

Its caused every time you speak into the headset.

Runtime in sound.dm, line 113: Division by zero

proc name: playsound local (/mob/proc/playsound_local)
usr: Franco24/(Alicia Brinder)
usr.loc: (Research and Development (111,101,2))
src: Alicia Brinder (/mob/living/carbon/human)
src.loc: the floor (111,101,2) (/turf/open/floor/plasteel/white)
call stack:
Alicia Brinder (/mob/living/carbon/human): playsound local(the floor (111,101,2) (/turf/open/floor/plasteel/white), 'modular_skyrat/modules/radioso...', 27, 0, null, 0, 652, 1, /sound (/sound), 17, 1, 1, -10000, 0)
playsound(Alicia Brinder (/mob/living/carbon/human), 'modular_skyrat/modules/radioso...', 27, 0, 0, 0, null, 652, 1, 1, 1)
the research director\'s heads... (/obj/item/radio/headset/heads/rd): talk into(Alicia Brinder (/mob/living/carbon/human), "Chill", "Science", /list (/list), /datum/language/common (/datum/language/common), /list (/list), 1)
Alicia Brinder (/mob/living/carbon/human): radio("Chill", /list (/list), /list (/list), /datum/language/common (/datum/language/common))
Alicia Brinder (/mob/living/carbon/human): say("Chill", null, /list (/list), 1, /datum/language/common (/datum/language/common), 0, null)
Alicia Brinder (/mob/living/carbon/human): Say(":n chill")