sledilnik / zdravniki Goto Github PK
View Code? Open in Web Editor NEWWebsite for showing doctors' availability in Slovenia - https://zdravniki.sledilnik.org/
Home Page: https://zdravniki.sledilnik.org
Website for showing doctors' availability in Slovenia - https://zdravniki.sledilnik.org/
Home Page: https://zdravniki.sledilnik.org
Gynecologist does not have sub-type, therefore we should not show icon for adult/youth/student in filter selection below:
See also #123 which will also remove the sub-type selector for general practitioner
I find it annoying that zoom-out happens every time I change the filter.
I think if user did zoom-in, we should respect this and only show results matching the map.
Click on ZDRAVNIKI logo could reset zoom (like go-home)
In addition to #84 we could make the process easier to moderate.
For accepting and fixing errors in the data of specific doctors a gform could be more useful:
Originally posted by @stefanb in #84 (comment)
If marker's tooltip height is near map height, tooltip pushes marker outside the map and consequently disappears (fully zoomed in).
Steps to recreate:
Video was recorded on iPhone SE 2.
When map is zoomed out then due to map max bounds tooltip pushes marker down trying to fit on the map and then marker snaps back and tooltip is not fully visible.
Steps to recreate:
When a user provides a language flag in url (e.g. https://stage-zdravniki.sledilnik.org/en/), it should always load the page in this language.
Preserve all search parameters, including current map position & zoom in the URL hash.
Specifically:
Eg: https://stage-zdravniki.sledilnik.org/sl/zdravnik/neveljavno-ime
should show a not found (possibly 404 to prevent page from being indexed) and offer the user a link to search page with preselected doctor type
The new design looks great. We only need to now improve the looks of tooltip to match the new design (Sprejema, doctor type...). Also, we need to add at least a button to go to Doctor page as this is very useful for mobile, to go directly to doctor page from the map (default) view (which does not show cards anymore)
...and possibly other available fields
Eg searching for "dent" yields no results when searching for dentists even if it appears in many providers' names.
Eg https://zdravniki.sledilnik.org/sl/den-s/sustercic-rok finds the doctor for adults:
instead for students as defined in URL path.
The data in doctors.csv contains both:
We should have sub-page with title + description for Report error. We should present [email protected] address there and present as mailto: link there.
<span>..</span>
, it doesn't treat <span>..</span>
as part of a paragraphCurrently the business card icon is implemented using HTML <button>
element, making it less likely for crawlers to click.
For better discoverability by crawlers it should either become a HTML link (<a href=....>
) or we should provide a sitemap.xml
file.
For privacy (possibly getting cookies) and performance
Either
<meta name="robots" content="noindex">
Watch out for cases with edit in doctor's name, like
https://stage-zdravniki.sledilnik.org/sl/gp/aladic-edit
Check which columns from https://github.com/sledilnik/zdravniki-data/tree/main/csv are not used and either use them (eg in search) or remove them from cvs
We could also add statistical region name if needed.
We would like to have FAQ subpage, similar as we have here for Sledilnik (done by @miaerbus):
https://pr-983.preview.sledilnik.org/sl/faq-vaccines
We could enter all the FAQ texts into backend.sledilnik.org:
https://docs.google.com/document/d/1m2sDOBa9ht7rK8ZWDJdxydwd-IjvulPiUnWWiPx-D5Q/edit#
Link on institution name to institution webpage in providers list is not active anymore since clicking anywhere takes the user to the doctor card.
Same in map popup.
Not sure if this is intended or not.
If so remove the link from the institution name, otherwise make the link work if user clicks/taps it.
Copy url for each faq and glossary item in FAQ was lost with refactoring.
Before it worked as here: https://covid-19.sledilnik.org/sl/faq
TODO:
canonical
links pointing to same URL but on production hostname zdravniki.sledilnik.org
with all query string and hash striped (remove everything after ? or # inclusivehreflang
links between same pages in different languages (language part of the url replaced with target language, cleaned of varying parts as above)@stefanb @lukarenko @miaerbus @mihaerzen @overlordtm @bananica
First of all I would like to thank you all for your contribution so far and that you are patient with me :).
Before I or someone else really tackle #24 and #30 I would like to have code as clean as possible in given moment. I am afraid of large number of conflicts. The second reason is very annoying. Switching between linting
and other branches requires, at least from my experience, deleting /node_modules
and re-installing them and I would really love to have linting enabled.
Unless there is better way, I suggest that we merge all open PRs, even thou they might not completely solve issues or implement new features. Apply linting and then continue.
If we decide so, @mihaerzen, when should we turn on rules that are currently turned off? I assume immediately after previously rule is applied. And after all rules are applied we should continue with fixing issues and implementing new features. Will it take too long to apply all the rules? What would you do?
Cluster markers use green/yellow/red to encode the size of the cluster, which interferes with individual doctors’ markers that use green and red for ne/sprejema.
I suggest using a different color scheme for clusters, e.g.:
Hi!
I went ahead and had a look at some of the pull requests. The first thing I noticed is there are different coding styles used between different authors. As this is an open-source project which will hopefully have many contributors I would suggest adding some linting to enforce a certain coding style. I believe this will increase readability and make pull request reviews easier.
Personally, I would vote to adopt eslint airbnb-typescript
as I think it fits what I have seen in the code so far. I would also add this to the CI so it will run when pull request is created.
Let me know what you think!
Thank you for your amazing contributions so far! 👏🏼
Port sledilnik/website#999 to this project
At least
...and possibly others
Add target="_blank"
and possibly rel="noopener noreferrer"
to the <a>
html element in DOM
During the recent github outage the CSV file couldn't be loaded and the page stayed empty.
Not much benefit, just risk of push back due to privacy concerns
Unrelated to basic #36 we could annotate per-doctor page with microdata for their
Either as JSON-LD or Microdata
https://developers.google.com/search/docs/advanced/structured-data/intro-structured-data
https://w3c.github.io/json-ld-bp/
https://www.npmjs.com/package/jsonld
Limit min & max latitude and longitude so that user doesn't accidentally wander too far off into the dangerous areas without doctors.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.