The rsack from slyyxp

Circumvent `song/j_ArtistAlbumList.json` response limit.

song/j_ArtistAlbumList.json responds with a maximum of 25 albums.
This needs to be increased for artist batching to have any real value.

I am not aware how to circumvent this at the time of writing.
One solution to obtaining the necessary album id's would be to scrape them although not ideal.

    def get_artist(self, id):
        """Returns artist information

        Args:
            id (int): Artist UID

        Returns:
            [dict]: API Response containing artist information
        """
        data = {
            "uxtk": self.usr_token,
            "sign": "Y",
            "tct": "Android",
            "svc": "IV",
            "stk": self.stm_token,
            "dcd": self.dev_id,
            "xxnm": id,
            "unm": self.usr_num,
            "mts": "Y"
        }
        r = self.make_call("app", "song/j_ArtistAlbumList.json", data)
        if r['Result']['RetCode'] != "0":
            logger.critical("Failed to retrieve metadata")
        return r

Skips downloading songs with characters ?, :,

Hi, I noticed that the script skips downloading songs that contain ?, : in their filename.

For example, when downloading this album https://music.bugs.co.kr/album/4041263?wl_ref=list_ab_03_ar, it appears like this:

C:\Users\x>rsack -b -u https://music.bugs.co.kr/album/4041263?wl_ref=li
st_ab_03_ar
2022-04-04 12:37:15.233 | INFO | rsack.clients.bugs:auth:26 - Login Successf
ul
2022-04-04 12:37:16.104 | INFO | rsack.bugs:_album:53 - Album: ? ??? ??? ??
???? (???? ??? X ?? (JOY))
2022-04-04 12:37:16.111 | DEBUG | rsack.bugs:album:67 - Creating C:\Users\x
\download?? (JOY) - ? ??? ??? ?? ??? (???? ??? X ?? (JOY))
2022-04-04 12:37:17.345 | INFO | rsack.bugs:_download_cover:130 - Cover artw
ork downloaded.
2022-04-04 12:37:17.358 | INFO | rsack.bugs:_album:76 - Threads: 1
2022-04-04 12:37:17.444 | DEBUG | rsack.bugs:_download:87 - Processing: 61041
67
2022-04-04 12:37:18.733 | DEBUG | rsack.bugs:_download:87 - Processing: 61041
68

C:\Users\x>

~~Sorry for my English~~

Lyrics referenced before assignment.

https://music.bugs.co.kr/album/20452782?wl_ref=list_ab_03

Tracks without lyrics are not assigned resulting in them not being tagged.

Sanitize paths

Remove invalid characters from filenames and paths.

how to download flac in genie?

I'm already using the flac subscription. but download is only 320kbps.
how to download flac? Is there another command?
And what does "thread" mean?

thank u sir.

Improve exist checks

Exist checks are present but are only made after a lot of requests go out for relevant album/track information, this slows down completion time a lot.

Remove the need for `_collect()`

How to edit rsack_settings.ini

Thank you very much for sharing.
I made a mistake when I first inputed the password, how do I need to modify it, I can't find the path of Settings.ini

Label (id3.TPUB) not supported.

The bug's metadata does not support label tags, showing blank，but BugsPy-master support

`FileNotFoundError` for `cover.jpg`

Traceback (most recent call last):
  File "C:\Users\Cheek\AppData\Local\Programs\Python\Python39\Scripts\rsack-script.py", line 33, in <module>
    sys.exit(load_entry_point('rsack==0.1.4', 'console_scripts', 'rsack')())
  File "C:\Users\Cheek\AppData\Local\Programs\Python\Python39\lib\site-packages\rsack-0.1.4-py3.9.egg\rsack\main.py", line 25, in main    
  File "C:\Users\Cheek\AppData\Local\Programs\Python\Python39\lib\site-packages\rsack-0.1.4-py3.9.egg\rsack\bugs.py", line 36, in __init__
  File "C:\Users\Cheek\AppData\Local\Programs\Python\Python39\lib\site-packages\rsack-0.1.4-py3.9.egg\rsack\bugs.py", line 69, in _album
  File "C:\Users\Cheek\AppData\Local\Programs\Python\Python39\lib\site-packages\rsack-0.1.4-py3.9.egg\rsack\bugs.py", line 124, in _download_cover
FileNotFoundError: [Errno 2] No such file or directory: 'Z:\\Music\\Korean\\TREASURE(트레저)\\TREASURE(트레저) - THE SECOND STEP _ CHAPTER ONE \\cover.jpg'

Album Batching (Bugs.co.kr)

Requires some refactoring of the Download() class.

Allow access to `rsack.clients.bugs`

As of now this can only be used by the project internally.
Users should be allowed to authenticate and make calls for their own projects.

FLAC false positive.

API returns that there is FLAC present, yet it redirects to MP3.
This could be because of the streaming plan, it is unknown why.

Refactor bugs client

Refactor bugs client.
Constructing posts should more closely match the genie client for consistency.

Labels cause artist batching to fail

Labels are actually not returned in the API response when requesting artist information.
They are present in the response as a NoneType, this means an additional request has to be done. Although slower it's necessary for all the information we need for tagging.

If anyone can provide this feel free to get in contact on this issue.

auth() through kakao is not working. link kakao account to melon id. And login through https://member.melon.com/muid/mobile/login/login_login.json
https://spmd.melon.com/prestream only support http GET method, not POST
Whenever I call funtion streaming_path(), It return mcache://smmd.melon.com/smartstream, not https://spmd.melon.com/prestream
When I call https://play.melon.com/cds/delivery/android/streaming_path.json without q parameter which is obtained from streaming_path.json, It doesn't download song.
After add q from streaming_path.json, I only download song that is encrypted

Here is code!

Discussed in #49

^{Originally posted by kihyyo August 16, 2022}
Currently gives only information of album.

In web I can see more detailed information of artist and also in app like who she or he is.

I need some help the way getting more detailed information of artist through https://app.genie.co.kr/???/j_ArtistInfo.json I guess.

And more detailed information of album If possible, Thanks

slyyxp / rsack Goto Github PK

rsack's Introduction

rsack's People

Contributors

Stargazers

Watchers

Forkers

rsack's Issues

Discussed in #49

Recommend Projects

Recommend Topics

Recommend Org