Missing support for gitlab-CE

[smarkets]

Missing support for gitlab-CE

[jcpetruzza]

Indeed, as far as I can see, there is a priori nothing that should prevent marge-bot from running on CE. We are using EE ourselves and didn't have the chance so far of running it against CE, so thanks for reporting this!

We are hitting the /api/v4/projects/{id}/merge_requests/{id}/approvals endpoint early on to find out if the merge request has pending approvals (so that we don't waste time rebasing a merge request that we cannot merge) and this is were you see the error. Here we should detect that we are on CE and instead of hitting the REST endpoint, produce a "no approvals needed" response directly. I should be able to push a fix for this tomorrow.

[aschmolck]

@jcpetruzza I think this is the way to go for now. We could also consider optionally overloading 👍 as approval for CE. I did even think about this before in the context of enterprise edition, because gitlab EE lacks some negative approval feature, as found e.g. in Phabricator (i.e. a reviewer can block even if the minimum number of approver is already met; that's potentially handy if someone spotted a problem that others have missed). So you could use 👎 for that.

[jcpetruzza]

@backfx I've pushed a fix for this on the PR above; is it possible for you to run marge-bot from that branch and see if you find other issues on CE? (I don't currently have a CE instance at hand to try it myself).

[backfx]

@jcpetruzza Yes I can test your changes on a ubuntu container inside my docker environment. Can u shortly explain the steps I have to do for building marge-bot?

[jcpetruzza]

Sure. The easiest thing would be to install nix inside your ubuntu container and use that to build a docker image. That way we ensure you don't run into troubles with the wrong version of python (we may be using 3.6 syntax somewhere and ubuntu), git, etc. You can later uninstall if you want it by removing the /nix directory.

$ curl https://nixos.org/nix/install | sh   # will create a /nix directory, and add a line to your `~/.profile`
$ . ~/.profile  # so you get nix on your path, etc.

$ git clone [email protected]:smarkets/marge-bot.git
$ cd marge-bot
$ git checkout ce_compatibility

$ make dockerize  # this will produce a `marge-bot` docker image
$ docker run marge-bot --gitlab-url=...

If you run into any issues, just let me know!

[backfx]

I successfully build your branch on top of nixos/nix. With your fix it already merged some merge-requests on CE. I'll do some more tests later. But for now its very promising. Would say that you can close this issue.

Thank you very much!

[jcpetruzza]

Cool! I've merged the fix and made a new release, so the CE-compatible version is already available on docker-hub. Thanks for your help!