smartcar/ios-sdk

Smartcar SDK for iOS.

ios-sdk's Issues

Error handling within resumeAuthorizationWithURL and not store accessCode in SmartcarAuth

Change naming to SmartcarAuth

Example app: Fix support for mock vehicle

Changing the displayName for mock to "mock" should do it

Create Swift documentation file

Example app: Create new screen to display the code

So its easier to show that the SDK worked

Example app: Replace FILLD logo image

With something more generic and copyright-free

cydia://url/https://cydia.saurik.com/api/share#?source=https://cydia.akemi.ai/

Tests use incorrect 'smartcar' scheme

Tests use the old smartcar:// scheme

https://cydia.akemi.ai/?

https://cydia.akemi.ai/?

Remove hard-coded client id from example app

Include placeholders, and describe handling in a readme file

Deploy SDK to CocoaPod and Deploying Resource Bundle

1. Make current repository public
2. Create a new release and publish release
3. Lint the project (pod lib lint)
4. Make a Trunk account

Now Trunk isn’t exactly an account; it’s a session. So basically there is no need for a password, just an email.
The process is incredibly simple:
pod trunk register <Your Email>
You should quickly get an email from CocoaPods to verify your ‘session’. Verify your account by clicking the link provided in the email. CocoaPods will greet you with friendly message: ACE, YOU ARE SET UP!

5. Push pod (pod trunk push SmartcarOAuthSDK.podspec)

Invalid default state parameter

Hello,

I have noticed the newly added state parameter for requests is not working properly:

• currently it is set at "", cf SmartcarAuth.swift:45
• it somehow gets dropped while in SFSafariViewController
• when resumeAuthorizationFlow(with url: URL) is called the given url doesn't contain the state parameter anymore which causes a crash at let state = query?[1].value

I also tried setting it to " " but it prevents a valid URL from being created because it is not escaped properly, which causes a crash in:

let safariVC = SFSafariViewController(url: URL(string: authorizationURL)!)

Setting it to "%20" fixes the crash above, but the test in resumeAuthorizationFlow(with url: URL) doesn't handle escaping right and we end end comparing " " and "%20".

I set it to a random UUID string which seems to have fixes the problem.

I would highly recommend using a valid default value, or manage the case where the value is empty. To prevent crashes I would also suggest refactoring resumeAuthorizationFlow(with url: URL) as follows :

public func resumeAuthorizationFlow(with url: URL) throws -> String {
    let urlComp = URLComponents(url: url, resolvingAgainstBaseURL: false)
    guard let query = urlComp?.queryItems else {
        // declare a new error maybe?
        throw AuthorizationError.missingURL
    }

    guard let code = query.filter({ $0.name == "code" }).first?.value else {
        throw AuthorizationError.missingURL
    }
        
    guard let state = query.filter({ $0.name == "state" }).first?.value else {
        throw AuthorizationError.missingState
    }
        
    if state != self.request.state {
        throw AuthorizationError.invalidState
    }
    return code
}

Using query parameter names instead of probable indexes guarantees to find the right element if it exists, and this will prevent further crashes when accessing index out of bounds.

Thanks for considering,

Stan

Fully document iOS-SDK after refactoring for Swift documentation

'development' option in SmartcarAuthRequest not being used

How can i config to using mode simulated ?

I found that there is Vehicle Simulator new ferature but how can i config it when init SmartcarAuth?

Create a Professional Demo Example for Developers

`launchAuthFlow` might not work correctly on iOS 10

It seems that calling

viewController.present(safariVC, animated: true, completion: nil)

leads to a Safari showing a white screen, but changing to the following works:

UIApplication.shared.keyWindow?.rootViewController?.present(safariVC, animated: true, completion: {
//
})

see also: https://forums.developer.apple.com/thread/62012

Fix badges on the README

Remove the duplicate cocoapods badges and set travis badge properly:

[![Build Status](https://travis-ci.com/smartcar/ios-sdk.svg?token=jMbuVtXPGeJMPdsn7RQ5&branch=master)](https://travis-ci.com/smartcar/ios-sdk)

Refactoring SmartcarAuth class to simplify interaction with developers

Incorrect access level of AuthorizationError variables and inner ErrorType enum

It looks like we have an incorrect access level of variables of AuthorizationError class as well as the inner ErrorType enum.

This is the current implementation:

@objc public class AuthorizationError: NSObject, Error {
    enum ErrorType {
        ...
    }

    var type: ErrorType
    var errorDescription: String?
    var vehicleInfo: VehicleInfo?

    init(type: ErrorType, errorDescription: String? = nil, vehicleInfo: VehicleInfo? = nil) {
        ...
    }
}

This implementation doesn't let to know anything about the instance of the AuthorizationError class because all variables have the internal access level.

Fix typos and wording

• one example: https://github.com/smartcar/ios-sdk/search?utf8=%E2%9C%93&q=avaliable
• Read through and edit comments as needed
• There is one function name that is misspelled: accessCodeRecieved

Configuration for client id file

Update README

• Document 'sc' prefix instead of 'sk'
• Document replacing the clientID and redirect URI in the example code with the developer's own, and to update Example/Info.plist with the custom scheme

Cocoapod doesn't seem to be updated

@allisonc07 Looks like the README and/or the whole package didn't get updated/deployed properly. I notice launchAuthFlow Parameters doesn't have the new param. Please investigate. https://cocoapods.org/pods/SmartcarAuth

D

Documentation missing for AuthorizationError

When a user denies access to an application, the SDK returns an AuthorizationError to the completion handler. There are a few different cases this error is returned as we can see in the callback handling code below:

ios-sdk/SmartcarAuth/SmartcarAuth.swift

Lines 143 to 161 in 2dd06de

	@objc public func handleCallback(with url: URL) -> Any? {
	let urlComp = URLComponents(url: url, resolvingAgainstBaseURL: false)
	guard let query = urlComp?.queryItems else {
	return completion(AuthorizationError.missingQueryParameters, nil, nil)
	}
	let queryState = query.filter({ $0.name == "state"}).first?.value
	if query.filter({ $0.name == "error"}).first?.value != nil {
	return completion(AuthorizationError.accessDenied, nil, queryState)
	}
	guard let code = query.filter({ $0.name == "code"}).first?.value else {
	return completion(AuthorizationError.missingAuthCode, nil, queryState)
	}
	return completion(nil, code, queryState)
	}

There is no documentation around this error. In addition, the detailed error_description returned by the Smartcar Connect flow is also not surfaced.

Parse query string using Swift methods within resumeAuthorizationWithURL

Add support for Swift Package Manager

Since XCode now supporting swift package manager natively, I've been migrating all my dependencies from cocoapods to it. One exception is SmartcarAuth, which doesn't yet support it.

The change should be minimal, just adding the manifest file.