smartcontractkit/foundry-starter-kit

foundry-starter-kit's Issues

Potentially redundant code in VRFConsumerV2

Hey guys,

I was going through
[LinkTokenInterface ](https://github.com/smartcontractkit/foundry-starter-kit/blob/main/src/VRFConsumerV2.sol)

and noticed that you have initialized two interfaces:
VRFCoordinatorV2Interface , LinkTokenInterface .

I understand that VRFCoordinatorV2Interface needs to be initialized to call the requestRandomWords function in it, but why initialize the LinkTokenInterface ????

Especially since it is not being used anywhere.

Am I missing something?

P.S: If this issue is recognized as legit, can I be the one to push a PR?

Unable to find current origin/master revision in submodule path 'lib/chainlink-brownie-contracts'

Error:

fatal: Needed a single revision
Unable to find current origin/master revision in submodule path 'lib/chainlink-brownie-contracts'

Reproduce:

git clone https://github.com/smartcontractkit/foundry-starter-kit
cd foundry-start-kit
make

Env:
Windows 10 WSL2

Change remappings for @chainlink

Should we modify remappings for @chainlink/contracts to point to the official chainlink repo instead of chainlink-brownie-contracts since the first one is more actively maintained? The change will include removing chainlink-brownie-contracts and forge installing smartcontractkit/chainlink which will increase the size of the lib folder, which is the possible downside of this idea.

TLDR:
Update @chainlink/=lib/chainlink-brownie-contracts/ to @chainlink/=lib/chainlink?

APIConsumer rinkeby oracle not working

Hello,

I deployed APIConsumer contract and try to requestVolumeData, it looks like the oracle 0xc57B33452b4F7BB189bB5AfaE9cc4aBa1f7a4FD8 is no longer fullfilling data when requesting.

Last FullfillOracle was > 40 days ago (https://rinkeby.etherscan.io/address/0xc57b33452b4f7bb189bb5afae9cc4aba1f7a4fd8)

Thank you

Use Local Memory Type Variable Instead of Global Storage Type Variable in Event to Save Gas

Hi, we recently have conducted a systematic study about Solidity event usage, evolution, and impact, and we are attempting to build a tool to improve the practice of Solidity event use based on our findings. We have tried our prototype tool on some of the most popular GitHub Solidity repositories, and for your repository, we find a potential optimization of gas consumption arisen from event use.

The point is that when we use emit operation to store the value of a certain variable, local memory type variable would be preferable to global storage type (state) variable if they hold the same value. The reason is that an extra SLOAD operation would be needed to access the variable if it is storage type, and the SLOAD operation costs 800 gas.

For your repository, we find that the following event use can be improved:

• APIConsumer.sol
  function name: fulfill
  event name:  DataFullfilled
  variable:    volume->_volume

    function fulfill(bytes32 _requestId, uint256 _volume)
        public
        recordChainlinkFulfillment(_requestId)
    {
        volume = _volume;
        emit DataFullfilled(volume);
    }

Do you find our results useful? Your reply and invaluable suggestions would be greatly appreciated, and are vital for improving our tool. Thanks a lot for your time!

error- after running make

Error:
Compiler run failed:
Error (2333): Identifier already declared.
--> script/APIConsumer.s.sol:7:1:
|
7 | import "../src/test/mocks/MockOracle.sol";
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: The previous declaration is here:
--> lib/chainlink-brownie-contracts/contracts/src/v0.8/shared/interfaces/LinkTokenInterface.sol:4:1:
|
4 | interface LinkTokenInterface {
| ^ (Relevant source part starts here and spans across multiple lines).

Add CLA

We want to bring this in line with the HH Starter Kit in terms of products demonstrated.

Currently CLA appears to be missing here, and AnyAPI should be removed from here.

cast call to PriceFeedConsumer contract reverts with error "data: Some(String("0x")))"

PriceFeedConsumer Contract is deployed successfully on anvil!

anvil

But cast call to pricefeed consumer fails

Observations:

Calling latestRoundData of pricefeed address returns unknow 0x